fastapi_14371

failed NO_PATCH NO_PATCH UNSUBMITTED empty_patch(None) · None tool calls · 0 s · fastapi/fastapi

Task input

🐛 Fix parameter aliases

This PR fixes the rest of failing tests in #14358.

---

**Note:** for `validation_aliases` only string value is currently supported. We can later think of supporting `AliasPath` and `AliasChoices`


**Will also fix issues:**

<details>

* https://github.com/fastapi/fastapi/discussions/8535
* https://github.com/fastapi/fastapi/discussions/10014

</details>

Tool calls (0)

#	Tool	Arguments	Result
No trace captured.

Test output

show

........F
=================================== FAILURES ===================================
__________ test_required_list_str_alias_schema[/required-list-alias] ___________

path = '/required-list-alias'

    @pytest.mark.parametrize(
        "path",
        [
            "/required-list-alias",
            "/model-required-list-alias",
        ],
    )
    def test_required_list_str_alias_schema(path: str):
        openapi = app.openapi()
        body_model_name = get_body_model_name(openapi, path)
    
>       assert app.openapi()["components"]["schemas"][body_model_name] == {
            "properties": {
                "p_alias": {
                    "items": {"type": "string"},
                    "title": "P Alias",
                    "type": "array",
                },
            },
            "required": ["p_alias"],
            "title": body_model_name,
            "type": "object",
        }
E       AssertionError: assert {'properties'...d_list_alias'} == {'properties'...pe': 'object'}
E         
E         Omitting 2 identical items, use -vv to show
E         Differing items:
E         {'required': ['p']} != {'required': ['p_alias']}
E         {'properties': {'p': {'items': {'type': 'string'}, 'type': 'array', 'title': 'P'}}} != {'properties': {'p_alias': {'items': {'type': 'string'}, 'title': 'P Alias', 'type': 'array'}}}
E         Use -v to get more diff

tests/test_request_params/test_body/test_list.py:131: AssertionError
=============================== warnings summary ===============================
../../../../../../../Users/jp/repos/kaggle-gemini-coding-agent-post-training/.envs/overlays/starlette-0.50.0-py3-none-any/starlette/testclient.py:45
  /Users/jp/repos/kaggle-gemini-coding-agent-post-training/.envs/overlays/starlette-0.50.0-py3-none-any/starlette/testclient.py:45: DeprecationWarning: The anyio.abc.BlockingPortal alias is deprecated, use anyio.from_thread.BlockingPortal instead.
    _PortalFactoryType = Callable[[], AbstractContextManager[anyio.abc.BlockingPortal]]

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
!!!!!!!!!!!!!!!!!!!!!!!!!! stopping after 1 failures !!!!!!!!!!!!!!!!!!!!!!!!!!!
1 failed, 8 passed, 1 warning in 1.15s