fastapi_13537

{
 "command": "grep -rn \"_extract_form_body\" . | head -20"
}

{
 "command": "grep -n \"_get_multidict_value\" fastapi/dependencies/utils.py"
}

{
 "command": "sed -n '723,940p' fastapi/dependencies/utils.py"
}

{
 "command": "sed -n '869,940p' fastapi/dependencies/utils.py"
}

{
 "command": "python3 - <<'PY'\nfrom fastapi import FastAPI, Form\nfrom fastapi.testclient import TestClient\nfrom pydantic import BaseModel\nfrom typing import Optional\n\napp = FastAPI()\n\n@app.post(\"/test\")\nasync def test_endpoint(name: Optional[str] = Form(None)):\n    return {\"name\": name}\n\nclient = TestClient(app)\n\ndef test_empty_string_form():\n    # When name=\"\" is sent in form, it should be interpreted as missing (None)\n    # if the default is None.\n    response = client.post(\"/test\", data={\"name\": \"\"})\n    print(f\"Response with name='': {response.json()}\")\n    assert response.json() == {\"name\": None}\n\ntest_empty_string_form()\nPY\n"
}

{
 "command": "python3 - <<'PY'\nfrom fastapi import FastAPI, Form\nfrom fastapi.testclient import TestClient\nfrom typing import Optional\n\napp = FastAPI()\n\n@app.post(\"/test\")\nasync def test_endpoint(name: Optional[str] = Form(\"default\")):\n    return {\"name\": name}\n\nclient = TestClient(app)\n\ndef test_empty_string_form_with_default():\n    # When name=\"\" is sent in form, it should be interpreted as missing (None)\n    # if the default is \"default\".\n    response = client.post(\"/test\", data={\"name\": \"\"})\n    print(f\"Response with empty string and default 'default': {response.json()}\")\n    # Expected: should use default value \"default\"\n    assert response.json() == {\"name\": \"default\"}\n\ntest_empty_string_form_with_default()\nPY\n"
}

{
 "command": "python3 - <<'PY'\nfrom fastapi import FastAPI, Form\nfrom fastapi.testclient import TestClient\nfrom typing import Optional\n\napp = FastAPI()\n\n@app.post(\"/test\")\nasync def test_endpoint(name: Optional[str] = Form(None)):\n    return {\"name\": name}\n\nclient = TestClient(app)\n\ndef test_empty_string_form():\n    # This is the case described in the issue.\n    # name=\"\" is sent. \n    # _get_multidict_value(field, received_body) sees name=\"\", and since default is None, it returns None.\n    # In _extract_form_body:\n    # if value is not None: values[field.alias] = value  <-- value is None, so not added.\n    # Then:\n    # for key, value in received_body.items():\n    #     if key not in values:\n    #         values[key] = value  <-- 'name' is not in values, so it's added as \"\".\n    # Final values = {\"name\": \"\"}\n    # Validation then uses \"\", and since it's Optional[str], it stays \"\".\n    \n    response = client.post(\"/test\", data={\"name\": \"\"})\n    print(f\"Response with name='': {response.json()}\")\n    # If the bug is present, it returns {'name': ''}.\n    # If fixed, it should return {'name': None} because the empty string should be treated as missing.\n    assert response.json() == {\"name\": None}\n\ntest_empty_string_form()\nPY\n"
}

{
 "command": "python3 - <<'PY'\nfrom fastapi import FastAPI, Form\nfrom fastapi.testclient import TestClient\nfrom typing import Optional\n\napp = FastAPI()\n\n@app.post(\"/test\")\nasync def test_endpoint(name: Optional[int] = Form(None)):\n    return {\"name\": name}\n\nclient = TestClient(app)\n\ndef test_empty_string_form_int():\n    # If the field is int, and empty string is sent, it should be None (default).\n    # But if it's added back as \"\", validation of int will fail.\n    try:\n        response = client.post(\"/test\", data={\"name\": \"\"})\n        print(f\"Response with name='': {response.json()}\")\n    except Exception as e:\n        print(f\"Caught exception: {e}\")\n    \n    # If the bug is present, it will likely return a 422 Unprocessable Entity.\n    # If fixed, it should return {'name': None}.\n    # We use a request and check status code.\n    response = client.post(\"/test\", data={\"name\": \"\"})\n    print(f\"Status code: {response.status_code}, JSON: {response.json()}\")\n    assert response.status_code == 200\n    assert response.json() == {\"name\": None}\n\ntest_empty_string_form_int()\nPY\n"
}

{
 "command": "python3 - <<'PY'\nfrom fastapi import FastAPI, Form\nfrom fastapi.testclient import TestClient\nfrom typing import Optional\n\napp = FastAPI()\n\n@app.post(\"/test\")\nasync def test_endpoint(name: Optional[str] = Form(None)):\n    return {\"name\": name}\n\nclient = TestClient(app)\n\ndef test_empty_string_form():\n    response = client.post(\"/test\", data={\"name\": \"\"})\n    print(f\"Response: {response.json()}\")\n    # This test should fail if the bug is present, and pass if fixed.\n    assert response.json() == {\"name\": None}\n\ntest_empty_string_form()\nPY\n"
}

{
 "command": "cd /workspace && python3 - <<'PY'\nfrom pathlib import Path\np = Path(\"fastapi/dependencies/utils.py\")\ns = p.read_text()\n\n# Current _extract_form_body implementation:\nold = \"\"\"    for field in body_fields:\n        value = _get_multidict_value(field, received_body)\n        field_info = field.field_info\n        if (\n            isinstance(field_info, (params.File, temp_pydantic_v1_params.File))\n            and is_bytes_field(field)\n            and isinstance(value, UploadFile)\n        ):\n            value = await value.read()\n        elif (\n            is_bytes_sequence_field(field)\n            and isinstance(field_info, (params.File, temp_pydantic_v1_params.File))\n            and value_is_sequence(value)\n        ):\n            # For types\n            assert isinstance(value, sequence_types)  # type: ignore[arg-type]\n            results: List[Union[bytes, str]] = []\n\n            async def process_fn(\n                fn: Callable[[], Coroutine[Any, Any, Any]],\n            ) -> None:\n                result = await fn()\n                results.append(result)  # noqa: B023\n\n            async with anyio.create_task_group() as tg:\n                for sub_value in value:\n                    tg.start_soon(process_fn, sub_value.read)\n            value = serialize_sequence_value(field=field, value=results)\n        if value is not None:\n            values[field.alias] = value\n    for key, value in received_body.items():\n        if key not in values:\n            values[key] = value\"\"\"\n\n# Fixed implementation: keep track of processed keys.\nnew = \"\"\"    processed_keys = set()\n    for field in body_fields:\n        value = _get_multidict_value(field, received_body)\n        field_info = field.field_info\n        if (\n            isinstance(field_info, (params.File, temp_pydantic_v1_params.File))\n            and is_bytes_field(field)\n            and isinstance(value, UploadFile)\n        ):\n            value = await value.read()\n        elif (\n            is_bytes_sequence_field(field)\n            and isinstance(field_info, (params.File, temp_pydantic_v1_params.File))\n            and value_is_sequence(value)\n        ):\n            # For types\n            assert isinstance(value, sequence_types)  # type: ignore[arg-type]\n            results: List[Union[bytes, str]] = []\n\n            async def process_fn(\n                fn: Callable[[], Coroutine[Any, Any, Any]],\n            ) -> None:\n                result = await fn()\n                results.append(result)  # noqa: B023\n\n            async with anyio.create_task_group() as tg:\n                for sub_value in value:\n                    tg.start_soon(process_fn, sub_value.read)\n            value = serialize_sequence_value(field=field, value=results)\n        if value is not None:\n            values[field.alias] = value\n        processed_keys.add(field.alias)\n    for key, value in received_body.items():\n        if key not in processed_keys:\n            values[key] = value\"\"\"\n\nassert s.count(old) == 1, \"old text not found\"\nt = s.replace(old, new)\np.write_text(t)\nPY\n"
}

{
 "command": "python3 - <<'PY'\nfrom fastapi import FastAPI, Form\nfrom fastapi.testclient import TestClient\nfrom typing import Optional\n\napp = FastAPI()\n\n@app.post(\"/test\")\nasync def test_endpoint(name: Optional[str] = Form(None)):\n    return {\"name\": name}\n\nclient = TestClient(app)\n\ndef test_empty_string_form():\n    response = client.post(\"/test\", data={\"name\": \"\"})\n    print(f\"Response: {response.json()}\")\n    # Now it should be None because empty string is interpreted as missing\n    # and NOT added back in the second loop because 'name' is in processed_keys.\n    assert response.json() == {\"name\": None}\n\ntest_empty_string_form()\nPY\n"
}

{
 "command": "python3 - <<'PY'\nfrom fastapi import FastAPI, Form\nfrom fastapi.testclient import TestClient\nfrom typing import Optional\n\napp = FastAPI()\n\n@app.post(\"/test\")\nasync def test_endpoint(name: Optional[int] = Form(None)):\n    return {\"name\": name}\n\nclient = TestClient(app)\n\ndef test_empty_string_form_int():\n    response = client.post(\"/test\", data={\"name\": \"\"})\n    print(f\"Response: {response.json()}\")\n    # Should be None, not 422.\n    assert response.status_code == 200\n    assert response.json() == {\"name\": None}\n\ntest_empty_string_form_int()\nPY\n"
}

{
 "command": "python3 - <<'PY'\nfrom fastapi import FastAPI, Form\nfrom fastapi.testclient import TestClient\nfrom typing import Optional\n\napp = FastAPI()\n\n@app.post(\"/test\")\nasync def test_endpoint(name: Optional[str] = Form(\"default\")):\n    return {\"name\": name}\n\nclient = TestClient(app)\n\ndef test_empty_string_form_with_default():\n    response = client.post(\"/test\", data={\"name\": \"\"})\n    print(f\"Response: {response.json()}\")\n    # Should be 'default'.\n    assert response.json() == {\"name\": \"default\"}\n\ntest_empty_string_form_with_default()\nPY\n"
}

{
 "command": "python3 - <<'PY'\nfrom fastapi import FastAPI, Form\nfrom fastapi.testclient import TestClient\nfrom typing import Optional\n\napp = FastAPI()\n\n@app.post(\"/test\")\nasync def test_endpoint(name: str = Form(...)):\n    return {\"name\": name}\n\nclient = TestClient(app)\n\ndef test_empty_string_form_required():\n    # If required, empty string should trigger validation error (if it's treated as missing)\n    response = client.post(\"/test\", data={\"name\": \"\"})\n    print(f\"Status: {response.status_code}, JSON: {response.json()}\")\n    assert response.status_code == 422\n\ntest_empty_string_form_required()\nPY\n"
}

{
 "command": "git diff"
}

{
 "command": "submit_patch"
}

{}