failed NO_PATCH NO_PATCH UNSUBMITTED empty_patch(budget) ยท 38 tool calls ยท 301 s ยท fastapi/fastapi
๐ Fix separation of schemas with nested models introduced in 0.119.0 ๐ Fix separation of schemas with nested models introduced in 0.119.0 This should fix / related to https://github.com/fastapi/fastapi/issues/14247 (https://github.com/fastapi/fastapi/discussions/14177)
| # | Tool | Arguments | Result |
|---|---|---|---|
| 1 | run_command | {
"command": "cat > /tmp/reproduce_issue.py <<'PY'\nfrom fastapi import FastAPI\nfrom pydantic import BaseModel\nfrom fastapi.testclient import TestClient\n\napp = FastAPI()\n\nclass Item(BaseModel):\n name: str\n description: str | None = None\n\nclass ItemIn(BaseModel):\n name: str\n description: str | None = None\n\nclass ItemOut(BaseModel):\n name: str\n description: str | None = None\n id: int\n\nclass Order(BaseModel):\n id: int\n items: list[Item]\n\nclass OrderIn(BaseModel):\n items: list[ItemIn]\n\nclass OrderOut(BaseModel):\n id: int\n items: list[ItemOut]\n\n@app.post(\"/orders/\", response_model=OrderOut)\nasync def create_order(order: OrderIn):\n # Simulate creating an order and assigning IDs to items\n order_id = 1\n item_outs = [ItemOut(name=item.name, description=item.description, id=idx) \n for idx, item in enumerate(order.items)]\n return OrderOut(id=order_id, items=item_outs)\n\nclient = TestClient(app)\n\ndef test_order_schema():\n response = client.post(\"/orders/\", json={\"items\": [{\"name\": \"item1\", \"description\": \"desc1\"}]})\n assert response.status_code == 200\n assert response.json() == {\"id\": 1, \"items\": [{\"name\": \"item1\", \"description\": \"desc1\", \"id\": 0}]}\n\nif __name__ == \"__main__\":\n try:\n test_order_schema()\n print(\"Test passed!\")\n except Exception as e:\n print(f\"Test failed: {e}\")\nPY\npython3 /tmp/reproduce_issue.py\n"
} | {"status": "ok", "stdout": "Test passed!\n", "stderr": "", "exit_code": 0}full{"status": "ok", "stdout": "Test passed!\n", "stderr": "", "exit_code": 0} |
| 2 | run_command | {
"command": "cat > /tmp/reproduce_issue.py <<'PY'\nfrom fastapi import FastAPI\nfrom pydantic import BaseModel\nfrom fastapi.testclient import TestClient\nfrom fastapi.openapi.utils import get_openapi\n\napp = FastAPI()\n\nclass Item(BaseModel):\n name: str\n description: str | None = None\n\nclass ItemIn(BaseModel):\n name: str\n description: str | None = None\n\nclass ItemOut(BaseModel):\n name: str\n description: str | None = None\n id: int\n\nclass OrderIn(BaseModel):\n items: list[ItemIn]\n\nclass OrderOut(BaseModel):\n id: int\n items: list[ItemOut]\n\n@app.post(\"/orders/\", response_model=OrderOut)\nasync def create_order(order: OrderIn):\n return {\"id\": 1, \"items\": [{\"name\": \"item1\", \"description\": \"desc1\", \"id\": 0}]}\n\ndef test_openapi_schemas():\n openapi_schema = get_openapi(app, app.title, app.version, app.openapi_version, app.description, app.routes)\n schemas = openapi_schema[\"components\"][\"schemas\"]\n \n # We expect OrderIn and OrderOut to be separate\n assert \"OrderIn\" in schemas\n assert \"OrderOut\" in schemas\n \n # We expect ItemIn and ItemOut to be separate\n assert \"ItemIn\" in schemas\n assert \"ItemOut\" in schemas\n \n # Check if OrderIn uses ItemIn\n order_in_ref = schemas[\"OrderIn\"][\"properties\"][\"items\"][\"items\"][\"$ref\"]\n assert order_in_ref == \"#/components/schemas/ItemIn\"\n \n # Check if OrderOut uses ItemOut\n order_out_ref = schemas[\"OrderOut\"][\"properties\"][\"items\"][\"items\"][\"$ref\"]\n assert order_out_ref == \"#/components/schemas/ItemOut\"\n\nif __name__ == \"__main__\":\n try:\n test_openapi_schemas()\n print(\"Test passed!\")\n except AssertionError as e:\n import json\n # Print the actual schemas to see what happened\n # app.openapi() would be easier but get_openapi is what's used internally\n openapi_schema = get_openapi(app, app.title, app.version, app.openapi_version, app.description, app.routes)\n print(json.dumps(openapi_schema[\"components\"][\"schemas\"], indent=2))\n print(f\"\\nAssertion failed: {e}\")\n except Exception as e:\n print(f\"Test failed: {e}\")\nPY\npython3 /tmp/reproduce_issue.py\n"
} | {"status": "ok", "stdout": "Test failed: get_openapi() takes 0 positional arguments but 6 were given\n", "stderr": "", "exit_code": 0}full{"status": "ok", "stdout": "Test failed: get_openapi() takes 0 positional arguments but 6 were given\n", "stderr": "", "exit_code": 0} |
| 3 | run_command | {
"command": "python3 -c \"from fastapi.openapi.utils import get_openapi; print(get_openapi.__code__.co_varnames)\"\n"
} | {"status": "ok", "stdout": "('title', 'version', 'openapi_version', 'summary', 'description', 'routes', 'webhooks', 'tags', 'servers', 'terms_of_service', 'contfull{"status": "ok", "stdout": "('title', 'version', 'openapi_version', 'summary', 'description', 'routes', 'webhooks', 'tags', 'servers', 'terms_of_service', 'contact', 'license_info', 'separate_input_output_schemas', 'external_docs', 'info', 'output', 'components', 'paths', 'webhook_paths', 'operation_ids', 'all_fields', 'model_name_map', 'field_mapping', 'definitions', 'route', 'result', 'path', 'security_schemes', 'path_definitions', 'webhook', 'k')\n", "stderr": "", "exit_code": 0} |
| 4 | run_command | {
"command": "cat > /tmp/reproduce_issue.py <<'PY'\nfrom fastapi import FastAPI\nfrom pydantic import BaseModel\nfrom fastapi.openapi.utils import get_openapi\n\napp = FastAPI()\n\nclass ItemIn(BaseModel):\n name: str\n description: str | None = None\n\nclass ItemOut(BaseModel):\n name: str\n description: str | None = None\n id: int\n\nclass OrderIn(BaseModel):\n items: list[ItemIn]\n\nclass OrderOut(BaseModel):\n id: int\n items: list[ItemOut]\n\n@app.post(\"/orders/\", response_model=OrderOut)\nasync def create_order(order: OrderIn):\n return {\"id\": 1, \"items\": [{\"name\": \"item1\", \"description\": \"desc1\", \"id\": 0}]}\n\ndef test_openapi_schemas():\n # Use app.openapi() which handles all the calls to get_openapi internally\n openapi_schema = app.openapi()\n schemas = openapi_schema[\"components\"][\"schemas\"]\n \n # We expect OrderIn and OrderOut to be separate\n assert \"OrderIn\" in schemas, f\"OrderIn missing from schemas: {list(schemas.keys())}\"\n assert \"OrderOut\" in schemas, f\"OrderOut missing from schemas: {list(schemas.keys())}\"\n \n # We expect ItemIn and ItemOut to be separate\n assert \"ItemIn\" in schemas, f\"ItemIn missing from schemas: {list(schemas.keys())}\"\n assert \"ItemOut\" in schemas, f\"ItemOut missing from schemas: {list(schemas.keys())}\"\n \n # Check if OrderIn uses ItemIn\n order_in_ref = schemas[\"OrderIn\"][\"properties\"][\"items\"][\"items\"][\"$ref\"]\n assert order_in_ref == \"#/components/schemas/ItemIn\", f\"OrderIn should use ItemIn, got {order_in_ref}\"\n \n # Check if OrderOut uses ItemOut\n order_out_ref = schemas[\"OrderOut\"][\"properties\"][\"items\"][\"items\"][\"$ref\"]\n assert order_out_ref == \"#/components/schemas/ItemOut\", f\"OrderOut should use ItemOut, got {order_out_ref}\"\n\nif __name__ == \"__main__\":\n try:\n test_openapi_schemas()\n print(\"Test passed!\")\n except AssertionError as e:\n import json\n openapi_schema = app.openapi()\n print(json.dumps(openapi_schema[\"components\"][\"schemas\"], indent=2))\n print(f\"\\nAssertion failed: {e}\")\n except Exception as e:\n import traceback\n traceback.print_exc()\n print(f\"Test failed: {e}\")\nPY\npython3 /tmp/reproduce_issue.py\n"
} | {"status": "ok", "stdout": "Test passed!\n", "stderr": "", "exit_code": 0}full{"status": "ok", "stdout": "Test passed!\n", "stderr": "", "exit_code": 0} |
| 5 | run_command | {
"command": "cat > /tmp/reproduce_issue.py <<'PY'\nfrom fastapi import FastAPI\nfrom pydantic import BaseModel\nfrom fastapi.openapi.utils import get_openapi\n\napp = FastAPI()\n\nclass ItemIn(BaseModel):\n name: str\n\nclass ItemOut(BaseModel):\n name: str\n id: int\n\nclass OrderIn(BaseModel):\n items: list[ItemIn]\n\nclass OrderOut(BaseModel):\n items: list[ItemOut]\n\n@app.post(\"/orders/\", response_model=OrderOut)\nasync def create_order(order: OrderIn):\n return {\"items\": [{\"name\": \"item1\", \"id\": 1}]}\n\ndef test_openapi_schemas():\n openapi_schema = app.openapi()\n schemas = openapi_schema[\"components\"][\"schemas\"]\n \n # OrderIn and OrderOut are separate.\n # But ItemIn and ItemOut might be merged if they are considered the \"same\"\n # because they have the same name \"Item\" (if they were named Item).\n # In my case they are named ItemIn and ItemOut.\n \n assert \"OrderIn\" in schemas\n assert \"OrderOut\" in schemas\n assert \"ItemIn\" in schemas\n assert \"ItemOut\" in schemas\n\nif __name__ == \"__main__\":\n try:\n test_openapi_schemas()\n print(\"Test passed!\")\n except AssertionError as e:\n import json\n openapi_schema = app.openapi()\n print(json.dumps(openapi_schema[\"components\"][\"schemas\"], indent=2))\n print(f\"\\nAssertion failed: {e}\")\nPY\npython3 /tmp/reproduce_issue.py\n"
} | {"status": "ok", "stdout": "Test passed!\n", "stderr": "", "exit_code": 0}full{"status": "ok", "stdout": "Test passed!\n", "stderr": "", "exit_code": 0} |
| 6 | run_command | {
"command": "cat > /tmp/reproduce_issue.py <<'PY'\nfrom fastapi import FastAPI\nfrom pydantic import BaseModel\n\napp = FastAPI()\n\nclass Item(BaseModel):\n name: str\n description: str | None = None\n\nclass ItemIn(BaseModel):\n name: str\n description: str | None = None\n\nclass ItemOut(BaseModel):\n name: str\n description: str | None = None\n id: int\n\nclass OrderIn(BaseModel):\n items: list[Item]\n\nclass OrderOut(BaseModel):\n id: int\n items: list[ItemOut]\n\n@app.post(\"/orders/\", response_model=OrderOut)\nasync def create_order(order: OrderIn):\n return {\"id\": 1, \"items\": [{\"name\": \"item1\", \"description\": \"desc1\", \"id\": 0}]}\n\ndef test_openapi_schemas():\n openapi_schema = app.openapi()\n schemas = openapi_schema[\"components\"][\"schemas\"]\n \n # OrderIn should use Item\n # OrderOut should use ItemOut\n \n order_in_ref = schemas[\"OrderIn\"][\"properties\"][\"items\"][\"items\"][\"$ref\"]\n order_out_ref = schemas[\"OrderOut\"][\"properties\"][\"items\"][\"items\"][\"$ref\"]\n \n print(f\"OrderIn ref: {order_in_ref}\")\n print(f\"OrderOut ref: {order_out_ref}\")\n \n assert order_in_ref != order_out_ref, \"OrderIn and OrderOut should refer to different models for items\"\n\nif __name__ == \"__main__\":\n try:\n test_openapi_schemas()\n print(\"Test passed!\")\n except AssertionError as e:\n print(f\"Assertion failed: {e}\")\n except Exception as e:\n print(f\"Test failed: {e}\")\nPY\npython3 /tmp/reproduce_issue.py\n"
} | {"status": "ok", "stdout": "OrderIn ref: #/components/schemas/Item\nOrderOut ref: #/components/schemas/ItemOut\nTest passed!\n", "stderr": "", "exit_code": 0}full{"status": "ok", "stdout": "OrderIn ref: #/components/schemas/Item\nOrderOut ref: #/components/schemas/ItemOut\nTest passed!\n", "stderr": "", "exit_code": 0} |
| 7 | run_command | {
"command": "cat > /tmp/reproduce_issue.py <<'PY'\nfrom fastapi import FastAPI\nfrom pydantic import BaseModel\n\napp = FastAPI()\n\nclass Item(BaseModel):\n name: str\n description: str | None = None\n\nclass OrderIn(BaseModel):\n items: list[Item]\n\nclass OrderOut(BaseModel):\n id: int\n items: list[Item]\n\n@app.post(\"/orders/\", response_model=OrderOut)\nasync def create_order(order: OrderIn):\n return {\"id\": 1, \"items\": [{\"name\": \"item1\", \"description\": \"desc1\"}]}\n\ndef test_openapi_schemas():\n openapi_schema = app.openapi()\n schemas = openapi_schema[\"components\"][\"schemas\"]\n \n # In FastAPI, OrderIn and OrderOut should be separated into OrderIn and OrderOut\n # because separate_input_output_schemas=True by default.\n # But Item is used in both. \n # Since Item is the same model, it should probably remain as 'Item'.\n # However, the issue says \"separation of schemas with nested models\".\n # Maybe it means if we have OrderIn and OrderOut, and they both have a nested Item,\n # then the nested Item should also be separated?\n \n print(f\"Schemas: {list(schemas.keys())}\")\n \n assert \"OrderIn\" in schemas\n assert \"OrderOut\" in schemas\n \n order_in_ref = schemas[\"OrderIn\"][\"properties\"][\"items\"][\"items\"][\"$ref\"]\n order_out_ref = schemas[\"OrderOut\"][\"properties\"][\"items\"][\"items\"][\"$ref\"]\n \n print(f\"OrderIn items ref: {order_in_ref}\")\n print(f\"OrderOut items ref: {order_out_ref}\")\n \n # If separate_input_output_schemas=True, maybe Item should also be separated?\n # Let's see what actually happens.\n \nif __name__ == \"__main__\":\n try:\n test_openapi_schemas()\n print(\"Finished test\")\n except Exception as e:\n import traceback\n traceback.print_exc()\nPY\npython3 /tmp/reproduce_issue.py\n"
} | {"status": "ok", "stdout": "Schemas: ['HTTPValidationError', 'Item', 'OrderIn', 'OrderOut', 'ValidationError']\nOrderIn items ref: #/components/schemas/Item\nOrfull{"status": "ok", "stdout": "Schemas: ['HTTPValidationError', 'Item', 'OrderIn', 'OrderOut', 'ValidationError']\nOrderIn items ref: #/components/schemas/Item\nOrderOut items ref: #/components/schemas/Item\nFinished test\n", "stderr": "", "exit_code": 0} |
| 8 | run_command | {
"command": "cat > /tmp/reproduce_issue.py <<'PY'\nfrom fastapi import FastAPI\nfrom pydantic import BaseModel\n\napp = FastAPI()\n\nclass Item(BaseModel):\n name: str\n\nclass Order(BaseModel):\n items: list[Item]\n\n@app.post(\"/orders/\", response_model=Order)\nasync def create_order(order: Order):\n return order\n\ndef test_openapi_schemas():\n openapi_schema = app.openapi()\n schemas = openapi_schema[\"components\"][\"schemas\"]\n \n # Since Order is used for both request and response, it should stay as Order\n # unless separate_input_output_schemas=True (which is default) AND it's used in both.\n # Wait, if it's the same model, it usually stays as one.\n \n print(f\"Schemas: {list(schemas.keys())}\")\n\nif __name__ == \"__main__\":\n test_openapi_schemas()\nPY\npython3 /tmp/reproduce_issue.py\n"
} | {"status": "ok", "stdout": "Schemas: ['HTTPValidationError', 'Item', 'Order', 'ValidationError']\n", "stderr": "", "exit_code": 0}full{"status": "ok", "stdout": "Schemas: ['HTTPValidationError', 'Item', 'Order', 'ValidationError']\n", "stderr": "", "exit_code": 0} |
| 9 | run_command | {
"command": "cat > /tmp/reproduce_issue.py <<'PY'\nfrom fastapi import FastAPI\nfrom pydantic import BaseModel\n\napp = FastAPI()\n\nclass Item(BaseModel):\n name: str\n\nclass Order(BaseModel):\n items: list[Item]\n\n@app.post(\"/orders/\", response_model=Order)\nasync def create_order(order: Order):\n # Here Order is used as both request body and response model.\n return order\n\ndef test_openapi_schemas():\n openapi_schema = app.openapi()\n schemas = openapi_schema[\"components\"][\"schemas\"]\n \n # By default, fastapi separates input and output schemas if they are the same model\n # but used in different roles (request vs response) if they have different fields?\n # No, if it is exactly the same model, it's usually one.\n \n print(f\"Schemas: {list(schemas.keys())}\")\n\nif __name__ == \"__main__\":\n test_openapi_schemas()\nPY\npython3 /tmp/reproduce_issue.py\n"
} | {"status": "ok", "stdout": "Schemas: ['HTTPValidationError', 'Item', 'Order', 'ValidationError']\n", "stderr": "", "exit_code": 0}full{"status": "ok", "stdout": "Schemas: ['HTTPValidationError', 'Item', 'Order', 'ValidationError']\n", "stderr": "", "exit_code": 0} |
| 10 | run_command | {
"command": "cat > /tmp/reproduce_issue.py <<'PY'\nfrom fastapi import FastAPI\nfrom pydantic import BaseModel\n\napp = FastAPI()\n\nclass Item(BaseModel):\n name: str\n\nclass OrderIn(BaseModel):\n items: list[Item]\n\nclass OrderOut(BaseModel):\n items: list[Item]\n\n@app.post(\"/orders/\", response_model=OrderOut)\nasync def create_order(order: OrderIn):\n return order\n\ndef test_openapi_schemas():\n openapi_schema = app.openapi()\n schemas = openapi_schema[\"components\"][\"schemas\"]\n \n print(f\"Schemas: {list(schemas.keys())}\")\n \n order_in_ref = schemas[\"OrderIn\"][\"properties\"][\"items\"][\"items\"][\"$ref\"]\n order_out_ref = schemas[\"OrderOut\"][\"properties\"][\"items\"][\"items\"][\"$ref\"]\n \n print(f\"OrderIn items ref: {order_in_ref}\")\n print(f\"OrderOut items ref: {order_out_ref}\")\n \n # If Item is the same, it should be the same ref.\n # BUT, if OrderIn and OrderOut are separated, should Item also be separated?\n # No, because Item is the same model.\n \nif __name__ == \"__main__\":\n test_openapi_schemas()\nPY\npython3 /tmp/reproduce_issue.py\n"
} | {"status": "ok", "stdout": "Schemas: ['HTTPValidationError', 'Item', 'OrderIn', 'OrderOut', 'ValidationError']\nOrderIn items ref: #/components/schemas/Item\nOrfull{"status": "ok", "stdout": "Schemas: ['HTTPValidationError', 'Item', 'OrderIn', 'OrderOut', 'ValidationError']\nOrderIn items ref: #/components/schemas/Item\nOrderOut items ref: #/components/schemas/Item\n", "stderr": "", "exit_code": 0} |
| 11 | run_command | {
"command": "cat > /tmp/reproduce_issue.py <<'PY'\nfrom fastapi import FastAPI\nfrom pydantic import BaseModel\n\napp = FastAPI()\n\nclass Item(BaseModel):\n name: str\n\nclass OrderIn(BaseModel):\n items: list[Item]\n\nclass OrderOut(BaseModel):\n items: list[Item]\n\n@app.post(\"/orders/\", response_model=OrderOut)\nasync def create_order(order: OrderIn):\n return order\n\ndef test_openapi_schemas():\n # Try with separate_input_output_schemas=True (default)\n openapi_schema = app.openapi()\n schemas = openapi_schema[\"components\"][\"schemas\"]\n \n print(f\"Schemas: {list(schemas.keys())}\")\n\nif __name__ == \"__main__\":\n test_openapi_schemas()\nPY\npython3 /tmp/reproduce_issue.py\n"
} | {"status": "ok", "stdout": "Schemas: ['HTTPValidationError', 'Item', 'OrderIn', 'OrderOut', 'ValidationError']\n", "stderr": "", "exit_code": 0}full{"status": "ok", "stdout": "Schemas: ['HTTPValidationError', 'Item', 'OrderIn', 'OrderOut', 'ValidationError']\n", "stderr": "", "exit_code": 0} |
| 12 | run_command | {
"command": "cat > /tmp/reproduce_issue.py <<'PY'\nfrom fastapi import FastAPI\nfrom pydantic import BaseModel\n\napp = FastAPI()\n\nclass Item(BaseModel):\n name: str\n\nclass Order(BaseModel):\n items: list[Item]\n\n@app.post(\"/orders/\", response_model=Order)\nasync def create_order(order: Order):\n return order\n\ndef test_openapi_schemas():\n # If we force separation, we might see something.\n # But how to force it for the same model? \n # FastAPI normally separates if they are different.\n \n # Let's try different models but with same name (not possible in Python)\n # or different Pydantic models that are structurally same.\n \n pass\n\nif __name__ == \"__main__\":\n test_openapi_schemas()\nPY\npython3 /tmp/reproduce_issue.py\n"
} | {"status": "ok", "stdout": "", "stderr": "", "exit_code": 0}full{"status": "ok", "stdout": "", "stderr": "", "exit_code": 0} |
| 13 | run_command | {
"command": "grep -rn \"separate_input_output_schemas\" fastapi/openapi/utils.py\n"
} | {"status": "ok", "stdout": "fastapi/openapi/utils.py:102: separate_input_output_schemas: bool = True,\nfastapi/openapi/utils.py:133: separate_input_output_schemfull{"status": "ok", "stdout": "fastapi/openapi/utils.py:102: separate_input_output_schemas: bool = True,\nfastapi/openapi/utils.py:133: separate_input_output_schemas=separate_input_output_schemas,\nfastapi/openapi/utils.py:175: separate_input_output_schemas: bool = True,\nfastapi/openapi/utils.py:184: separate_input_output_schemas=separate_input_output_schemas,\nfastapi/openapi/utils.py:258: separate_input_output_schemas: bool = True,\nfastapi/openapi/utils.py:288: separate_input_output_schemas=separate_input_output_schemas,\nfastapi/openapi/utils.py:309: separate_input_output_schemas=separate_input_output_schemas,\nfastapi/openapi/utils.py:326: separate_input_output_schemas=separate_input_output_schemas,\nfastapi/openapi/utils.py:356: separate_input_output_schemas=separate_input_output_schemas,\nfastapi/openapi/utils.py:389: separate_input_output_schemas=separate_input_output_schemas,\nfastapi/openapi/utils.py:481: separate_input_output_schemas: bool = True,\nfastapi/openapi/utils.py:507: separate_input_output_schemas=separate_input_output_schemas,\nfastapi/openapi/utils.py:516: separate_input_output_schemas=separate_input_output_schemas,\nfastapi/openapi/utils.py:535: separate_input_output_schemas=separate_input_output_schemas,\n", "stderr": "", "exit_code": 0} |
| 14 | run_command | {
"command": "sed -n '100,180p' fastapi/openapi/utils.py\n"
} | {"status": "ok", "stdout": " Tuple[ModelField, Literal[\"validation\", \"serialization\"]], JsonSchemaValue\n ],\n separate_input_output_schemas: bool = True,\nfull{"status": "ok", "stdout": " Tuple[ModelField, Literal[\"validation\", \"serialization\"]], JsonSchemaValue\n ],\n separate_input_output_schemas: bool = True,\n) -> List[Dict[str, Any]]:\n parameters = []\n flat_dependant = get_flat_dependant(dependant, skip_repeats=True)\n path_params = _get_flat_fields_from_params(flat_dependant.path_params)\n query_params = _get_flat_fields_from_params(flat_dependant.query_params)\n header_params = _get_flat_fields_from_params(flat_dependant.header_params)\n cookie_params = _get_flat_fields_from_params(flat_dependant.cookie_params)\n parameter_groups = [\n (ParamTypes.path, path_params),\n (ParamTypes.query, query_params),\n (ParamTypes.header, header_params),\n (ParamTypes.cookie, cookie_params),\n ]\n default_convert_underscores = True\n if len(flat_dependant.header_params) == 1:\n first_field = flat_dependant.header_params[0]\n if lenient_issubclass(first_field.type_, BaseModel):\n default_convert_underscores = getattr(\n first_field.field_info, \"convert_underscores\", True\n )\n for param_type, param_group in parameter_groups:\n for param in param_group:\n field_info = param.field_info\n # field_info = cast(Param, field_info)\n if not getattr(field_info, \"include_in_schema\", True):\n continue\n param_schema = get_schema_from_model_field(\n field=param,\n model_name_map=model_name_map,\n field_mapping=field_mapping,\n separate_input_output_schemas=separate_input_output_schemas,\n )\n name = param.alias\n convert_underscores = getattr(\n param.field_info,\n \"convert_underscores\",\n default_convert_underscores,\n )\n if (\n param_type == ParamTypes.header\n |
| 15 | run_command | {
"command": "cat > /tmp/reproduce_issue.py <<'PY'\nfrom fastapi import FastAPI\nfrom pydantic import BaseModel\nfrom typing import List\n\napp = FastAPI()\n\nclass Item(BaseModel):\n name: str\n\nclass OrderIn(BaseModel):\n items: List[Item]\n\nclass OrderOut(BaseModel):\n items: List[Item]\n\n@app.post(\"/orders/\", response_model=OrderOut)\nasync def create_order(order: OrderIn):\n return order\n\ndef test_openapi_schemas():\n openapi_schema = app.openapi()\n schemas = openapi_schema[\"components\"][\"schemas\"]\n \n print(f\"Schemas: {list(schemas.keys())}\")\n \n # If separate_input_output_schemas=True (default), \n # OrderIn and OrderOut should be separate.\n # But they both use Item. \n # The issue reports \"separation of schemas with nested models\".\n # This suggests that if the parent models are separated, the nested models should also be separated.\n # So we should see 'ItemIn' and 'ItemOut' (or similar) instead of just 'Item'.\n \n assert \"OrderIn\" in schemas\n assert \"OrderOut\" in schemas\n \n order_in_ref = schemas[\"OrderIn\"][\"properties\"][\"items\"][\"items\"][\"$ref\"]\n order_out_ref = schemas[\"OrderOut\"][\"properties\"][\"items\"][\"items\"][\"$ref\"]\n \n print(f\"OrderIn items ref: {order_in_ref}\")\n print(f\"OrderOut items ref: {order_out_ref}\")\n \n assert order_in_ref != order_out_ref, \"Nested models should be separated when parent models are separated\"\n\nif __name__ == \"__main__\":\n try:\n test_openapi_schemas()\n print(\"Test passed!\")\n except AssertionError as e:\n import json\n print(json.dumps(app.openapi()[\"components\"][\"schemas\"], indent=2))\n print(f\"\\nAssertion failed: {e}\")\n except Exception as e:\n print(f\"Test failed: {e}\")\nPY\npython3 /tmp/reproduce_issue.py\n"
} | {"status": "ok", "stdout": "Schemas: ['HTTPValidationError', 'Item', 'OrderIn', 'OrderOut', 'ValidationError']\nOrderIn items ref: #/components/schemas/Item\nOrfull{"status": "ok", "stdout": "Schemas: ['HTTPValidationError', 'Item', 'OrderIn', 'OrderOut', 'ValidationError']\nOrderIn items ref: #/components/schemas/Item\nOrderOut items ref: #/components/schemas/Item\n{\n \"HTTPValidationError\": {\n \"properties\": {\n \"detail\": {\n \"items\": {\n \"$ref\": \"#/components/schemas/ValidationError\"\n },\n \"type\": \"array\",\n \"title\": \"Detail\"\n }\n },\n \"type\": \"object\",\n \"title\": \"HTTPValidationError\"\n },\n \"Item\": {\n \"properties\": {\n \"name\": {\n \"type\": \"string\",\n \"title\": \"Name\"\n }\n },\n \"type\": \"object\",\n \"required\": [\n \"name\"\n ],\n \"title\": \"Item\"\n },\n \"OrderIn\": {\n \"properties\": {\n \"items\": {\n \"items\": {\n \"$ref\": \"#/components/schemas/Item\"\n },\n \"type\": \"array\",\n \"title\": \"Items\"\n }\n },\n \"type\": \"object\",\n \"required\": [\n \"items\"\n ],\n \"title\": \"OrderIn\"\n },\n \"OrderOut\": {\n \"properties\": {\n \"items\": {\n \"items\": {\n \"$ref\": \"#/components/schemas/Item\"\n },\n \"type\": \"array\",\n \"title\": \"Items\"\n }\n },\n \"type\": \"object\",\n \"required\": [\n \"items\"\n ],\n \"title\": \"OrderOut\"\n },\n \"ValidationError\": {\n \"properties\": {\n \"loc\": {\n \"items\": {\n \"anyOf\": [\n {\n \"type\": \"string\"\n },\n {\n \"type\": \"integer\"\n }\n ]\n },\n \"type\": \"array\",\n \"title\": \"Location\"\n },\n \"msg\": {\n \"type\": \"string\",\n \"title\": \"Message\"\n },\n \"type\": {\n \"type\": \"string\",\n \"title\": \"Error Type\"\n }\n },\n \"type\": \"object\",\n \"r |
| 16 | run_command | {
"command": "grep -rn \"get_schema_from_model_field\" fastapi/openapi/utils.py\n"
} | {"status": "ok", "stdout": "fastapi/openapi/utils.py:13: get_schema_from_model_field,\nfastapi/openapi/utils.py:129: param_schema = get_schema_from_model_field(full{"status": "ok", "stdout": "fastapi/openapi/utils.py:13: get_schema_from_model_field,\nfastapi/openapi/utils.py:129: param_schema = get_schema_from_model_field(\nfastapi/openapi/utils.py:180: body_schema = get_schema_from_model_field(\nfastapi/openapi/utils.py:352: response_schema = get_schema_from_model_field(\nfastapi/openapi/utils.py:385: additional_field_schema = get_schema_from_model_field(\n", "stderr": "", "exit_code": 0} |
| 17 | run_command | {
"command": "sed -n '1,100p' fastapi/openapi/utils.py\n"
} | {"status": "ok", "stdout": "import http.client\nimport inspect\nimport warnings\nfrom typing import Any, Dict, List, Optional, Sequence, Set, Tuple, Type, Unionfull{"status": "ok", "stdout": "import http.client\nimport inspect\nimport warnings\nfrom typing import Any, Dict, List, Optional, Sequence, Set, Tuple, Type, Union, cast\n\nfrom fastapi import routing\nfrom fastapi._compat import (\n JsonSchemaValue,\n ModelField,\n Undefined,\n get_compat_model_name_map,\n get_definitions,\n get_schema_from_model_field,\n lenient_issubclass,\n)\nfrom fastapi.datastructures import DefaultPlaceholder\nfrom fastapi.dependencies.models import Dependant\nfrom fastapi.dependencies.utils import (\n _get_flat_fields_from_params,\n get_flat_dependant,\n get_flat_params,\n)\nfrom fastapi.encoders import jsonable_encoder\nfrom fastapi.openapi.constants import METHODS_WITH_BODY, REF_PREFIX\nfrom fastapi.openapi.models import OpenAPI\nfrom fastapi.params import Body, ParamTypes\nfrom fastapi.responses import Response\nfrom fastapi.types import ModelNameMap\nfrom fastapi.utils import (\n deep_dict_update,\n generate_operation_id_for_path,\n is_body_allowed_for_status_code,\n)\nfrom pydantic import BaseModel\nfrom starlette.responses import JSONResponse\nfrom starlette.routing import BaseRoute\nfrom typing_extensions import Literal\n\nfrom .._compat import _is_model_field\n\nvalidation_error_definition = {\n \"title\": \"ValidationError\",\n \"type\": \"object\",\n \"properties\": {\n \"loc\": {\n \"title\": \"Location\",\n \"type\": \"array\",\n \"items\": {\"anyOf\": [{\"type\": \"string\"}, {\"type\": \"integer\"}]},\n },\n \"msg\": {\"title\": \"Message\", \"type\": \"string\"},\n \"type\": {\"title\": \"Error Type\", \"type\": \"string\"},\n },\n \"required\": [\"loc\", \"msg\", \"type\"],\n}\n\nvalidation_error_response_definition = {\n \"title\": \"HTTPValidationError\",\n \"type\": \"object\",\n \"properties\": {\n \"detail\": {\n \"title\": \"Detail\",\n \"type\": \"array\",\n \" |
| 18 | run_command | {
"command": "ls fastapi/_compat.py\n"
} | {"status": "error", "error_type": "CommandError", "error_message": "ls: fastapi/_compat.py: No such file or directory\n", "details": {"stdout": "", "stderr": "lfull{"status": "error", "error_type": "CommandError", "error_message": "ls: fastapi/_compat.py: No such file or directory\n", "details": {"stdout": "", "stderr": "ls: fastapi/_compat.py: No such file or directory\n", "exit_code": 1}} |
| 19 | run_command | {
"command": "find . -name \"_compat.py\"\n"
} | {"status": "ok", "stdout": "", "stderr": "", "exit_code": 0}full{"status": "ok", "stdout": "", "stderr": "", "exit_code": 0} |
| 20 | run_command | {
"command": "ls fastapi/\n"
} | {"status": "ok", "stdout": "__init__.py\n__main__.py\n_compat\napplications.py\nbackground.py\ncli.py\nconcurrency.py\ndatastructures.py\ndependencies\nencodersfull{"status": "ok", "stdout": "__init__.py\n__main__.py\n_compat\napplications.py\nbackground.py\ncli.py\nconcurrency.py\ndatastructures.py\ndependencies\nencoders.py\nexception_handlers.py\nexceptions.py\nlogger.py\nmiddleware\nopenapi\nparam_functions.py\nparams.py\npy.typed\nrequests.py\nresponses.py\nrouting.py\nsecurity\nstaticfiles.py\ntemp_pydantic_v1_params.py\ntemplating.py\ntestclient.py\ntypes.py\nutils.py\nwebsockets.py\n", "stderr": "", "exit_code": 0} |
| 21 | run_command | {
"command": "ls fastapi/_compat/\n"
} | {"status": "ok", "stdout": "__init__.py\nmain.py\nmay_v1.py\nmodel_field.py\nshared.py\nv1.py\nv2.py\n", "stderr": "", "exit_code": 0}full{"status": "ok", "stdout": "__init__.py\nmain.py\nmay_v1.py\nmodel_field.py\nshared.py\nv1.py\nv2.py\n", "stderr": "", "exit_code": 0} |
| 22 | run_command | {
"command": "grep -rn \"get_schema_from_model_field\" fastapi/_compat/\n"
} | {"status": "ok", "stdout": "fastapi/_compat/v1.py:236:def get_schema_from_model_field(\nfastapi/_compat/__init__.py:23:from .main import get_schema_from_model_ffull{"status": "ok", "stdout": "fastapi/_compat/v1.py:236:def get_schema_from_model_field(\nfastapi/_compat/__init__.py:23:from .main import get_schema_from_model_field as get_schema_from_model_field\nfastapi/_compat/main.py:314:def get_schema_from_model_field(\nfastapi/_compat/main.py:327: return v1.get_schema_from_model_field(\nfastapi/_compat/main.py:337: return v2.get_schema_from_model_field(\nfastapi/_compat/v2.py:174:def get_schema_from_model_field(\n", "stderr": "", "exit_code": 0} |
| 23 | run_command | {
"command": "sed -n '160,220p' fastapi/_compat/v2.py\n"
} | {"status": "ok", "stdout": "def _model_rebuild(model: Type[BaseModel]) -> None:\n model.model_rebuild()\n\n\ndef _model_dump(\n model: BaseModel, mode: Literal[full{"status": "ok", "stdout": "def _model_rebuild(model: Type[BaseModel]) -> None:\n model.model_rebuild()\n\n\ndef _model_dump(\n model: BaseModel, mode: Literal[\"json\", \"python\"] = \"json\", **kwargs: Any\n) -> Any:\n return model.model_dump(mode=mode, **kwargs)\n\n\ndef _get_model_config(model: BaseModel) -> Any:\n return model.model_config\n\n\ndef get_schema_from_model_field(\n *,\n field: ModelField,\n model_name_map: ModelNameMap,\n field_mapping: Dict[\n Tuple[ModelField, Literal[\"validation\", \"serialization\"]], JsonSchemaValue\n ],\n separate_input_output_schemas: bool = True,\n) -> Dict[str, Any]:\n override_mode: Union[Literal[\"validation\"], None] = (\n None if separate_input_output_schemas else \"validation\"\n )\n # This expects that GenerateJsonSchema was already used to generate the definitions\n json_schema = field_mapping[(field, override_mode or field.mode)]\n if \"$ref\" not in json_schema:\n # TODO remove when deprecating Pydantic v1\n # Ref: https://github.com/pydantic/pydantic/blob/d61792cc42c80b13b23e3ffa74bc37ec7c77f7d1/pydantic/schema.py#L207\n json_schema[\"title\"] = field.field_info.title or field.alias.title().replace(\n \"_\", \" \"\n )\n return json_schema\n\n\ndef get_definitions(\n *,\n fields: Sequence[ModelField],\n model_name_map: ModelNameMap,\n separate_input_output_schemas: bool = True,\n) -> Tuple[\n Dict[Tuple[ModelField, Literal[\"validation\", \"serialization\"]], JsonSchemaValue],\n Dict[str, Dict[str, Any]],\n]:\n schema_generator = GenerateJsonSchema(ref_template=REF_TEMPLATE)\n override_mode: Union[Literal[\"validation\"], None] = (\n None if separate_input_output_schemas else \"validation\"\n )\n flat_models = get_flat_models_from_fields(fields, known_models=set())\n flat_model_fields = [\n ModelField(field_info=FieldInfo(annotation=model), name=model.__name__)\n |
| 24 | run_command | {
"command": "sed -n '220,300p' fastapi/_compat/v2.py\n"
} | {"status": "ok", "stdout": " inputs = [\n (field, override_mode or field.mode, field._type_adapter.core_schema)\n for field in list(fields) + list(unique_flat_mfull{"status": "ok", "stdout": " inputs = [\n (field, override_mode or field.mode, field._type_adapter.core_schema)\n for field in list(fields) + list(unique_flat_model_fields)\n ]\n field_mapping, definitions = schema_generator.generate_definitions(inputs=inputs)\n for item_def in cast(Dict[str, Dict[str, Any]], definitions).values():\n if \"description\" in item_def:\n item_description = cast(str, item_def[\"description\"]).split(\"\\f\")[0]\n item_def[\"description\"] = item_description\n new_mapping, new_definitions = _remap_definitions_and_field_mappings(\n model_name_map=model_name_map,\n definitions=definitions, # type: ignore[arg-type]\n field_mapping=field_mapping,\n )\n return new_mapping, new_definitions\n\n\ndef _replace_refs(\n *,\n schema: Dict[str, Any],\n old_name_to_new_name_map: Dict[str, str],\n) -> Dict[str, Any]:\n new_schema = deepcopy(schema)\n for key, value in new_schema.items():\n if key == \"$ref\":\n ref_name = schema[\"$ref\"].split(\"/\")[-1]\n if ref_name in old_name_to_new_name_map:\n new_name = old_name_to_new_name_map[ref_name]\n new_schema[\"$ref\"] = REF_TEMPLATE.format(model=new_name)\n else:\n new_schema[\"$ref\"] = schema[\"$ref\"]\n continue\n if isinstance(value, dict):\n new_schema[key] = _replace_refs(\n schema=value,\n old_name_to_new_name_map=old_name_to_new_name_map,\n )\n elif isinstance(value, list):\n new_value = []\n for item in value:\n if isinstance(item, dict):\n new_item = _replace_refs(\n schema=item,\n old_name_to_new_name_map=old_name_to_new_name_map,\n )\n new_value.append(new_item)\n\n else:\n |
| 25 | run_command | {
"command": "sed -n '300,350p' fastapi/_compat/v2.py\n"
} | {"status": "ok", "stdout": " schema=schema,\n old_name_to_new_name_map=old_name_to_new_name_map,\n )\n new_field_mapping[field_key] = new_schema\n\n new_definitfull{"status": "ok", "stdout": " schema=schema,\n old_name_to_new_name_map=old_name_to_new_name_map,\n )\n new_field_mapping[field_key] = new_schema\n\n new_definitions = {}\n for key, value in definitions.items():\n if key in old_name_to_new_name_map:\n new_key = old_name_to_new_name_map[key]\n else:\n new_key = key\n new_value = _replace_refs(\n schema=value,\n old_name_to_new_name_map=old_name_to_new_name_map,\n )\n new_definitions[new_key] = new_value\n return new_field_mapping, new_definitions\n\n\ndef is_scalar_field(field: ModelField) -> bool:\n from fastapi import params\n\n return shared.field_annotation_is_scalar(\n field.field_info.annotation\n ) and not isinstance(field.field_info, params.Body)\n\n\ndef is_sequence_field(field: ModelField) -> bool:\n return shared.field_annotation_is_sequence(field.field_info.annotation)\n\n\ndef is_scalar_sequence_field(field: ModelField) -> bool:\n return shared.field_annotation_is_scalar_sequence(field.field_info.annotation)\n\n\ndef is_bytes_field(field: ModelField) -> bool:\n return shared.is_bytes_or_nonable_bytes_annotation(field.type_)\n\n\ndef is_bytes_sequence_field(field: ModelField) -> bool:\n return shared.is_bytes_sequence_annotation(field.type_)\n\n\ndef copy_field_info(*, field_info: FieldInfo, annotation: Any) -> FieldInfo:\n cls = type(field_info)\n merged_field_info = cls.from_annotation(annotation)\n new_field_info = copy(field_info)\n new_field_info.metadata = merged_field_info.metadata\n new_field_info.annotation = merged_field_info.annotation\n return new_field_info\n\n", "stderr": "", "exit_code": 0} |
| 26 | run_command | {
"command": "sed -n '236,280p' fastapi/_compat/v1.py\n"
} | {"status": "ok", "stdout": "def get_schema_from_model_field(\n *,\n field: ModelField,\n model_name_map: ModelNameMap,\n field_mapping: Dict[\n Tuple[ModelFieldfull{"status": "ok", "stdout": "def get_schema_from_model_field(\n *,\n field: ModelField,\n model_name_map: ModelNameMap,\n field_mapping: Dict[\n Tuple[ModelField, Literal[\"validation\", \"serialization\"]], JsonSchemaValue\n ],\n separate_input_output_schemas: bool = True,\n) -> Dict[str, Any]:\n return field_schema( # type: ignore[no-any-return]\n field, model_name_map=model_name_map, ref_prefix=REF_PREFIX\n )[0]\n\n\n# def get_compat_model_name_map(fields: List[ModelField]) -> ModelNameMap:\n# models = get_flat_models_from_fields(fields, known_models=set())\n# return get_model_name_map(models) # type: ignore[no-any-return]\n\n\ndef get_definitions(\n *,\n fields: List[ModelField],\n model_name_map: ModelNameMap,\n separate_input_output_schemas: bool = True,\n) -> Tuple[\n Dict[Tuple[ModelField, Literal[\"validation\", \"serialization\"]], JsonSchemaValue],\n Dict[str, Dict[str, Any]],\n]:\n models = get_flat_models_from_fields(fields, known_models=set())\n return {}, get_model_definitions(flat_models=models, model_name_map=model_name_map)\n\n\ndef is_scalar_field(field: ModelField) -> bool:\n return is_pv1_scalar_field(field)\n\n\ndef is_sequence_field(field: ModelField) -> bool:\n return field.shape in sequence_shapes or shared._annotation_is_sequence(field.type_)\n\n\ndef is_scalar_sequence_field(field: ModelField) -> bool:\n return is_pv1_scalar_sequence_field(field)\n\n\ndef is_bytes_field(field: ModelField) -> bool:\n", "stderr": "", "exit_code": 0} |
| 27 | run_command | {
"command": "cat > /tmp/reproduce_issue.py <<'PY'\nfrom fastapi import FastAPI\nfrom pydantic import BaseModel\nfrom typing import List\n\napp = FastAPI()\n\nclass Item(BaseModel):\n name: str\n\nclass OrderIn(BaseModel):\n items: List[Item]\n\nclass OrderOut(BaseModel):\n items: List[Item]\n\n@app.post(\"/orders/\", response_model=OrderOut)\nasync def create_order(order: OrderIn):\n return order\n\ndef test_openapi_schemas():\n openapi_schema = app.openapi()\n schemas = openapi_schema[\"components\"][\"schemas\"]\n \n print(f\"Schemas: {list(schemas.keys())}\")\n \n assert \"OrderIn\" in schemas\n assert \"OrderOut\" in schemas\n \n order_in_ref = schemas[\"OrderIn\"][\"properties\"][\"items\"][\"items\"][\"$ref\"]\n order_out_ref = schemas[\"OrderOut\"][\"properties\"][\"items\"][\"items\"][\"$ref\"]\n \n print(f\"OrderIn items ref: {order_in_ref}\")\n print(f\"OrderOut items ref: {order_out_ref}\")\n \n # The desired behavior is that OrderIn and OrderOut refer to different Item schemas\n # if separate_input_output_schemas=True.\n # This means we expect ItemIn and ItemOut.\n assert order_in_ref != order_out_ref, \"Nested models should be separated when parent models are separated\"\n\nif __name__ == \"__main__\":\n try:\n test_openapi_schemas()\n print(\"Test passed!\")\n except AssertionError as e:\n import json\n # print(json.dumps(app.openapi()[\"components\"][\"schemas\"], indent=2))\n print(f\"Assertion failed: {e}\")\n except Exception as e:\n print(f\"Test failed: {e}\")\nPY\npython3 /tmp/reproduce_issue.py\n"
} | {"status": "ok", "stdout": "Schemas: ['HTTPValidationError', 'Item', 'OrderIn', 'OrderOut', 'ValidationError']\nOrderIn items ref: #/components/schemas/Item\nOrfull{"status": "ok", "stdout": "Schemas: ['HTTPValidationError', 'Item', 'OrderIn', 'OrderOut', 'ValidationError']\nOrderIn items ref: #/components/schemas/Item\nOrderOut items ref: #/components/schemas/Item\nAssertion failed: Nested models should be separated when parent models are separated\n", "stderr": "", "exit_code": 0} |
| 28 | run_command | {
"command": "grep -rn \"get_flat_models_from_fields\" fastapi/_compat/\n"
} | {"status": "ok", "stdout": "fastapi/_compat/v1.py:64: get_flat_models_from_fields as get_flat_models_from_fields,\nfastapi/_compat/v1.py:113: get_flat_models_frfull{"status": "ok", "stdout": "fastapi/_compat/v1.py:64: get_flat_models_from_fields as get_flat_models_from_fields,\nfastapi/_compat/v1.py:113: get_flat_models_from_fields as get_flat_models_from_fields,\nfastapi/_compat/v1.py:251:# models = get_flat_models_from_fields(fields, known_models=set())\nfastapi/_compat/v1.py:264: models = get_flat_models_from_fields(fields, known_models=set())\nfastapi/_compat/main.py:242: v1_flat_models = v1.get_flat_models_from_fields(\nfastapi/_compat/main.py:254: v2_flat_models = v2.get_flat_models_from_fields(\nfastapi/_compat/v2.py:210: flat_models = get_flat_models_from_fields(fields, known_models=set())\nfastapi/_compat/v2.py:415: get_flat_models_from_fields(fields, known_models=known_models)\nfastapi/_compat/v2.py:450:def get_flat_models_from_fields(\n", "stderr": "", "exit_code": 0} |
| 29 | run_command | {
"command": "sed -n '450,550p' fastapi/_compat/v2.py\n"
} | {"status": "ok", "stdout": "def get_flat_models_from_fields(\n fields: Sequence[ModelField], known_models: TypeModelSet\n) -> TypeModelSet:\n for field in fieldfull{"status": "ok", "stdout": "def get_flat_models_from_fields(\n fields: Sequence[ModelField], known_models: TypeModelSet\n) -> TypeModelSet:\n for field in fields:\n get_flat_models_from_field(field, known_models=known_models)\n return known_models\n\n\ndef get_long_model_name(model: TypeModelOrEnum) -> str:\n return f\"{model.__module__}__{model.__qualname__}\".replace(\".\", \"__\")\n", "stderr": "", "exit_code": 0} |
| 30 | run_command | {
"command": "grep -rn \"get_flat_models_from_field\" fastapi/_compat/\n"
} | {"status": "ok", "stdout": "fastapi/_compat/v1.py:62: from pydantic.schema import get_flat_models_from_field as get_flat_models_from_field\nfastapi/_compat/v1.pfull{"status": "ok", "stdout": "fastapi/_compat/v1.py:62: from pydantic.schema import get_flat_models_from_field as get_flat_models_from_field\nfastapi/_compat/v1.py:64: get_flat_models_from_fields as get_flat_models_from_fields,\nfastapi/_compat/v1.py:110: get_flat_models_from_field as get_flat_models_from_field,\nfastapi/_compat/v1.py:113: get_flat_models_from_fields as get_flat_models_from_fields,\nfastapi/_compat/v1.py:251:# models = get_flat_models_from_fields(fields, known_models=set())\nfastapi/_compat/v1.py:264: models = get_flat_models_from_fields(fields, known_models=set())\nfastapi/_compat/main.py:242: v1_flat_models = v1.get_flat_models_from_fields(\nfastapi/_compat/main.py:254: v2_flat_models = v2.get_flat_models_from_fields(\nfastapi/_compat/v2.py:210: flat_models = get_flat_models_from_fields(fields, known_models=set())\nfastapi/_compat/v2.py:415: get_flat_models_from_fields(fields, known_models=known_models)\nfastapi/_compat/v2.py:434:def get_flat_models_from_field(\nfastapi/_compat/v2.py:450:def get_flat_models_from_fields(\nfastapi/_compat/v2.py:454: get_flat_models_from_field(field, known_models=known_models)\n", "stderr": "", "exit_code": 0} |
| 31 | run_command | {
"command": "sed -n '434,450p' fastapi/_compat/v2.py\n"
} | {"status": "ok", "stdout": "def get_flat_models_from_field(\n field: ModelField, known_models: TypeModelSet\n) -> TypeModelSet:\n field_type = field.type_\n if full{"status": "ok", "stdout": "def get_flat_models_from_field(\n field: ModelField, known_models: TypeModelSet\n) -> TypeModelSet:\n field_type = field.type_\n if lenient_issubclass(field_type, BaseModel):\n if field_type in known_models:\n return known_models\n known_models.add(field_type)\n get_flat_models_from_model(field_type, known_models=known_models)\n elif lenient_issubclass(field_type, Enum):\n known_models.add(field_type)\n else:\n get_flat_models_from_annotation(field_type, known_models=known_models)\n return known_models\n\n\ndef get_flat_models_from_fields(\n", "stderr": "", "exit_code": 0} |
| 32 | run_command | {
"command": "grep -rn \"get_flat_models_from_model\" fastapi/_compat/\n"
} | {"status": "ok", "stdout": "fastapi/_compat/v2.py:410:def get_flat_models_from_model(\nfastapi/_compat/v2.py:428: get_flat_models_from_model(arg, known_models=kfull{"status": "ok", "stdout": "fastapi/_compat/v2.py:410:def get_flat_models_from_model(\nfastapi/_compat/v2.py:428: get_flat_models_from_model(arg, known_models=known_models)\nfastapi/_compat/v2.py:442: get_flat_models_from_model(field_type, known_models=known_models)\n", "stderr": "", "exit_code": 0} |
| 33 | run_command | {
"command": "sed -n '400,445p' fastapi/_compat/v2.py\n"
} | {"status": "ok", "stdout": " elif model_name in name_model_map:\n conflicting_names.add(model_name)\n conflicting_model = name_model_map.pop(model_name)\n name_full{"status": "ok", "stdout": " elif model_name in name_model_map:\n conflicting_names.add(model_name)\n conflicting_model = name_model_map.pop(model_name)\n name_model_map[get_long_model_name(conflicting_model)] = conflicting_model\n name_model_map[get_long_model_name(model)] = model\n else:\n name_model_map[model_name] = model\n return {v: k for k, v in name_model_map.items()}\n\n\ndef get_flat_models_from_model(\n model: Type[\"BaseModel\"], known_models: Union[TypeModelSet, None] = None\n) -> TypeModelSet:\n known_models = known_models or set()\n fields = get_model_fields(model)\n get_flat_models_from_fields(fields, known_models=known_models)\n return known_models\n\n\ndef get_flat_models_from_annotation(\n annotation: Any, known_models: TypeModelSet\n) -> TypeModelSet:\n origin = get_origin(annotation)\n if origin is not None:\n for arg in get_args(annotation):\n if lenient_issubclass(arg, (BaseModel, Enum)) and arg not in known_models:\n known_models.add(arg)\n if lenient_issubclass(arg, BaseModel):\n get_flat_models_from_model(arg, known_models=known_models)\n else:\n get_flat_models_from_annotation(arg, known_models=known_models)\n return known_models\n\n\ndef get_flat_models_from_field(\n field: ModelField, known_models: TypeModelSet\n) -> TypeModelSet:\n field_type = field.type_\n if lenient_issubclass(field_type, BaseModel):\n if field_type in known_models:\n return known_models\n known_models.add(field_type)\n get_flat_models_from_model(field_type, known_models=known_models)\n elif lenient_issubclass(field_type, Enum):\n known_models.add(field_type)\n else:\n", "stderr": "", "exit_code": 0} |
| 34 | run_command | {
"command": "sed -n '200,220p' fastapi/_compat/v2.py\n"
} | {"status": "ok", "stdout": " model_name_map: ModelNameMap,\n separate_input_output_schemas: bool = True,\n) -> Tuple[\n Dict[Tuple[ModelField, Literal[\"validatfull{"status": "ok", "stdout": " model_name_map: ModelNameMap,\n separate_input_output_schemas: bool = True,\n) -> Tuple[\n Dict[Tuple[ModelField, Literal[\"validation\", \"serialization\"]], JsonSchemaValue],\n Dict[str, Dict[str, Any]],\n]:\n schema_generator = GenerateJsonSchema(ref_template=REF_TEMPLATE)\n override_mode: Union[Literal[\"validation\"], None] = (\n None if separate_input_output_schemas else \"validation\"\n )\n flat_models = get_flat_models_from_fields(fields, known_models=set())\n flat_model_fields = [\n ModelField(field_info=FieldInfo(annotation=model), name=model.__name__)\n for model in flat_models\n ]\n input_types = {f.type_ for f in fields}\n unique_flat_model_fields = {\n f for f in flat_model_fields if f.type_ not in input_types\n }\n\n inputs = [\n", "stderr": "", "exit_code": 0} |
| 35 | run_command | {
"command": "cat > /tmp/reproduce_issue.py <<'PY'\nfrom fastapi import FastAPI\nfrom pydantic import BaseModel\nfrom typing import List\n\napp = FastAPI()\n\nclass Item(BaseModel):\n name: str\n\nclass OrderIn(BaseModel):\n items: List[Item]\n\nclass OrderOut(BaseModel):\n items: List[Item]\n\n@app.post(\"/orders/\", response_model=OrderOut)\nasync def create_order(order: OrderIn):\n return order\n\ndef test_openapi_schemas():\n openapi_schema = app.openapi()\n schemas = openapi_schema[\"components\"][\"schemas\"]\n \n print(f\"Schemas: {list(schemas.keys())}\")\n \n assert \"OrderIn\" in schemas\n assert \"OrderOut\" in schemas\n \n order_in_ref = schemas[\"OrderIn\"][\"properties\"][\"items\"][\"items\"][\"$ref\"]\n order_out_ref = schemas[\"OrderOut\"][\"properties\"][\"items\"][\"items\"][\"$ref\"]\n \n print(f\"OrderIn items ref: {order_in_ref}\")\n print(f\"OrderOut items ref: {order_out_ref}\")\n \n # In 0.119.0, it seems nested models are no longer separated.\n # We want them to be separated if the parents are.\n # This means the result should be something like ItemIn and ItemOut.\n assert order_in_ref != order_out_ref, \"Nested models should be separated\"\n\nif __name__ == \"__main__\":\n try:\n test_openapi_schemas()\n print(\"Test passed!\")\n except AssertionError as e:\n print(f\"Assertion failed: {e}\")\nPY\npython3 /tmp/reproduce_issue.py\n"
} | {"status": "ok", "stdout": "Schemas: ['HTTPValidationError', 'Item', 'OrderIn', 'OrderOut', 'ValidationError']\nOrderIn items ref: #/components/schemas/Item\nOrfull{"status": "ok", "stdout": "Schemas: ['HTTPValidationError', 'Item', 'OrderIn', 'OrderOut', 'ValidationError']\nOrderIn items ref: #/components/schemas/Item\nOrderOut items ref: #/components/schemas/Item\nAssertion failed: Nested models should be separated\n", "stderr": "", "exit_code": 0} |
| 36 | run_command | {
"command": "grep -rn \"GenerateJsonSchema\" fastapi/_compat/\n"
} | {"status": "ok", "stdout": "fastapi/_compat/v1.py:149:class GenerateJsonSchema:\nfastapi/_compat/v2.py:31:from pydantic.json_schema import GenerateJsonSchema asfull{"status": "ok", "stdout": "fastapi/_compat/v1.py:149:class GenerateJsonSchema:\nfastapi/_compat/v2.py:31:from pydantic.json_schema import GenerateJsonSchema as GenerateJsonSchema\nfastapi/_compat/v2.py:186: # This expects that GenerateJsonSchema was already used to generate the definitions\nfastapi/_compat/v2.py:206: schema_generator = GenerateJsonSchema(ref_template=REF_TEMPLATE)\n", "stderr": "", "exit_code": 0} |
| 37 | run_command | {
"command": "sed -n '200,220p' fastapi/_compat/v2.py\n"
} | {"status": "ok", "stdout": " model_name_map: ModelNameMap,\n separate_input_output_schemas: bool = True,\n) -> Tuple[\n Dict[Tuple[ModelField, Literal[\"validatfull{"status": "ok", "stdout": " model_name_map: ModelNameMap,\n separate_input_output_schemas: bool = True,\n) -> Tuple[\n Dict[Tuple[ModelField, Literal[\"validation\", \"serialization\"]], JsonSchemaValue],\n Dict[str, Dict[str, Any]],\n]:\n schema_generator = GenerateJsonSchema(ref_template=REF_TEMPLATE)\n override_mode: Union[Literal[\"validation\"], None] = (\n None if separate_input_output_schemas else \"validation\"\n )\n flat_models = get_flat_models_from_fields(fields, known_models=set())\n flat_model_fields = [\n ModelField(field_info=FieldInfo(annotation=model), name=model.__name__)\n for model in flat_models\n ]\n input_types = {f.type_ for f in fields}\n unique_flat_model_fields = {\n f for f in flat_model_fields if f.type_ not in input_types\n }\n\n inputs = [\n", "stderr": "", "exit_code": 0} |
| 38 | run_command | {
"command": "sed -n '220,240p' fastapi/_compat/v2.py\n"
} | {"status": "ok", "stdout": " inputs = [\n (field, override_mode or field.mode, field._type_adapter.core_schema)\n for field in list(fields) + list(unique_flat_mfull{"status": "ok", "stdout": " inputs = [\n (field, override_mode or field.mode, field._type_adapter.core_schema)\n for field in list(fields) + list(unique_flat_model_fields)\n ]\n field_mapping, definitions = schema_generator.generate_definitions(inputs=inputs)\n for item_def in cast(Dict[str, Dict[str, Any]], definitions).values():\n if \"description\" in item_def:\n item_description = cast(str, item_def[\"description\"]).split(\"\\f\")[0]\n item_def[\"description\"] = item_description\n new_mapping, new_definitions = _remap_definitions_and_field_mappings(\n model_name_map=model_name_map,\n definitions=definitions, # type: ignore[arg-type]\n field_mapping=field_mapping,\n )\n return new_mapping, new_definitions\n\n\ndef _replace_refs(\n *,\n schema: Dict[str, Any],\n old_name_to_new_name_map: Dict[str, str],\n", "stderr": "", "exit_code": 0} |