fastapi_12942

{
 "command": "cat <<EOF > /tmp/repro.py\nfrom typing import Annotated, Any, Literal\nfrom pydantic import BaseModel\nfrom fastapi import FastAPI, Body\nfrom fastapi.params import Tag, Discriminator\nimport pytest\nfrom fastapi.testclient import TestClient\n\nclass Pie(BaseModel):\n    time_to_cook: int\n    num_ingredients: int\n\nclass ApplePie(Pie):\n    fruit: Literal[\"apple\"] = \"apple\"\n\nclass PumpkinPie(Pie):\n    filling: Literal[\"pumpkin\"] = \"pumpkin\"\n\ndef get_discriminator_value(v: Any) -> str:\n    if isinstance(v, dict):\n        return v.get(\"fruit\") or v.get(\"filling\")\n    return getattr(v, \"fruit\", getattr(v, \"filling\", None))\n\nDessert = Annotated[\n    Annotated[ApplePie, Tag(\"apple\")] | Annotated[PumpkinPie, Tag(\"pumpkin\")],\n    Discriminator(get_discriminator_value),\n]\n\napp = FastAPI()\n\n@app.post(\"/dessert\")\nasync def dinner(dessert: Dessert):\n    return dessert.model_dump()\n\nclient = TestClient(app)\n\ndef test_dessert_body():\n    # This should work if FastAPI recognizes Dessert as a body parameter\n    response = client.post(\"/dessert\", json={\"time_to_cook\": 10, \"num_ingredients\": 5, \"fruit\": \"apple\"})\n    assert response.status_code == 200\n    assert response.json() == {\"time_to_cook\": 10, \"num_ingredients\": 5, \"fruit\": \"apple\"}\n\n    response = client.post(\"/dessert\", json={\"time_to_cook\": 20, \"num_ingredients\": 3, \"filling\": \"pumpkin\"})\n    assert response.status_code == 200\n    assert response.json() == {\"time_to_cook\": 20, \"num_ingredients\": 3, \"filling\": \"pumpkin\"}\n\nif __name__ == \"__main__\":\n    try:\n        test_dessert_body()\n        print(\"Test passed!\")\n    except Exception as e:\n        print(f\"Test failed: {e}\")\n        import traceback\n        traceback.print_exc()\nEOF\npython3 /tmp/repro.py\n"
}

{
 "command": "grep -r \"Tag\" fastapi/"
}

{
 "command": "grep -r \"Discriminator\" fastapi/"
}

{
 "command": "grep -r \"Discriminator\" . | grep -v \"openapi\""
}

{
 "command": "grep -r \"Annotated\" fastapi/params.py"
}

{
 "command": "grep -rn \"Annotated\" --include=*.py fastapi/ | grep \"body\" -C 5 | head -20"
}

{
 "command": "grep -rn \"Annotated\" --include=*.py fastapi/ | grep \"get_query_params\" -C 5 | head -20"
}

{
 "command": "grep -rn \"Annotated\" --include=*.py fastapi/ | head -40"
}

{
 "end_line": 460,
 "filepath": "fastapi/dependencies/utils.py",
 "start_line": 360
}

{
 "command": "grep -rn \"get_origin\" fastapi/ | grep \"Annotated\" | head -20"
}

{
 "filepath": "fastapi/dependencies/utils.py",
 "start_line": 350,
 "end_line": 420
}

{
 "command": "cat <<EOF > /tmp/repro_fixed.py\nfrom typing import Annotated, Any, Literal, Union\nfrom pydantic import BaseModel\nfrom fastapi import FastAPI, Body\nfrom fastapi.params import Body as BodyParam\nimport pytest\nfrom fastapi.testclient import TestClient\n\n# Mocking Tag and Discriminator since they might not be in the version I'm testing\n# but the issue is about how Annotated is unwrapped.\nclass Tag:\n    def __init__(self, value): self.value = value\nclass Discriminator:\n    def __init__(self, value): self.value = value\n\nclass Pie(BaseModel):\n    time_to_cook: int\n    num_ingredients: int\n\nclass ApplePie(Pie):\n    fruit: Literal[\"apple\"] = \"apple\"\n\nclass PumpkinPie(Pie):\n    filling: Literal[\"pumpkin\"] = \"pumpkin\"\n\ndef get_discriminator_value(v: Any) -> str:\n    if isinstance(v, dict):\n        return v.get(\"fruit\") or v.get(\"filling\")\n    return getattr(v, \"fruit\", getattr(v, \"filling\", None))\n\n# Nested Annotated\nDessert = Annotated[\n    Annotated[ApplePie, Tag(\"apple\")] | Annotated[PumpkinPie, Tag(\"pumpkin\")],\n    Discriminator(get_discriminator_value),\n]\n\napp = FastAPI()\n\n@app.post(\"/dessert\")\nasync def dinner(dessert: Dessert):\n    return dessert.model_dump()\n\nclient = TestClient(app)\n\ndef test_dessert_body():\n    # If it's recognized as body, this should work.\n    # If it's recognized as query, it will fail with 422 Unprocessable Entity\n    response = client.post(\"/dessert\", json={\"time_to_cook\": 10, \"num_ingredients\": 5, \"fruit\": \"apple\"})\n    print(f\"Status: {response.status_code}, Body: {response.text}\")\n    assert response.status_code == 200\n    assert response.json() == {\"time_to_cook\": 10, \"num_ingredients\": 5, \"fruit\": \"apple\"}\n\nif __name__ == \"__main__\":\n    try:\n        test_dessert_body()\n        print(\"Test passed!\")\n    except Exception as e:\n        print(f\"Test failed: {e}\")\n        import traceback\n        traceback.print_exc()\nEOF\npython3 /tmp/repro_fixed.py\n"
}

{
 "filepath": "fastapi/dependencies/utils.py",
 "new_string": "    # Extract Annotated info\n    while get_origin(use_annotation) is Annotated:\n        annotated_args = get_args(use_annotation)\n        type_annotation = annotated_args[0]\n        fastapi_annotations = [\n            arg\n            for arg in annotated_args[1:]\n            if isinstance(arg, (FieldInfo, params.Depends))\n        ]\n        fastapi_specific_annotations = [\n            arg\n            for arg in fastapi_annotations\n            if isinstance(arg, (params.Param, params.Body, params.Depends))\n        ]\n        if fastapi_specific_annotations:\n            fastapi_annotation: Union[FieldInfo, params.Depends, None] = (\n                fastapi_specific_annotations[-1]\n            )\n        else:\n            fastapi_annotation = None\n        # Set default for Annotated FieldInfo\n        if isinstance(fastapi_annotation, FieldInfo):\n            # Copy `field_info` because we mutate `field_info.default` below.\n            field_info = copy_field_info(\n                field_info=fastapi_annotation, annotation=use_annotation\n            )\n            assert (\n                field_info.default is Undefined or field_info.default is RequiredParam\n            ), (\n                f\"`{field_info.__class__.__name__}` default value cannot be set in\"\n                f\" `Annotated` for {param_name!r}. Set the default value with `=` instead.\"\n            )\n            if value is not inspect.Signature.empty:\n                assert not is_path_param, \"Path parameters cannot have default values\"\n                field_info.default = value\n            else:\n                field_info.default = RequiredParam\n        # Get Annotated Depends\n        elif isinstance(fastapi_annotation, params.Depends):\n            depends = fastapi_annotation\n        use_annotation = type_annotation",
 "old_string": "    # Extract Annotated info\n    if get_origin(use_annotation) is Annotated:\n        annotated_args = get_args(annotation)\n        type_annotation = annotated_args[0]\n        fastapi_annotations = [\n            arg\n            for arg in annotated_args[1:]\n            if isinstance(arg, (FieldInfo, params.Depends))\n        ]\n        fastapi_specific_annotations = [\n            arg\n            for arg in fastapi_annotations\n            if isinstance(arg, (params.Param, params.Body, params.Depends))\n        ]\n        if fastapi_specific_annotations:\n            fastapi_annotation: Union[FieldInfo, params.Depends, None] = (\n                fastapi_specific_annotations[-1]\n            )\n        else:\n            fastapi_annotation = None\n        # Set default for Annotated FieldInfo\n        if isinstance(fastapi_annotation, FieldInfo):\n            # Copy `field_info` because we mutate `field_info.default` below.\n            field_info = copy_field_info(\n                field_info=fastapi_annotation, annotation=use_annotation\n            )\n            assert (\n                field_info.default is Undefined or field_info.default is RequiredParam\n            ), (\n                f\"`{field_info.__class__.__name__}` default value cannot be set in\"\n                f\" `Annotated` for {param_name!r}. Set the default value with `=` instead.\"\n            )\n            if value is not inspect.Signature.empty:\n                assert not is_path_param, \"Path parameters cannot have default values\"\n                field_info.default = value\n            else:\n                field_info.default = RequiredParam\n        # Get Annotated Depends\n        elif isinstance(fastapi_annotation, params.Depends):\n            depends = fastapi_annotation"
}

{
 "command": "python3 /tmp/repro_fixed.py"
}

{
 "command": "cat <<EOF > /tmp/repro_fixed.py\nfrom typing import Annotated, Any, Literal, Union\nfrom pydantic import BaseModel\nfrom fastapi import FastAPI, Body\nfrom fastapi.params import Body as BodyParam\nimport pytest\nfrom fastapi.testclient import TestClient\n\nclass Pie(BaseModel):\n    time_to_cook: int\n    num_ingredients: int\n\nclass ApplePie(Pie):\n    fruit: Literal[\"apple\"] = \"apple\"\n\nclass PumpkinPie(Pie):\n    filling: Literal[\"pumpkin\"] = \"pumpkin\"\n\ndef get_discriminator_value(v: Any) -> str:\n    if isinstance(v, dict):\n        return v.get(\"fruit\") or v.get(\"filling\")\n    return getattr(v, \"fruit\", getattr(v, \"filling\", None))\n\n# Nested Annotated\n# The issue is that Dessert is Annotated[Union[Annotated, Annotated], Discriminator]\n# The inner Annotateds are not FastAPI params, but the Union is a Pydantic model (roughly).\n# FastAPI should recognize this as a Body parameter because it's a complex type.\n\nDessert = Annotated[\n    Union[Annotated[ApplePie, \"apple\"], Annotated[PumpkinPie, \"pumpkin\"]],\n    \"discriminator\"\n]\n\napp = FastAPI()\n\n@app.post(\"/dessert\")\nasync def dinner(dessert: Dessert):\n    return {\"status\": \"ok\"}\n\nclient = TestClient(app)\n\ndef test_dessert_body():\n    response = client.post(\"/dessert\", json={\"time_to_cook\": 10, \"num_ingredients\": 5, \"fruit\": \"apple\"})\n    print(f\"Status: {response.status_code}, Body: {response.text}\")\n    assert response.status_code == 200\n\nif __name__ == \"__main__\":\n    try:\n        test_dessert_body()\n        print(\"Test passed!\")\n    except Exception as e:\n        print(f\"Test failed: {e}\")\n        import traceback\n        traceback.print_exc()\nEOF\npython3 /tmp/repro_fixed.py\n"
}

{
 "end_line": 450,
 "filepath": "fastapi/dependencies/utils.py",
 "start_line": 421
}

{
 "command": "cat <<EOF > /tmp/repro_fixed.py\nfrom typing import Annotated, Any, Literal, Union\nfrom pydantic import BaseModel\nfrom fastapi import FastAPI, Body\nfrom fastapi.testclient import TestClient\n\nclass Pie(BaseModel):\n    time_to_cook: int\n    num_ingredients: int\n\nclass ApplePie(Pie):\n    fruit: Literal[\"apple\"] = \"apple\"\n\nclass PumpkinPie(Pie):\n    filling: Literal[\"pumpkin\"] = \"pumpkin\"\n\ndef get_discriminator_value(v: Any) -> str:\n    if isinstance(v, dict):\n        return v.get(\"fruit\") or v.get(\"filling\")\n    return getattr(v, \"fruit\", getattr(v, \"filling\", None))\n\n# Nested Annotated\nDessert = Annotated[\n    Union[Annotated[ApplePie, \"apple\"], Annotated[PumpkinPie, \"pumpkin\"]],\n    \"discriminator\"\n]\n\napp = FastAPI()\n\n@app.post(\"/dessert\")\nasync def dinner(dessert: Dessert):\n    return {\"status\": \"ok\"}\n\nclient = TestClient(app)\n\ndef test_dessert_body():\n    response = client.post(\"/dessert\", json={\"time_to_cook\": 10, \"num_ingredients\": 5, \"fruit\": \"apple\"})\n    print(f\"Status: {response.status_code}, Body: {response.text}\")\n    assert response.status_code == 200\n\nif __name__ == \"__main__\":\n    try:\n        test_dessert_body()\n        print(\"Test passed!\")\n    except Exception as e:\n        print(f\"Test failed: {e}\")\n        import traceback\n        traceback.print_exc()\nEOF\npython3 /tmp/repro_fixed.py\n"
}

{
 "command": "cat <<EOF > /tmp/repro_fixed.py\nfrom typing import Annotated, Any, Literal, Union\nfrom pydantic import BaseModel\nfrom fastapi import FastAPI, Body\nfrom fastapi.testclient import TestClient\n\nclass Pie(BaseModel):\n    time_to_cook: int\n    num_ingredients: int\n\nclass ApplePie(Pie):\n    fruit: Literal[\"apple\"] = \"apple\"\n\nclass PumpkinPie(Pie):\n    filling: Literal[\"pumpkin\"] = \"pumpkin\"\n\n# Case 1: Simple Pydantic model\napp1 = FastAPI()\n@app1.post(\"/pie\")\nasync def pie(dessert: Pie):\n    return {\"status\": \"ok\"}\n\n# Case 2: Annotated Pydantic model\napp2 = FastAPI()\n@app2.post(\"/pie\")\nasync def pie(dessert: Annotated[Pie, \"meta\"]):\n    return {\"status\": \"ok\"}\n\n# Case 3: Nested Annotated Pydantic model\napp3 = FastAPI()\n@app3.post(\"/pie\")\nasync def pie(dessert: Annotated[Annotated[Pie, \"meta1\"], \"meta2\"]):\n    return {\"status\": \"ok\"}\n\nclient1 = TestClient(app1)\nclient2 = TestClient(app2)\nclient3 = TestClient(app3)\n\ndef test_all():\n    payload = {\"time_to_cook\": 10, \"num_ingredients\": 5}\n    \n    r1 = client1.post(\"/pie\", json=payload)\n    print(f\"Case 1: {r1.status_code}\")\n    assert r1.status_code == 200\n\n    r2 = client2.post(\"/pie\", json=payload)\n    print(f\"Case 2: {r2.status_code}\")\n    assert r2.status_code == 200\n\n    r3 = client3.post(\"/pie\", json=payload)\n    print(f\"Case 3: {r3.status_code}\")\n    assert r3.status_code == 200\n\nif __name__ == \"__main__\":\n    test_all()\n    print(\"All passed!\")\nEOF\npython3 /tmp/repro_fixed.py\n"
}

{
 "command": "cat <<EOF > /tmp/repro_fixed.py\nfrom typing import Annotated, Any, Literal, Union\nfrom pydantic import BaseModel\nfrom fastapi import FastAPI, Body\nfrom fastapi.testclient import TestClient\n\nclass Pie(BaseModel):\n    time_to_cook: int\n    num_ingredients: int\n\nclass ApplePie(Pie):\n    fruit: Literal[\"apple\"] = \"apple\"\n\nclass PumpkinPie(Pie):\n    filling: Literal[\"pumpkin\"] = \"pumpkin\"\n\ndef get_discriminator_value(v: Any) -> str:\n    if isinstance(v, dict):\n        return v.get(\"fruit\") or v.get(\"filling\")\n    return getattr(v, \"fruit\", getattr(v, \"filling\", None))\n\n# The problematic type from the issue:\n# Dessert = Annotated[\n#     Annotated[ApplePie, Tag(\"apple\")] | Annotated[PumpkinPie, Tag(\"pumpkin\")],\n#     Discriminator(get_discriminator_value),\n# ]\n# We use strings as placeholders for Tag and Discriminator since we don't have them.\nDessert = Annotated[\n    Annotated[ApplePie, \"apple\"] | Annotated[PumpkinPie, \"pumpkin\"],\n    \"discriminator\"\n]\n\napp = FastAPI()\n\n@app.post(\"/dessert\")\nasync def dinner(dessert: Dessert):\n    return {\"status\": \"ok\"}\n\nclient = TestClient(app)\n\ndef test_dessert_body():\n    # This should be recognized as a body parameter because it's a complex type (Union of Pydantic models)\n    response = client.post(\"/dessert\", json={\"time_to_cook\": 10, \"num_ingredients\": 5, \"fruit\": \"apple\"})\n    print(f\"Status: {response.status_code}, Body: {response.text}\")\n    assert response.status_code == 200\n\nif __name__ == \"__main__\":\n    try:\n        test_dessert_body()\n        print(\"Test passed!\")\n    except Exception as e:\n        print(f\"Test failed: {e}\")\n        import traceback\n        traceback.print_exc()\nEOF\npython3 /tmp/repro_fixed.py\n"
}

{
 "command": "grep -r \"get_origin\" fastapi/dependencies/utils.py"
}

{
 "command": "cat <<EOF > /tmp/repro_fixed.py\nfrom typing import Annotated, Any, Literal, Union\nfrom pydantic import BaseModel\nfrom fastapi import FastAPI, Body\nfrom fastapi.testclient import TestClient\n\nclass Pie(BaseModel):\n    time_to_cook: int\n    num_ingredients: int\n\nclass ApplePie(Pie):\n    fruit: Literal[\"apple\"] = \"apple\"\n\nclass PumpkinPie(Pie):\n    filling: Literal[\"pumpkin\"] = \"pumpkin\"\n\n# The problematic type from the issue:\n# Dessert = Annotated[\n#     Annotated[ApplePie, \"apple\"] | Annotated[PumpkinPie, \"pumpkin\"],\n#     \"discriminator\"\n# ]\n# Let's see if adding Body() fixes it as the issue says.\nDessert = Annotated[\n    Annotated[ApplePie, \"apple\"] | Annotated[PumpkinPie, \"pumpkin\"],\n    \"discriminator\"\n]\n\napp = FastAPI()\n\n@app.post(\"/dessert\")\nasync def dinner(dessert: Annotated[Dessert, Body()]):\n    return {\"status\": \"ok\"}\n\nclient = TestClient(app)\n\ndef test_dessert_body():\n    response = client.post(\"/dessert\", json={\"time_to_cook\": 10, \"num_ingredients\": 5, \"fruit\": \"apple\"})\n    print(f\"Status: {response.status_code}, Body: {response.text}\")\n    assert response.status_code == 200\n\nif __name__ == \"__main__\":\n    try:\n        test_dessert_body()\n        print(\"Test passed!\")\n    except Exception as e:\n        print(f\"Test failed: {e}\")\n        import traceback\n        traceback.print_exc()\nEOF\npython3 /tmp/repro_fixed.py\n"
}

{
 "command": "grep -r \"get_origin\" fastapi/dependencies/utils.py | grep -v \"from typing_extensions\""
}

[]