← eval3_submission_v2

fastapi_13207

failed NO_PATCH NO_PATCH UNSUBMITTED empty_patch(budget) · 7 tool calls · 302 s · fastapi/fastapi

Task input

🐛 Fix OpenAPI schema support for computed fields when using `separate_input_output_schemas=False`

This demonstrates how the output schema differs when the FastAPI app runs with different values for `separate_input_output_schemas` - namely, the computed fields are omitted.

Initially reported here: https://github.com/fastapi/fastapi/discussions/10342

Tool calls (7)

#ToolArgumentsResult
1run_command
{
 "command": "grep -rn \"separate_input_output_schemas\" fastapi | head -20"
}
{"status": "ok", "stdout": "fastapi/_compat/may_v1.py:65: separate_input_output_schemas: bool = True,\nfastapi/_compat/v1.py:243: separate_input_output_schemas:
full
{"status": "ok", "stdout": "fastapi/_compat/may_v1.py:65:        separate_input_output_schemas: bool = True,\nfastapi/_compat/v1.py:243:    separate_input_output_schemas: bool = True,\nfastapi/_compat/v1.py:259:    separate_input_output_schemas: bool = True,\nfastapi/_compat/main.py:271:    separate_input_output_schemas: bool = True,\nfastapi/_compat/main.py:284:            separate_input_output_schemas=separate_input_output_schemas,\nfastapi/_compat/main.py:295:                separate_input_output_schemas=separate_input_output_schemas,\nfastapi/_compat/main.py:309:            separate_input_output_schemas=separate_input_output_schemas,\nfastapi/_compat/main.py:322:    separate_input_output_schemas: bool = True,\nfastapi/_compat/main.py:331:            separate_input_output_schemas=separate_input_output_schemas,\nfastapi/_compat/main.py:341:            separate_input_output_schemas=separate_input_output_schemas,\nfastapi/_compat/v2.py:181:    separate_input_output_schemas: bool = True,\nfastapi/_compat/v2.py:184:        None if separate_input_output_schemas else \"validation\"\nfastapi/_compat/v2.py:201:    separate_input_output_schemas: bool = True,\nfastapi/_compat/v2.py:208:        None if separate_input_output_schemas else \"validation\"\nfastapi/applications.py:791:        separate_input_output_schemas: Annotated[\nfastapi/applications.py:875:        self.separate_input_output_schemas = separate_input_output_schemas\nfastapi/applications.py:1078:                separate_input_output_schemas=self.separate_input_output_schemas,\nfastapi/openapi/utils.py:102:    separate_input_output_schemas: bool = True,\nfastapi/openapi/utils.py:133:                separate_input_output_schemas=separate_input_output_schemas,\nfastapi/openapi/utils.py:175:    separate_input_output_schemas: bool = True,\n", "exit_code": 0}
2read_file
{
 "filepath": "fastapi/openapi/utils.py",
 "start_line": 100,
 "end_line": 200
}
{"status": "ok", "filepath": "fastapi/openapi/utils.py", "content": " Tuple[ModelField, Literal[\"validation\", \"serialization\"]], JsonSchemaValue\n ],\n sepa
full
{"status": "ok", "filepath": "fastapi/openapi/utils.py", "content": "        Tuple[ModelField, Literal[\"validation\", \"serialization\"]], JsonSchemaValue\n    ],\n    separate_input_output_schemas: bool = True,\n) -> List[Dict[str, Any]]:\n    parameters = []\n    flat_dependant = get_flat_dependant(dependant, skip_repeats=True)\n    path_params = _get_flat_fields_from_params(flat_dependant.path_params)\n    query_params = _get_flat_fields_from_params(flat_dependant.query_params)\n    header_params = _get_flat_fields_from_params(flat_dependant.header_params)\n    cookie_params = _get_flat_fields_from_params(flat_dependant.cookie_params)\n    parameter_groups = [\n        (ParamTypes.path, path_params),\n        (ParamTypes.query, query_params),\n        (ParamTypes.header, header_params),\n        (ParamTypes.cookie, cookie_params),\n    ]\n    default_convert_underscores = True\n    if len(flat_dependant.header_params) == 1:\n        first_field = flat_dependant.header_params[0]\n        if lenient_issubclass(first_field.type_, BaseModel):\n            default_convert_underscores = getattr(\n                first_field.field_info, \"convert_underscores\", True\n            )\n    for param_type, param_group in parameter_groups:\n        for param in param_group:\n            field_info = param.field_info\n            # field_info = cast(Param, field_info)\n            if not getattr(field_info, \"include_in_schema\", True):\n                continue\n            param_schema = get_schema_from_model_field(\n                field=param,\n                model_name_map=model_name_map,\n                field_mapping=field_mapping,\n                separate_input_output_schemas=separate_input_output_schemas,\n            )\n            name = param.alias\n            convert_underscores = getattr(\n                param.field_info,\n                \"convert_underscores\",\n                default_convert_underscores,\n            )\n            if (\n                
3run_command
{
 "command": "grep -rn \"get_schema_from_model_field\" fastapi | head -20"
}
{"status": "ok", "stdout": "fastapi/_compat/__init__.py:23:from .main import get_schema_from_model_field as get_schema_from_model_field\nfastapi/_compat/v1.py:2
full
{"status": "ok", "stdout": "fastapi/_compat/__init__.py:23:from .main import get_schema_from_model_field as get_schema_from_model_field\nfastapi/_compat/v1.py:236:def get_schema_from_model_field(\nfastapi/_compat/main.py:314:def get_schema_from_model_field(\nfastapi/_compat/main.py:327:        return v1.get_schema_from_model_field(\nfastapi/_compat/main.py:337:        return v2.get_schema_from_model_field(\nfastapi/_compat/v2.py:174:def get_schema_from_model_field(\nfastapi/openapi/utils.py:13:    get_schema_from_model_field,\nfastapi/openapi/utils.py:129:            param_schema = get_schema_from_model_field(\nfastapi/openapi/utils.py:180:    body_schema = get_schema_from_model_field(\nfastapi/openapi/utils.py:352:                        response_schema = get_schema_from_model_field(\nfastapi/openapi/utils.py:385:                        additional_field_schema = get_schema_from_model_field(\n", "exit_code": 0}
4read_file
{
 "end_line": 220,
 "filepath": "fastapi/_compat/v2.py",
 "start_line": 160
}
{"status": "ok", "filepath": "fastapi/_compat/v2.py", "content": "def _model_rebuild(model: Type[BaseModel]) -> None:\n model.model_rebuild()\n\n\ndef _model_du
full
{"status": "ok", "filepath": "fastapi/_compat/v2.py", "content": "def _model_rebuild(model: Type[BaseModel]) -> None:\n    model.model_rebuild()\n\n\ndef _model_dump(\n    model: BaseModel, mode: Literal[\"json\", \"python\"] = \"json\", **kwargs: Any\n) -> Any:\n    return model.model_dump(mode=mode, **kwargs)\n\n\ndef _get_model_config(model: BaseModel) -> Any:\n    return model.model_config\n\n\ndef get_schema_from_model_field(\n    *,\n    field: ModelField,\n    model_name_map: ModelNameMap,\n    field_mapping: Dict[\n        Tuple[ModelField, Literal[\"validation\", \"serialization\"]], JsonSchemaValue\n    ],\n    separate_input_output_schemas: bool = True,\n) -> Dict[str, Any]:\n    override_mode: Union[Literal[\"validation\"], None] = (\n        None if separate_input_output_schemas else \"validation\"\n    )\n    # This expects that GenerateJsonSchema was already used to generate the definitions\n    json_schema = field_mapping[(field, override_mode or field.mode)]\n    if \"$ref\" not in json_schema:\n        # TODO remove when deprecating Pydantic v1\n        # Ref: https://github.com/pydantic/pydantic/blob/d61792cc42c80b13b23e3ffa74bc37ec7c77f7d1/pydantic/schema.py#L207\n        json_schema[\"title\"] = field.field_info.title or field.alias.title().replace(\n            \"_\", \" \"\n        )\n    return json_schema\n\n\ndef get_definitions(\n    *,\n    fields: Sequence[ModelField],\n    model_name_map: ModelNameMap,\n    separate_input_output_schemas: bool = True,\n) -> Tuple[\n    Dict[Tuple[ModelField, Literal[\"validation\", \"serialization\"]], JsonSchemaValue],\n    Dict[str, Dict[str, Any]],\n]:\n    schema_generator = GenerateJsonSchema(ref_template=REF_TEMPLATE)\n    override_mode: Union[Literal[\"validation\"], None] = (\n        None if separate_input_output_schemas else \"validation\"\n    )\n    validation_fields = [field for field in fields if field.mode == \"validation\"]\n    serialization_fields = [field for field in fields if field.m
5run_command
{
 "command": "cat > /tmp/repro.py <<'EOF'\nfrom fastapi import FastAPI\nfrom pydantic import BaseModel, computed_field\nfrom fastapi.testclient import TestClient\n\napp = FastAPI(separate_input_output_schemas=False)\n\nclass Item(BaseModel):\n    name: str\n    price: float\n\n    @computed_field\n    @property\n    def total(self) -> float:\n        return self.price * 1.2\n\n@app.get(\"/item\", response_model=Item)\ndef get_item():\n    return Item(name=\"Test\", price=10.0)\n\nclient = TestClient(app)\nresponse = client.get(\"/openapi.json\")\nopenapi_schema = response.json()\n\n# Check if 'total' is in the schema for Item\n# The Item schema should be in components/schemas\nitem_schema = openapi_schema[\"components\"][\"schemas\"][\"Item\"]\nprint(f\"Item schema properties: {item_schema.get('properties', {}).keys()}\")\nassert \"total\" in item_schema.get(\"properties\", {}), \"Computed field 'total' missing from OpenAPI schema when separate_input_output_schemas=False\"\nEOF\npython3 /tmp/repro.py\n"
}
{"status": "error", "error_type": "CommandError", "error_message": "Command failed with exit code 1", "details": {"stdout": "Item schema properties: dict_keys([
full
{"status": "error", "error_type": "CommandError", "error_message": "Command failed with exit code 1", "details": {"stdout": "Item schema properties: dict_keys(['name', 'price'])\n", "stderr": "Traceback (most recent call last):\n  File \"/tmp/swe_work/eval3_submission_v2/fastapi_13207/a/tmp/repro.py\", line 28, in <module>\n    assert \"total\" in item_schema.get(\"properties\", {}), \"Computed field 'total' missing from OpenAPI schema when separate_input_output_schemas=False\"\n           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\nAssertionError: Computed field 'total' missing from OpenAPI schema when separate_input_output_schemas=False\n", "exit_code": 1}}
6read_file
{
 "end_line": 250,
 "filepath": "fastapi/_compat/v2.py",
 "start_line": 200
}
{"status": "ok", "filepath": "fastapi/_compat/v2.py", "content": " model_name_map: ModelNameMap,\n separate_input_output_schemas: bool = True,\n) -> Tuple[\n Di
full
{"status": "ok", "filepath": "fastapi/_compat/v2.py", "content": "    model_name_map: ModelNameMap,\n    separate_input_output_schemas: bool = True,\n) -> Tuple[\n    Dict[Tuple[ModelField, Literal[\"validation\", \"serialization\"]], JsonSchemaValue],\n    Dict[str, Dict[str, Any]],\n]:\n    schema_generator = GenerateJsonSchema(ref_template=REF_TEMPLATE)\n    override_mode: Union[Literal[\"validation\"], None] = (\n        None if separate_input_output_schemas else \"validation\"\n    )\n    validation_fields = [field for field in fields if field.mode == \"validation\"]\n    serialization_fields = [field for field in fields if field.mode == \"serialization\"]\n    flat_validation_models = get_flat_models_from_fields(\n        validation_fields, known_models=set()\n    )\n    flat_serialization_models = get_flat_models_from_fields(\n        serialization_fields, known_models=set()\n    )\n    flat_validation_model_fields = [\n        ModelField(\n            field_info=FieldInfo(annotation=model),\n            name=model.__name__,\n            mode=\"validation\",\n        )\n        for model in flat_validation_models\n    ]\n    flat_serialization_model_fields = [\n        ModelField(\n            field_info=FieldInfo(annotation=model),\n            name=model.__name__,\n            mode=\"serialization\",\n        )\n        for model in flat_serialization_models\n    ]\n    flat_model_fields = flat_validation_model_fields + flat_serialization_model_fields\n    input_types = {f.type_ for f in fields}\n    unique_flat_model_fields = {\n        f for f in flat_model_fields if f.type_ not in input_types\n    }\n\n    inputs = [\n        (field, override_mode or field.mode, field._type_adapter.core_schema)\n        for field in list(fields) + list(unique_flat_model_fields)\n    ]\n    field_mapping, definitions = schema_generator.generate_definitions(inputs=inputs)\n    for item_def in cast(Dict[str, Dict[str, Any]], definitions).values():\n        if \"description\
7read_file
{
 "end_line": 185,
 "filepath": "fastapi/_compat/v2.py",
 "start_line": 170
}
{"status": "ok", "filepath": "fastapi/_compat/v2.py", "content": "def _get_model_config(model: BaseModel) -> Any:\n return model.model_config\n\n\ndef get_schem
full
{"status": "ok", "filepath": "fastapi/_compat/v2.py", "content": "def _get_model_config(model: BaseModel) -> Any:\n    return model.model_config\n\n\ndef get_schema_from_model_field(\n    *,\n    field: ModelField,\n    model_name_map: ModelNameMap,\n    field_mapping: Dict[\n        Tuple[ModelField, Literal[\"validation\", \"serialization\"]], JsonSchemaValue\n    ],\n    separate_input_output_schemas: bool = True,\n) -> Dict[str, Any]:\n    override_mode: Union[Literal[\"validation\"], None] = (\n        None if separate_input_output_schemas else \"validation\"\n    )\n", "start_line": 170, "end_line": 185, "total_lines": 486, "is_truncated": false}