failed WRONG_FIX UNSUBMITTED wrong_fix_unsubmitted(budget) · 23 tool calls · 301 s · fastapi/fastapi
🐛 Use `401` status code in security classes when credentials are missing
## Warning
This description is partially outdated after changes described in [this comment](https://github.com/fastapi/fastapi/pull/13786#pullrequestreview-3501695067).
## Description
This PR is an attempt to finally solve the issue with security tools returning error responses with status code `403` instead of `401` when credentials are not provided.
## Breaking changes and workaround
These changes can break projects that rely on old behavior.
In order to mitigate this, the `not_authenticated_status_code` is introduced. If set to `403`, it will make it work the same way as it was before changes (return `403` status code).
This option should be treated as a temporary workaround to give developers more time to update Clients to follow the new behavior.
## Changes and reasoning
### APIKeyQuery, APIKeyHeader, APIKeyCookie
* **Standard:**
* These schemes are not covered by standards, but developers usually follow the same rules as for other standards
* **Actions:**
* The default status code for not providing API key was changed from 403 to 401.
* Temporary `not_authenticated_status_code` parameter can be used to revert this behavior back to returning 403 error code without sending `WWW-Authenticate`.
* **Notes:**
* It’s considered to be a good practice to include in `WWW-Authenticate` information needed to understand how the key is supposed to be passed. I implemented default format (`WWW-Authenticate: ApiKey in="...", name="..."` ), but it’s possible to override the template for `WWW-Authenticate` by subclassing and defining the `format_www_authenticate_header_value` method
### HTTP Basic
* **Standard:**
* https://datatracker.ietf.org/doc/html/rfc7617
* **Actions:**
* No needed. This scheme already acts according to the standard in terms of returning 401 status code with `WWW-Authenticate` header on a lack of credentials
* **Notes:**
* `realm` is required according to the RFC, but optional in the current implementation. Fixing this would introduce breaking changes. Considering this is not a problem for people who want to follow the standard, I suggest we leave it as it is.
### HTTP Digest
* **Standard:**
* https://datatracker.ietf.org/doc/html/rfc7616
* **Actions:**
* The default status code for not providing the authorization parameter was changed from 403 to 401.
* `WWW-Authenticate` is just a stub for now (just `WWW-Authenticate: Digest`) (see notes)
* Temporary `not_authenticated_status_code` parameter can be used to revert this behavior back to returning 403 error code without sending `WWW-Authenticate`.
* **Notes:**
* Since the current `HTTPDigest` implementation is just a stub, we can’t follow standards (we don’t generate `nonce`'s, don’t have `realm`, …). I suggest we just change the error status code and add a stub for `WWW-Authenticate` (just `WWW-Authenticate: Digest`). For now `HTTPDigest` can’t be used as it is, so, this is not a problem.
* We can later add full implementation of `Digest` scheme. There have been made several attempts to implement it (#9825, #3071)
* Should we add a note that `HTTPDigest` is just a stub?
### HTTP Bearer, OAuth2 schemes, OIDC
* **Standard:**
* https://datatracker.ietf.org/doc/html/rfc6750
* **Actions:**
* For `OAuth2PasswordBearer` and `OAuth2AuthorizationCodeBearer`: not needed.
* They already return a 401 error code. Implementation is probably not 100% correct (see notes), but considering nobody argued, I think we can leave it as it is for now.
* For `HTTPBearer` and `OpenIdConnect`:
* The default status code for not providing the authorization parameter was changed from 403 to 401. The suggested implementation will be in line with the current implementations of `OAuth2PasswordBearer` and `OAuth2AuthorizationCodeBearer`.
* Temporary `not_authenticated_status_code` parameter added to `HTTPBearer` can be used to revert this behavior back to returning 403 error code without sending `WWW-Authenticate`.
* **Notes:**
* It’s [recommended to return 400 error response](https://datatracker.ietf.org/doc/html/rfc6750#section-3.1) if the parameter is missed or of an unsupported type, but this is not a strict requirement (word SHOULD is used). I suggest we ignore this and follow the approach that is consistent with other schemes.
* The format of `WWW-Authenticate` is not clearly described: It’s said that the value "Bearer" MUST be followed by one or more auth-param values. At the same time, all auth-param attributes are optional. In examples they always add `realm`. Since we don’t have `realm`, I suggest we just skip it and send just `WWW-Authenticate: Bearer`
* We can later improve the `WWW-Authenticate` format by adding `realm` and `scope`
## Links
* https://github.com/fastapi/fastapi/issues/10177
* https://github.com/fastapi/fastapi/pull/2120
* https://github.com/fastapi/fastapi/pull/5332
* https://github.com/fastapi/fastapi/pull/12507
* https://github.com/fastapi/fastapi/pull/5310
* https://github.com/fastapi/fastapi/pull/13729
* https://github.com/fastapi/fastapi/pull/13514
* https://github.com/fastapi/fastapi/pull/13326
| # | Tool | Arguments | Result |
|---|---|---|---|
| 1 | run_command | {
"command": "ls -R fastapi/security"
} | {"status": "ok", "stdout": "fastapi/security:\n__init__.py\napi_key.py\nbase.py\nhttp.py\noauth2.py\nopen_id_connect_url.py\nutils.py\n", "exit_code": 0}full{"status": "ok", "stdout": "fastapi/security:\n__init__.py\napi_key.py\nbase.py\nhttp.py\noauth2.py\nopen_id_connect_url.py\nutils.py\n", "exit_code": 0} |
| 2 | run_command | {
"command": "grep -rn \"not_authenticated_status_code\" fastapi/security"
} | {"status": "error", "error_type": "CommandError", "error_message": "Command failed with exit code 1", "details": {"stdout": "", "stderr": "", "exit_code": 1}}full{"status": "error", "error_type": "CommandError", "error_message": "Command failed with exit code 1", "details": {"stdout": "", "stderr": "", "exit_code": 1}} |
| 3 | run_command | {
"command": "grep -rn \"403\" fastapi/security | grep -v \"404\" | head -20"
} | {"status": "ok", "stdout": "fastapi/security/api_key.py:8:from starlette.status import HTTP_403_FORBIDDEN\nfastapi/security/api_key.py:18: status_code=HTTP_403_full{"status": "ok", "stdout": "fastapi/security/api_key.py:8:from starlette.status import HTTP_403_FORBIDDEN\nfastapi/security/api_key.py:18: status_code=HTTP_403_FORBIDDEN, detail=\"Not authenticated\"\nfastapi/security/open_id_connect_url.py:8:from starlette.status import HTTP_403_FORBIDDEN\nfastapi/security/open_id_connect_url.py:81: status_code=HTTP_403_FORBIDDEN, detail=\"Not authenticated\"\nfastapi/security/oauth2.py:11:from starlette.status import HTTP_401_UNAUTHORIZED, HTTP_403_FORBIDDEN\nfastapi/security/oauth2.py:385: status_code=HTTP_403_FORBIDDEN, detail=\"Not authenticated\"\nfastapi/security/http.py:13:from starlette.status import HTTP_401_UNAUTHORIZED, HTTP_403_FORBIDDEN\nfastapi/security/http.py:91: status_code=HTTP_403_FORBIDDEN, detail=\"Not authenticated\"\nfastapi/security/http.py:310: status_code=HTTP_403_FORBIDDEN, detail=\"Not authenticated\"\nfastapi/security/http.py:317: status_code=HTTP_403_FORBIDDEN,\nfastapi/security/http.py:412: status_code=HTTP_403_FORBIDDEN, detail=\"Not authenticated\"\nfastapi/security/http.py:419: status_code=HTTP_403_FORBIDDEN,\n", "exit_code": 0} |
| 4 | read_file | {
"filepath": "fastapi/security/api_key.py"
} | {"status": "ok", "filepath": "fastapi/security/api_key.py", "content": "from typing import Optional\n\nfrom annotated_doc import Doc\nfrom fastapi.openapi.modelfull{"status": "ok", "filepath": "fastapi/security/api_key.py", "content": "from typing import Optional\n\nfrom annotated_doc import Doc\nfrom fastapi.openapi.models import APIKey, APIKeyIn\nfrom fastapi.security.base import SecurityBase\nfrom starlette.exceptions import HTTPException\nfrom starlette.requests import Request\nfrom starlette.status import HTTP_403_FORBIDDEN\nfrom typing_extensions import Annotated\n\n\nclass APIKeyBase(SecurityBase):\n @staticmethod\n def check_api_key(api_key: Optional[str], auto_error: bool) -> Optional[str]:\n if not api_key:\n if auto_error:\n raise HTTPException(\n status_code=HTTP_403_FORBIDDEN, detail=\"Not authenticated\"\n )\n return None\n return api_key\n\n\nclass APIKeyQuery(APIKeyBase):\n \"\"\"\n API key authentication using a query parameter.\n\n This defines the name of the query parameter that should be provided in the request\n with the API key and integrates that into the OpenAPI documentation. It extracts\n the key value sent in the query parameter automatically and provides it as the\n dependency result. But it doesn't define how to send that API key to the client.\n\n ## Usage\n\n Create an instance object and use that object as the dependency in `Depends()`.\n\n The dependency result will be a string containing the key value.\n\n ## Example\n\n ```python\n from fastapi import Depends, FastAPI\n from fastapi.security import APIKeyQuery\n\n app = FastAPI()\n\n query_scheme = APIKeyQuery(name=\"api_key\")\n\n\n @app.get(\"/items/\")\n async def read_items(api_key: str = Depends(query_scheme)):\n return {\"api_key\": api_key}\n ```\n \"\"\"\n\n def __init__(\n self,\n *,\n name: Annotated[\n str,\n Doc(\"Query parameter name.\"),\n ],\n scheme_name: Annotated[\n Optional[str],\n Doc(\n |
| 5 | read_file | {
"filepath": "fastapi/security/http.py"
} | {"status": "ok", "filepath": "fastapi/security/http.py", "content": "import binascii\nfrom base64 import b64decode\nfrom typing import Optional\n\nfrom annotatefull{"status": "ok", "filepath": "fastapi/security/http.py", "content": "import binascii\nfrom base64 import b64decode\nfrom typing import Optional\n\nfrom annotated_doc import Doc\nfrom fastapi.exceptions import HTTPException\nfrom fastapi.openapi.models import HTTPBase as HTTPBaseModel\nfrom fastapi.openapi.models import HTTPBearer as HTTPBearerModel\nfrom fastapi.security.base import SecurityBase\nfrom fastapi.security.utils import get_authorization_scheme_param\nfrom pydantic import BaseModel\nfrom starlette.requests import Request\nfrom starlette.status import HTTP_401_UNAUTHORIZED, HTTP_403_FORBIDDEN\nfrom typing_extensions import Annotated\n\n\nclass HTTPBasicCredentials(BaseModel):\n \"\"\"\n The HTTP Basic credentials given as the result of using `HTTPBasic` in a\n dependency.\n\n Read more about it in the\n [FastAPI docs for HTTP Basic Auth](https://fastapi.tiangolo.com/advanced/security/http-basic-auth/).\n \"\"\"\n\n username: Annotated[str, Doc(\"The HTTP Basic username.\")]\n password: Annotated[str, Doc(\"The HTTP Basic password.\")]\n\n\nclass HTTPAuthorizationCredentials(BaseModel):\n \"\"\"\n The HTTP authorization credentials in the result of using `HTTPBearer` or\n `HTTPDigest` in a dependency.\n\n The HTTP authorization header value is split by the first space.\n\n The first part is the `scheme`, the second part is the `credentials`.\n\n For example, in an HTTP Bearer token scheme, the client will send a header\n like:\n\n ```\n Authorization: Bearer deadbeef12346\n ```\n\n In this case:\n\n * `scheme` will have the value `\"Bearer\"`\n * `credentials` will have the value `\"deadbeef12346\"`\n \"\"\"\n\n scheme: Annotated[\n str,\n Doc(\n \"\"\"\n The HTTP authorization scheme extracted from the header value.\n \"\"\"\n ),\n ]\n credentials: Annotated[\n str,\n Doc(\n \"\"\"\n The HTTP a |
| 6 | read_file | {
"filepath": "fastapi/security/http.py",
"start_line": 60,
"end_line": 100
} | {"status": "ok", "filepath": "fastapi/security/http.py", "content": " credentials: Annotated[\n str,\n Doc(\n \"\"\"\n The HTTP authorization credentials extracfull{"status": "ok", "filepath": "fastapi/security/http.py", "content": " credentials: Annotated[\n str,\n Doc(\n \"\"\"\n The HTTP authorization credentials extracted from the header value.\n \"\"\"\n ),\n ]\n\n\nclass HTTPBase(SecurityBase):\n def __init__(\n self,\n *,\n scheme: str,\n scheme_name: Optional[str] = None,\n description: Optional[str] = None,\n auto_error: bool = True,\n ):\n self.model = HTTPBaseModel(scheme=scheme, description=description)\n self.scheme_name = scheme_name or self.__class__.__name__\n self.auto_error = auto_error\n\n async def __call__(\n self, request: Request\n ) -> Optional[HTTPAuthorizationCredentials]:\n authorization = request.headers.get(\"Authorization\")\n scheme, credentials = get_authorization_scheme_param(authorization)\n if not (authorization and scheme and credentials):\n if self.auto_error:\n raise HTTPException(\n status_code=HTTP_403_FORBIDDEN, detail=\"Not authenticated\"\n )\n else:\n return None\n return HTTPAuthorizationCredentials(scheme=scheme, credentials=credentials)\n\n\nclass HTTPBasic(HTTPBase):\n \"\"\"\n HTTP Basic authentication.\n", "start_line": 60, "end_line": 100, "total_lines": 424, "is_truncated": false} |
| 7 | read_file | {
"end_line": 300,
"filepath": "fastapi/security/http.py",
"start_line": 200
} | {"status": "ok", "filepath": "fastapi/security/http.py", "content": " status_code=HTTP_401_UNAUTHORIZED,\n detail=\"Not authenticated\",\n headers=unauthorized_full{"status": "ok", "filepath": "fastapi/security/http.py", "content": " status_code=HTTP_401_UNAUTHORIZED,\n detail=\"Not authenticated\",\n headers=unauthorized_headers,\n )\n else:\n return None\n invalid_user_credentials_exc = HTTPException(\n status_code=HTTP_401_UNAUTHORIZED,\n detail=\"Invalid authentication credentials\",\n headers=unauthorized_headers,\n )\n try:\n data = b64decode(param).decode(\"ascii\")\n except (ValueError, UnicodeDecodeError, binascii.Error):\n raise invalid_user_credentials_exc # noqa: B904\n username, separator, password = data.partition(\":\")\n if not separator:\n raise invalid_user_credentials_exc\n return HTTPBasicCredentials(username=username, password=password)\n\n\nclass HTTPBearer(HTTPBase):\n \"\"\"\n HTTP Bearer token authentication.\n\n ## Usage\n\n Create an instance object and use that object as the dependency in `Depends()`.\n\n The dependency result will be an `HTTPAuthorizationCredentials` object containing\n the `scheme` and the `credentials`.\n\n ## Example\n\n ```python\n from typing import Annotated\n\n from fastapi import Depends, FastAPI\n from fastapi.security import HTTPAuthorizationCredentials, HTTPBearer\n\n app = FastAPI()\n\n security = HTTPBearer()\n\n\n @app.get(\"/users/me\")\n def read_current_user(\n credentials: Annotated[HTTPAuthorizationCredentials, Depends(security)]\n ):\n return {\"scheme\": credentials.scheme, \"credentials\": credentials.credentials}\n ```\n \"\"\"\n\n def __init__(\n self,\n *,\n bearerFormat: Annotated[Optional[str], Doc(\"Bearer token format.\")] = None,\n scheme_name: Annotated[\n Optional[str],\n Doc(\n \"\"\"\n Secu |
| 8 | read_file | {
"end_line": 424,
"filepath": "fastapi/security/http.py",
"start_line": 301
} | {"status": "ok", "filepath": "fastapi/security/http.py", "content": "\n async def __call__(\n self, request: Request\n ) -> Optional[HTTPAuthorizationCredentialfull{"status": "ok", "filepath": "fastapi/security/http.py", "content": "\n async def __call__(\n self, request: Request\n ) -> Optional[HTTPAuthorizationCredentials]:\n authorization = request.headers.get(\"Authorization\")\n scheme, credentials = get_authorization_scheme_param(authorization)\n if not (authorization and scheme and credentials):\n if self.auto_error:\n raise HTTPException(\n status_code=HTTP_403_FORBIDDEN, detail=\"Not authenticated\"\n )\n else:\n return None\n if scheme.lower() != \"bearer\":\n if self.auto_error:\n raise HTTPException(\n status_code=HTTP_403_FORBIDDEN,\n detail=\"Invalid authentication credentials\",\n )\n else:\n return None\n return HTTPAuthorizationCredentials(scheme=scheme, credentials=credentials)\n\n\nclass HTTPDigest(HTTPBase):\n \"\"\"\n HTTP Digest authentication.\n\n ## Usage\n\n Create an instance object and use that object as the dependency in `Depends()`.\n\n The dependency result will be an `HTTPAuthorizationCredentials` object containing\n the `scheme` and the `credentials`.\n\n ## Example\n\n ```python\n from typing import Annotated\n\n from fastapi import Depends, FastAPI\n from fastapi.security import HTTPAuthorizationCredentials, HTTPDigest\n\n app = FastAPI()\n\n security = HTTPDigest()\n\n\n @app.get(\"/users/me\")\n def read_current_user(\n credentials: Annotated[HTTPAuthorizationCredentials, Depends(security)]\n ):\n return {\"scheme\": credentials.scheme, \"credentials\": credentials.credentials}\n ```\n \"\"\"\n\n def __init__(\n self,\n *,\n scheme_name: Annotated[\n Optional[str],\n Doc(\n \"\"\"\n Security scheme name.\n\n |
| 9 | read_file | {
"filepath": "fastapi/security/open_id_connect_url.py"
} | {"status": "ok", "filepath": "fastapi/security/open_id_connect_url.py", "content": "from typing import Optional\n\nfrom annotated_doc import Doc\nfrom fastapi.ofull{"status": "ok", "filepath": "fastapi/security/open_id_connect_url.py", "content": "from typing import Optional\n\nfrom annotated_doc import Doc\nfrom fastapi.openapi.models import OpenIdConnect as OpenIdConnectModel\nfrom fastapi.security.base import SecurityBase\nfrom starlette.exceptions import HTTPException\nfrom starlette.requests import Request\nfrom starlette.status import HTTP_403_FORBIDDEN\nfrom typing_extensions import Annotated\n\n\nclass OpenIdConnect(SecurityBase):\n \"\"\"\n OpenID Connect authentication class. An instance of it would be used as a\n dependency.\n \"\"\"\n\n def __init__(\n self,\n *,\n openIdConnectUrl: Annotated[\n str,\n Doc(\n \"\"\"\n The OpenID Connect URL.\n \"\"\"\n ),\n ],\n scheme_name: Annotated[\n Optional[str],\n Doc(\n \"\"\"\n Security scheme name.\n\n It will be included in the generated OpenAPI (e.g. visible at `/docs`).\n \"\"\"\n ),\n ] = None,\n description: Annotated[\n Optional[str],\n Doc(\n \"\"\"\n Security scheme description.\n\n It will be included in the generated OpenAPI (e.g. visible at `/docs`).\n \"\"\"\n ),\n ] = None,\n auto_error: Annotated[\n bool,\n Doc(\n \"\"\"\n By default, if no HTTP Authorization header is provided, required for\n OpenID Connect authentication, it will automatically cancel the request\n and send the client an error.\n\n If `auto_error` is set to `False`, when the HTTP Authorization header\n is not available, instead of erroring out, the dependency result will\n be `None`.\n\n This is useful when you want to have |
| 10 | read_file | {
"filepath": "fastapi/security/oauth2.py"
} | {"status": "ok", "filepath": "fastapi/security/oauth2.py", "content": "from typing import Any, Dict, List, Optional, Union, cast\n\nfrom annotated_doc import Dofull{"status": "ok", "filepath": "fastapi/security/oauth2.py", "content": "from typing import Any, Dict, List, Optional, Union, cast\n\nfrom annotated_doc import Doc\nfrom fastapi.exceptions import HTTPException\nfrom fastapi.openapi.models import OAuth2 as OAuth2Model\nfrom fastapi.openapi.models import OAuthFlows as OAuthFlowsModel\nfrom fastapi.param_functions import Form\nfrom fastapi.security.base import SecurityBase\nfrom fastapi.security.utils import get_authorization_scheme_param\nfrom starlette.requests import Request\nfrom starlette.status import HTTP_401_UNAUTHORIZED, HTTP_403_FORBIDDEN\n\n# TODO: import from typing when deprecating Python 3.9\nfrom typing_extensions import Annotated\n\n\nclass OAuth2PasswordRequestForm:\n \"\"\"\n This is a dependency class to collect the `username` and `password` as form data\n for an OAuth2 password flow.\n\n The OAuth2 specification dictates that for a password flow the data should be\n collected using form data (instead of JSON) and that it should have the specific\n fields `username` and `password`.\n\n All the initialization parameters are extracted from the request.\n\n Read more about it in the\n [FastAPI docs for Simple OAuth2 with Password and Bearer](https://fastapi.tiangolo.com/tutorial/security/simple-oauth2/).\n\n ## Example\n\n ```python\n from typing import Annotated\n\n from fastapi import Depends, FastAPI\n from fastapi.security import OAuth2PasswordRequestForm\n\n app = FastAPI()\n\n\n @app.post(\"/login\")\n def login(form_data: Annotated[OAuth2PasswordRequestForm, Depends()]):\n data = {}\n data[\"scopes\"] = []\n for scope in form_data.scopes:\n data[\"scopes\"].append(scope)\n if form_data.client_id:\n data[\"client_id\"] = form_data.client_id\n if form_data.client_secret:\n data[\"client_secret\"] = form_data.client_secret\n return data\n ```\n\n Note that for OAuth2 the |
| 11 | read_file | {
"end_line": 400,
"filepath": "fastapi/security/oauth2.py",
"start_line": 350
} | {"status": "ok", "filepath": "fastapi/security/oauth2.py", "content": " \"\"\"\n ),\n ] = None,\n auto_error: Annotated[\n bool,\n Doc(\n \"\"\"\n By default, ifull{"status": "ok", "filepath": "fastapi/security/oauth2.py", "content": " \"\"\"\n ),\n ] = None,\n auto_error: Annotated[\n bool,\n Doc(\n \"\"\"\n By default, if no HTTP Authorization header is provided, required for\n OAuth2 authentication, it will automatically cancel the request and\n send the client an error.\n\n If `auto_error` is set to `False`, when the HTTP Authorization header\n is not available, instead of erroring out, the dependency result will\n be `None`.\n\n This is useful when you want to have optional authentication.\n\n It is also useful when you want to have authentication that can be\n provided in one of multiple optional ways (for example, with OAuth2\n or in a cookie).\n \"\"\"\n ),\n ] = True,\n ):\n self.model = OAuth2Model(\n flows=cast(OAuthFlowsModel, flows), description=description\n )\n self.scheme_name = scheme_name or self.__class__.__name__\n self.auto_error = auto_error\n\n async def __call__(self, request: Request) -> Optional[str]:\n authorization = request.headers.get(\"Authorization\")\n if not authorization:\n if self.auto_error:\n raise HTTPException(\n status_code=HTTP_403_FORBIDDEN, detail=\"Not authenticated\"\n )\n else:\n return None\n return authorization\n\n\nclass OAuth2PasswordBearer(OAuth2):\n \"\"\"\n OAuth2 flow for authentication using a bearer token obtained with a password.\n An instance of it would be used as a dependency.\n\n Read more about it in the\n [FastAPI docs for Simple OAuth2 with Password and Bearer](https://fastapi.tiangolo.com/tutorial/security/simple-oauth2/).\n \"\"\"\n\n", " |
| 12 | read_file | {
"filepath": "fastapi/security/base.py"
} | {"status": "ok", "filepath": "fastapi/security/base.py", "content": "from fastapi.openapi.models import SecurityBase as SecurityBaseModel\n\n\nclass SecurityBasfull{"status": "ok", "filepath": "fastapi/security/base.py", "content": "from fastapi.openapi.models import SecurityBase as SecurityBaseModel\n\n\nclass SecurityBase:\n model: SecurityBaseModel\n scheme_name: str\n", "start_line": 1, "end_line": 6, "total_lines": 6, "is_truncated": false} |
| 13 | read_file | {
"end_line": 300,
"filepath": "fastapi/security/api_key.py",
"start_line": 1
} | {"status": "ok", "filepath": "fastapi/security/api_key.py", "content": "from typing import Optional\n\nfrom annotated_doc import Doc\nfrom fastapi.openapi.modelfull{"status": "ok", "filepath": "fastapi/security/api_key.py", "content": "from typing import Optional\n\nfrom annotated_doc import Doc\nfrom fastapi.openapi.models import APIKey, APIKeyIn\nfrom fastapi.security.base import SecurityBase\nfrom starlette.exceptions import HTTPException\nfrom starlette.requests import Request\nfrom starlette.status import HTTP_403_FORBIDDEN\nfrom typing_extensions import Annotated\n\n\nclass APIKeyBase(SecurityBase):\n @staticmethod\n def check_api_key(api_key: Optional[str], auto_error: bool) -> Optional[str]:\n if not api_key:\n if auto_error:\n raise HTTPException(\n status_code=HTTP_403_FORBIDDEN, detail=\"Not authenticated\"\n )\n return None\n return api_key\n\n\nclass APIKeyQuery(APIKeyBase):\n \"\"\"\n API key authentication using a query parameter.\n\n This defines the name of the query parameter that should be provided in the request\n with the API key and integrates that into the OpenAPI documentation. It extracts\n the key value sent in the query parameter automatically and provides it as the\n dependency result. But it doesn't define how to send that API key to the client.\n\n ## Usage\n\n Create an instance object and use that object as the dependency in `Depends()`.\n\n The dependency result will be a string containing the key value.\n\n ## Example\n\n ```python\n from fastapi import Depends, FastAPI\n from fastapi.security import APIKeyQuery\n\n app = FastAPI()\n\n query_scheme = APIKeyQuery(name=\"api_key\")\n\n\n @app.get(\"/items/\")\n async def read_items(api_key: str = Depends(query_scheme)):\n return {\"api_key\": api_key}\n ```\n \"\"\"\n\n def __init__(\n self,\n *,\n name: Annotated[\n str,\n Doc(\"Query parameter name.\"),\n ],\n scheme_name: Annotated[\n Optional[str],\n Doc(\n |
| 14 | read_file | {
"filepath": "fastapi/security/api_key.py",
"start_line": 151
} | {"status": "ok", "filepath": "fastapi/security/api_key.py", "content": " name: Annotated[str, Doc(\"Header name.\")],\n scheme_name: Annotated[\n Optional[str],full{"status": "ok", "filepath": "fastapi/security/api_key.py", "content": " name: Annotated[str, Doc(\"Header name.\")],\n scheme_name: Annotated[\n Optional[str],\n Doc(\n \"\"\"\n Security scheme name.\n\n It will be included in the generated OpenAPI (e.g. visible at `/docs`).\n \"\"\"\n ),\n ] = None,\n description: Annotated[\n Optional[str],\n Doc(\n \"\"\"\n Security scheme description.\n\n It will be included in the generated OpenAPI (e.g. visible at `/docs`).\n \"\"\"\n ),\n ] = None,\n auto_error: Annotated[\n bool,\n Doc(\n \"\"\"\n By default, if the header is not provided, `APIKeyHeader` will\n automatically cancel the request and send the client an error.\n\n If `auto_error` is set to `False`, when the header is not available,\n instead of erroring out, the dependency result will be `None`.\n\n This is useful when you want to have optional authentication.\n\n It is also useful when you want to have authentication that can be\n provided in one of multiple optional ways (for example, in a header or\n in an HTTP Bearer token).\n \"\"\"\n ),\n ] = True,\n ):\n self.model: APIKey = APIKey(\n **{\"in\": APIKeyIn.header},\n name=name,\n description=description,\n )\n self.scheme_name = scheme_name or self.__class__.__name__\n self.auto_error = auto_error\n\n async def __call__(self, request: Request) -> Optional[str]:\n api_key = request.headers.get(self.model.name)\n return self.check_api_key(api_key, self.auto_error)\n\n\nclass APIKeyCookie(APIKeyBase):\n \"\"\"\n A |
| 15 | run_command | {
"command": "grep -rn \"HTTP_401_UNAUTHORIZED\" fastapi/security | head -20"
} | {"status": "ok", "stdout": "fastapi/security/oauth2.py:11:from starlette.status import HTTP_401_UNAUTHORIZED, HTTP_403_FORBIDDEN\nfastapi/security/oauth2.py:495full{"status": "ok", "stdout": "fastapi/security/oauth2.py:11:from starlette.status import HTTP_401_UNAUTHORIZED, HTTP_403_FORBIDDEN\nfastapi/security/oauth2.py:495: status_code=HTTP_401_UNAUTHORIZED,\nfastapi/security/oauth2.py:605: status_code=HTTP_401_UNAUTHORIZED,\nfastapi/security/http.py:13:from starlette.status import HTTP_401_UNAUTHORIZED, HTTP_403_FORBIDDEN\nfastapi/security/http.py:200: status_code=HTTP_401_UNAUTHORIZED,\nfastapi/security/http.py:207: status_code=HTTP_401_UNAUTHORIZED,\n", "exit_code": 0} |
| 16 | edit_file | {
"filepath": "fastapi/security/api_key.py",
"new_string": "from starlette.status import HTTP_401_UNAUTHORIZED, HTTP_403_FORBIDDEN",
"old_string": "from starlette.status import HTTP_403_FORBIDDEN"
} | {"status": "ok", "filepath": "fastapi/security/api_key.py", "occurrences": 1, "strategy": "exact", "diff": "--- a/fastapi/security/api_key.py\n+++ b/fastapi/secfull{"status": "ok", "filepath": "fastapi/security/api_key.py", "occurrences": 1, "strategy": "exact", "diff": "--- a/fastapi/security/api_key.py\n+++ b/fastapi/security/api_key.py\n@@ -5,7 +5,7 @@\n from fastapi.security.base import SecurityBase\n from starlette.exceptions import HTTPException\n from starlette.requests import Request\n-from starlette.status import HTTP_403_FORBIDDEN\n+from starlette.status import HTTP_401_UNAUTHORIZED, HTTP_403_FORBIDDEN\n from typing_extensions import Annotated\n \n \n", "is_truncated": false} |
| 17 | edit_file | {
"filepath": "fastapi/security/api_key.py",
"new_string": "class APIKeyBase(SecurityBase):\n @staticmethod\n def check_api_key(\n api_key: Optional[str], \n auto_error: bool, \n not_authenticated_status_code: int = HTTP_401_UNAUTHORIZED\n ) -> Optional[str]:\n if not api_key:\n if auto_error:\n raise HTTPException(\n status_code=not_authenticated_status_code, detail=\"Not authenticated\"\n )\n return None\n return api_key",
"old_string": "class APIKeyBase(SecurityBase):\n @staticmethod\n def check_api_key(api_key: Optional[str], auto_error: bool) -> Optional[str]:\n if not api_key:\n if auto_error:\n raise HTTPException(\n status_code=HTTP_403_FORBIDDEN, detail=\"Not authenticated\"\n )\n return None\n return api_key"
} | {"status": "ok", "filepath": "fastapi/security/api_key.py", "occurrences": 1, "strategy": "exact", "diff": "--- a/fastapi/security/api_key.py\n+++ b/fastapi/secfull{"status": "ok", "filepath": "fastapi/security/api_key.py", "occurrences": 1, "strategy": "exact", "diff": "--- a/fastapi/security/api_key.py\n+++ b/fastapi/security/api_key.py\n@@ -11,11 +11,15 @@\n \n class APIKeyBase(SecurityBase):\n @staticmethod\n- def check_api_key(api_key: Optional[str], auto_error: bool) -> Optional[str]:\n+ def check_api_key(\n+ api_key: Optional[str], \n+ auto_error: bool, \n+ not_authenticated_status_code: int = HTTP_401_UNAUTHORIZED\n+ ) -> Optional[str]:\n if not api_key:\n if auto_error:\n raise HTTPException(\n- status_code=HTTP_403_FORBIDDEN, detail=\"Not authenticated\"\n+ status_code=not_authenticated_status_code, detail=\"Not authenticated\"\n )\n return None\n return api_key\n", "is_truncated": false} |
| 18 | edit_file | {
"filepath": "fastapi/security/api_key.py",
"new_string": " def __init__(\n self,\n *,\n name: Annotated[\n str,\n Doc(\"Query parameter name.\"),\n ],\n scheme_name: Annotated[\n Optional[str],\n Doc(\n \"\"\"\n Security scheme name.\n\n It will be included in the generated OpenAPI (e.g. visible at `/docs`).\n \"\"\"\n ),\n ] = None,\n description: Annotated[\n Optional[str],\n Doc(\n \"\"\"\n Security scheme description.\n\n It will be included in the generated OpenAPI (e.g. visible at `/docs`).\n \"\"\"\n ),\n ] = None,\n auto_error: Annotated[\n bool,\n Doc(\n \"\"\"\n By default, if the query parameter is not provided, `APIKeyQuery` will\n automatically cancel the request and send the client an error.\n\n If `auto_error` is set to `False`, when the query parameter is not\n available, instead of erroring out, the dependency result will be\n `None`.\n\n This is useful when you want to have optional authentication.\n\n It is also useful when you want to have authentication that can be\n provided in one of multiple optional ways (for example, in a query\n parameter or in an HTTP Bearer token).\n \"\"\"\n ),\n ] = True,\n not_authenticated_status_code: Annotated[\n int,\n Doc(\"Status code to use when not authenticated.\"),\n ] = HTTP_401_UNAUTHORIZED,\n ):\n self.model: APIKey = APIKey(\n **{\"in\": APIKeyIn.query},\n name=name,\n description=description,\n )\n self.scheme_name = scheme_name or self.__class__.__name__\n self.auto_error = auto_error\n self.not_authenticated_status_code = not_authenticated_status_code\n\n async def __call__(self, request: Request) -> Optional[str]:\n api_key = request.query_params.get(self.model.name)\n return self.check_api_key(\n api_key, self.auto_error, self.not_authenticated_status_code\n )",
"old_string": " def __init__(\n self,\n *,\n name: Annotated[\n str,\n Doc(\"Query parameter name.\"),\n ],\n scheme_name: Annotated[\n Optional[str],\n Doc(\n \"\"\"\n Security scheme name.\n\n It will be included in the generated OpenAPI (e.g. visible at `/docs`).\n \"\"\"\n ),\n ] = None,\n description: Annotated[\n Optional[str],\n Doc(\n \"\"\"\n Security scheme description.\n\n It will be included in the generated OpenAPI (e.g. visible at `/docs`).\n \"\"\"\n ),\n ] = None,\n auto_error: Annotated[\n bool,\n Doc(\n \"\"\"\n By default, if the query parameter is not provided, `APIKeyQuery` will\n automatically cancel the request and send the client an error.\n\n If `auto_error` is set to `False`, when the query parameter is not\n available, instead of erroring out, the dependency result will be\n `None`.\n\n This is useful when you want to have optional authentication.\n\n It is also useful when you want to have authentication that can be\n provided in one of multiple optional ways (for example, in a query\n parameter or in an HTTP Bearer token).\n \"\"\"\n ),\n ] = True,\n ):\n self.model: APIKey = APIK | {"status": "ok", "filepath": "fastapi/security/api_key.py", "occurrences": 1, "strategy": "exact", "diff": "--- a/fastapi/security/api_key.py\n+++ b/fastapi/secfull{"status": "ok", "filepath": "fastapi/security/api_key.py", "occurrences": 1, "strategy": "exact", "diff": "--- a/fastapi/security/api_key.py\n+++ b/fastapi/security/api_key.py\n@@ -103,6 +103,10 @@\n \"\"\"\n ),\n ] = True,\n+ not_authenticated_status_code: Annotated[\n+ int,\n+ Doc(\"Status code to use when not authenticated.\"),\n+ ] = HTTP_401_UNAUTHORIZED,\n ):\n self.model: APIKey = APIKey(\n **{\"in\": APIKeyIn.query},\n@@ -111,10 +115,13 @@\n )\n self.scheme_name = scheme_name or self.__class__.__name__\n self.auto_error = auto_error\n+ self.not_authenticated_status_code = not_authenticated_status_code\n \n async def __call__(self, request: Request) -> Optional[str]:\n api_key = request.query_params.get(self.model.name)\n- return self.check_api_key(api_key, self.auto_error)\n+ return self.check_api_key(\n+ api_key, self.auto_error, self.not_authenticated_status_code\n+ )\n \n \n class APIKeyHeader(APIKeyBase):\n", "is_truncated": false} |
| 19 | edit_file | {
"filepath": "fastapi/security/api_key.py",
"new_string": " def __init__(\n self,\n *,\n name: Annotated[str, Doc(\"Header name.\")],\n scheme_name: Annotated[\n Optional[str],\n Doc(\n \"\"\"\n Security scheme name.\n\n It will be included in the generated OpenAPI (e.g. visible at `/docs`).\n \"\"\"\n ),\n ] = None,\n description: Annotated[\n Optional[str],\n Doc(\n \"\"\"\n Security scheme description.\n\n It will be included in the generated OpenAPI (e.g. visible at `/docs`).\n \"\"\"\n ),\n ] = None,\n auto_error: Annotated[\n bool,\n Doc(\n \"\"\"\n By default, if the header is not provided, `APIKeyHeader` will\n automatically cancel the request and send the client an error.\n\n If `auto_error` is set to `False`, when the header is not\n available, instead of erroring out, the dependency result will be\n `None`.\n\n This is useful when you want to have optional authentication.\n\n It is also useful when you want to have authentication that can be\n provided in one of multiple optional ways (for example, in a header\n or in an HTTP Bearer token).\n \"\"\"\n ),\n ] = True,\n not_authenticated_status_code: Annotated[\n int,\n Doc(\"Status code to use when not authenticated.\"),\n ] = HTTP_401_UNAUTHORIZED,\n ):\n self.model: APIKey = APIKey(\n **{\"in\": APIKeyIn.header},\n name=name,\n description=description,\n )\n self.scheme_name = scheme_name or self.__class__.__name__\n self.auto_error = auto_error\n self.not_authenticated_status_code = not_authenticated_status_code\n\n async def __call__(self, request: Request) -> Optional[str]:\n api_key = request.headers.get(self.model.name)\n return self.check_api_key(\n api_key, self.auto_error, self.not_authenticated_status_code\n )",
"old_string": " def __init__(\n self,\n *,\n name: Annotated[str, Doc(\"Header name.\")],\n scheme_name: Annotated[\n Optional[str],\n Doc(\n \"\"\"\n Security scheme name.\n\n It will be included in the generated OpenAPI (e.g. visible at `/docs`).\n \"\"\"\n ),\n ] = None,\n description: Annotated[\n Optional[str],\n Doc(\n \"\"\"\n Security scheme description.\n\n It will be included in the generated OpenAPI (e.g. visible at `/docs`).\n \"\"\"\n ),\n ] = None,\n auto_error: Annotated[\n bool,\n Doc(\n \"\"\"\n By default, if the header is not provided, `APIKeyHeader` will\n automatically cancel the request and send the client an error.\n\n If `auto_error` is set to `False`, when the header is not\n available, instead of erroring out, the dependency result will be\n `None`.\n\n This is useful when you want to have optional authentication.\n\n It is also useful when you want to have authentication that can be\n provided in one of multiple optional ways (for example, in a header\n or in an HTTP Bearer token).\n \"\"\"\n ),\n ] = True,\n ):\n self.model: APIKey = APIKey(\n **{\"in\": APIKeyIn.header},\n name=name,\n description=description,\n )\n self.scheme_name = sch | {"status": "ok", "filepath": "fastapi/security/api_key.py", "occurrences": 1, "strategy": "regex", "diff": "--- a/fastapi/security/api_key.py\n+++ b/fastapi/secfull{"status": "ok", "filepath": "fastapi/security/api_key.py", "occurrences": 1, "strategy": "regex", "diff": "--- a/fastapi/security/api_key.py\n+++ b/fastapi/security/api_key.py\n@@ -156,7 +156,7 @@\n ```\n \"\"\"\n \n- def __init__(\n+ def __init__(\n self,\n *,\n name: Annotated[str, Doc(\"Header name.\")],\n@@ -187,17 +187,22 @@\n By default, if the header is not provided, `APIKeyHeader` will\n automatically cancel the request and send the client an error.\n \n- If `auto_error` is set to `False`, when the header is not available,\n- instead of erroring out, the dependency result will be `None`.\n+ If `auto_error` is set to `False`, when the header is not\n+ available, instead of erroring out, the dependency result will be\n+ `None`.\n \n This is useful when you want to have optional authentication.\n \n It is also useful when you want to have authentication that can be\n- provided in one of multiple optional ways (for example, in a header or\n- in an HTTP Bearer token).\n+ provided in one of multiple optional ways (for example, in a header\n+ or in an HTTP Bearer token).\n \"\"\"\n ),\n ] = True,\n+ not_authenticated_status_code: Annotated[\n+ int,\n+ Doc(\"Status code to use when not authenticated.\"),\n+ ] = HTTP_401_UNAUTHORIZED,\n ):\n self.model: APIKey = APIKey(\n **{\"in\": APIKeyIn.header},\n@@ -206,10 +211,13 @@\n )\n self.scheme_name = scheme_name or self.__class__.__name__\n self.auto_error = auto_error\n+ self.not_authenticated_status_code = not_authenticated_status_code\n \n async def __call__(self, request: Request) -> Optional[str]:\n api_key = request.headers.get(self.model.n |
| 20 | edit_file | {
"filepath": "fastapi/security/api_key.py",
"new_string": " def __init__(\n self,\n *,\n name: Annotated[str, Doc(\"Cookie name.\")],\n scheme_name: Annotated[\n Optional[str],\n Doc(\n \"\"\"\n Security scheme name.\n\n It will be included in the generated OpenAPI (e.g. visible at `/docs`).\n \"\"\"\n ),\n ] = None,\n description: Annotated[\n Optional[str],\n Doc(\n \"\"\"\n Security scheme description.\n\n It will be included in the generated OpenAPI (e.g. visible at `/docs`).\n \"\"\"\n ),\n ] = None,\n auto_error: Annotated[\n bool,\n Doc(\n \"\"\"\n By default, if the cookie is not provided, `APIKeyCookie` will\n automatically cancel the request and send the client an error.\n\n If `auto_error` is set to `False`, when the cookie is not available,\n instead of erroring out, the dependency result will be `None`.\n\n This is useful when you want to have optional authentication.\n\n It is also useful when you want to have authentication that can be\n provided in one of multiple optional ways (for example, in a cookie or\n in an HTTP Bearer token).\n \"\"\"\n ),\n ] = True,\n not_authenticated_status_code: Annotated[\n int,\n Doc(\"Status code to use when not authenticated.\"),\n ] = HTTP_401_UNAUTHORIZED,\n ):\n self.model: APIKey = APIKey(\n **{\"in\": APIKeyIn.cookie},\n name=name,\n description=description,\n )\n self.scheme_name = scheme_name or self.__class__.__name__\n self.auto_error = auto_error\n self.not_authenticated_status_code = not_authenticated_status_code\n\n async def __call__(self, request: Request) -> Optional[str]:\n api_key = request.cookies.get(self.model.name)\n return self.check_api_key(\n api_key, self.auto_error, self.not_authenticated_status_code\n )",
"old_string": " def __init__(\n self,\n *,\n name: Annotated[str, Doc(\"Cookie name.\")],\n scheme_name: Annotated[\n Optional[str],\n Doc(\n \"\"\"\n Security scheme name.\n\n It will be included in the generated OpenAPI (e.g. visible at `/docs`).\n \"\"\"\n ),\n ] = None,\n description: Annotated[\n Optional[str],\n Doc(\n \"\"\"\n Security scheme description.\n\n It will be included in the generated OpenAPI (e.g. visible at `/docs`).\n \"\"\"\n ),\n ] = None,\n auto_error: Annotated[\n bool,\n Doc(\n \"\"\"\n By default, if the cookie is not provided, `APIKeyCookie` will\n automatically cancel the request and send the client an error.\n\n If `auto_error` is set to `False`, when the cookie is not available,\n instead of erroring out, the dependency result will be `None`.\n\n This is useful when you want to have optional authentication.\n\n It is also useful when you want to have authentication that can be\n provided in one of multiple optional ways (for example, in a cookie or\n in an HTTP Bearer token).\n \"\"\"\n ),\n ] = True,\n ):\n self.model: APIKey = APIKey(\n **{\"in\": APIKeyIn.cookie},\n name=name,\n description=description,\n )\n self.scheme_name = scheme_name or self.__class__.__name_ | {"status": "ok", "filepath": "fastapi/security/api_key.py", "occurrences": 1, "strategy": "exact", "diff": "--- a/fastapi/security/api_key.py\n+++ b/fastapi/secfull{"status": "ok", "filepath": "fastapi/security/api_key.py", "occurrences": 1, "strategy": "exact", "diff": "--- a/fastapi/security/api_key.py\n+++ b/fastapi/security/api_key.py\n@@ -294,6 +294,10 @@\n \"\"\"\n ),\n ] = True,\n+ not_authenticated_status_code: Annotated[\n+ int,\n+ Doc(\"Status code to use when not authenticated.\"),\n+ ] = HTTP_401_UNAUTHORIZED,\n ):\n self.model: APIKey = APIKey(\n **{\"in\": APIKeyIn.cookie},\n@@ -302,7 +306,10 @@\n )\n self.scheme_name = scheme_name or self.__class__.__name__\n self.auto_error = auto_error\n+ self.not_authenticated_status_code = not_authenticated_status_code\n \n async def __call__(self, request: Request) -> Optional[str]:\n api_key = request.cookies.get(self.model.name)\n- return self.check_api_key(api_key, self.auto_error)\n+ return self.check_api_key(\n+ api_key, self.auto_error, self.not_authenticated_status_code\n+ )\n", "is_truncated": false} |
| 21 | edit_file | {
"filepath": "fastapi/security/http.py",
"new_string": "class HTTPBase(SecurityBase):\n def __init__(\n self,\n *,\n scheme: str,\n scheme_name: Optional[str] = None,\n description: Optional[str] = None,\n auto_error: bool = True,\n not_authenticated_status_code: int = HTTP_401_UNAUTHORIZED,\n ):\n self.model = HTTPBaseModel(scheme=scheme, description=description)\n self.scheme_name = scheme_name or self.__class__.__name__\n self.auto_error = auto_error\n self.not_authenticated_status_code = not_authenticated_status_code\n\n async def __call__(\n self, request: Request\n ) -> Optional[HTTPAuthorizationCredentials]:\n authorization = request.headers.get(\"Authorization\")\n scheme, credentials = get_authorization_scheme_param(authorization)\n if not (authorization and scheme and credentials):\n if self.auto_error:\n raise HTTPException(\n status_code=self.not_authenticated_status_code, detail=\"Not authenticated\"\n )\n else:\n return None\n return HTTPAuthorizationCredentials(scheme=scheme, credentials=credentials)",
"old_string": "class HTTPBase(SecurityBase):\n def __init__(\n self,\n *,\n scheme: str,\n scheme_name: Optional[str] = None,\n description: Optional[str] = None,\n auto_error: bool = True,\n ):\n self.model = HTTPBaseModel(scheme=scheme, description=description)\n self.scheme_name = scheme_name or self.__class__.__name__\n self.auto_error = auto_error\n\n async def __call__(\n self, request: Request\n ) -> Optional[HTTPAuthorizationCredentials]:\n authorization = request.headers.get(\"Authorization\")\n scheme, credentials = get_authorization_scheme_param(authorization)\n if not (authorization and scheme and credentials):\n if self.auto_error:\n raise HTTPException(\n status_code=HTTP_403_FORBIDDEN, detail=\"Not authenticated\"\n )\n else:\n return None\n return HTTPAuthorizationCredentials(scheme=scheme, credentials=credentials)"
} | {"status": "ok", "filepath": "fastapi/security/http.py", "occurrences": 1, "strategy": "exact", "diff": "--- a/fastapi/security/http.py\n+++ b/fastapi/security/full{"status": "ok", "filepath": "fastapi/security/http.py", "occurrences": 1, "strategy": "exact", "diff": "--- a/fastapi/security/http.py\n+++ b/fastapi/security/http.py\n@@ -75,10 +75,12 @@\n scheme_name: Optional[str] = None,\n description: Optional[str] = None,\n auto_error: bool = True,\n+ not_authenticated_status_code: int = HTTP_401_UNAUTHORIZED,\n ):\n self.model = HTTPBaseModel(scheme=scheme, description=description)\n self.scheme_name = scheme_name or self.__class__.__name__\n self.auto_error = auto_error\n+ self.not_authenticated_status_code = not_authenticated_status_code\n \n async def __call__(\n self, request: Request\n@@ -88,7 +90,7 @@\n if not (authorization and scheme and credentials):\n if self.auto_error:\n raise HTTPException(\n- status_code=HTTP_403_FORBIDDEN, detail=\"Not authenticated\"\n+ status_code=self.not_authenticated_status_code, detail=\"Not authenticated\"\n )\n else:\n return None\n", "is_truncated": false} |
| 22 | edit_file | {
"filepath": "fastapi/security/http.py",
"new_string": " if not (authorization and scheme and credentials):\n if self.auto_error:\n raise HTTPException(\n status_code=self.not_authenticated_status_code,\n detail=\"Not authenticated\",\n headers={\"WWW-Authenticate\": f'{self.model.scheme}'},\n )\n else:\n return None",
"old_string": " if not (authorization and scheme and credentials):\n if self.auto_error:\n raise HTTPException(\n status_code=HTTP_403_FORBIDDEN, detail=\"Not authenticated\"\n )\n else:\n return None"
} | {"status": "error", "error_type": "FileEditError", "error_message": "old_string matched 2 occurrences; provide more context or set allow_multiple"}full{"status": "error", "error_type": "FileEditError", "error_message": "old_string matched 2 occurrences; provide more context or set allow_multiple"} |
| 23 | edit_file | {
"filepath": "fastapi/security/http.py",
"new_string": " if not (authorization and scheme and credentials):\n if self.auto_error:\n raise HTTPException(\n status_code=self.not_authenticated_status_code, detail=\"Not authenticated\"\n )\n else:\n return None",
"old_string": " if not (authorization and scheme and credentials):\n if self.auto_error:\n raise HTTPException(\n status_code=HTTP_403_FORBIDDEN, detail=\"Not authenticated\"\n )\n else:\n return None"
} | {"status": "error", "error_type": "FileEditError", "error_message": "old_string matched 2 occurrences; provide more context or set allow_multiple"}full{"status": "error", "error_type": "FileEditError", "error_message": "old_string matched 2 occurrences; provide more context or set allow_multiple"} |
diff --git a/fastapi/security/api_key.py b/fastapi/security/api_key.py
index 496c815a..b9a30cfc 100644
--- a/fastapi/security/api_key.py
+++ b/fastapi/security/api_key.py
@@ -5,17 +5,21 @@ from fastapi.openapi.models import APIKey, APIKeyIn
from fastapi.security.base import SecurityBase
from starlette.exceptions import HTTPException
from starlette.requests import Request
-from starlette.status import HTTP_403_FORBIDDEN
+from starlette.status import HTTP_401_UNAUTHORIZED, HTTP_403_FORBIDDEN
from typing_extensions import Annotated
class APIKeyBase(SecurityBase):
@staticmethod
- def check_api_key(api_key: Optional[str], auto_error: bool) -> Optional[str]:
+ def check_api_key(
+ api_key: Optional[str],
+ auto_error: bool,
+ not_authenticated_status_code: int = HTTP_401_UNAUTHORIZED
+ ) -> Optional[str]:
if not api_key:
if auto_error:
raise HTTPException(
- status_code=HTTP_403_FORBIDDEN, detail="Not authenticated"
+ status_code=not_authenticated_status_code, detail="Not authenticated"
)
return None
return api_key
@@ -99,6 +103,10 @@ class APIKeyQuery(APIKeyBase):
"""
),
] = True,
+ not_authenticated_status_code: Annotated[
+ int,
+ Doc("Status code to use when not authenticated."),
+ ] = HTTP_401_UNAUTHORIZED,
):
self.model: APIKey = APIKey(
**{"in": APIKeyIn.query},
@@ -107,10 +115,13 @@ class APIKeyQuery(APIKeyBase):
)
self.scheme_name = scheme_name or self.__class__.__name__
self.auto_error = auto_error
+ self.not_authenticated_status_code = not_authenticated_status_code
async def __call__(self, request: Request) -> Optional[str]:
api_key = request.query_params.get(self.model.name)
- return self.check_api_key(api_key, self.auto_error)
+ return self.check_api_key(
+ api_key, self.auto_error, self.not_authenticated_status_code
+ )
class APIKeyHeader(APIKeyBase):
@@ -145,7 +156,7 @@ class APIKeyHeader(APIKeyBase):
```
"""
- def __init__(
+ def __init__(
self,
*,
name: Annotated[str, Doc("Header name.")],
@@ -176,17 +187,22 @@ class APIKeyHeader(APIKeyBase):
By default, if the header is not provided, `APIKeyHeader` will
automatically cancel the request and send the client an error.
- If `auto_error` is set to `False`, when the header is not available,
- instead of erroring out, the dependency result will be `None`.
+ If `auto_error` is set to `False`, when the header is not
+ available, instead of erroring out, the dependency result will be
+ `None`.
This is useful when you want to have optional authentication.
It is also useful when you want to have authentication that can be
- provided in one of multiple optional ways (for example, in a header or
- in an HTTP Bearer token).
+ provided in one of multiple optional ways (for example, in a header
+ or in an HTTP Bearer token).
"""
),
] = True,
+ not_authenticated_status_code: Annotated[
+ int,
+ Doc("Status code to use when not authenticated."),
+ ] = HTTP_401_UNAUTHORIZED,
):
self.model: APIKey = APIKey(
**{"in": APIKeyIn.header},
@@ -195,10 +211,13 @@ class APIKeyHeader(APIKeyBase):
)
self.scheme_name = scheme_name or self.__class__.__name__
self.auto_error = auto_error
+ self.not_authenticated_status_code = not_authenticated_status_code
async def __call__(self, request: Request) -> Optional[str]:
api_key = request.headers.get(self.model.name)
- return self.check_api_key(api_key, self.auto_error)
+ return self.check_api_key(
+ api_key, self.auto_error, self.not_authenticated_status_code
+ )
class APIKeyCookie(APIKeyBase):
@@ -275,6 +294,10 @@ class APIKeyCookie(APIKeyBase):
"""
),
] = True,
+ not_authenticated_status_code: Annotated[
+ int,
+ Doc("Status code to use when not authenticated."),
+ ] = HTTP_401_UNAUTHORIZED,
):
self.model: APIKey = APIKey(
**{"in": APIKeyIn.cookie},
@@ -283,7 +306,10 @@ class APIKeyCookie(APIKeyBase):
)
self.scheme_name = scheme_name or self.__class__.__name__
self.auto_error = auto_error
+ self.not_authenticated_status_code = not_authenticated_status_code
async def __call__(self, request: Request) -> Optional[str]:
api_key = request.cookies.get(self.model.name)
- return self.check_api_key(api_key, self.auto_error)
+ return self.check_api_key(
+ api_key, self.auto_error, self.not_authenticated_status_code
+ )
diff --git a/fastapi/security/http.py b/fastapi/security/http.py
index 3a598565..c02b36ee 100644
--- a/fastapi/security/http.py
+++ b/fastapi/security/http.py
@@ -75,10 +75,12 @@ class HTTPBase(SecurityBase):
scheme_name: Optional[str] = None,
description: Optional[str] = None,
auto_error: bool = True,
+ not_authenticated_status_code: int = HTTP_401_UNAUTHORIZED,
):
self.model = HTTPBaseModel(scheme=scheme, description=description)
self.scheme_name = scheme_name or self.__class__.__name__
self.auto_error = auto_error
+ self.not_authenticated_status_code = not_authenticated_status_code
async def __call__(
self, request: Request
@@ -88,7 +90,7 @@ class HTTPBase(SecurityBase):
if not (authorization and scheme and credentials):
if self.auto_error:
raise HTTPException(
- status_code=HTTP_403_FORBIDDEN, detail="Not authenticated"
+ status_code=self.not_authenticated_status_code, detail="Not authenticated"
)
else:
return None
==================================== ERRORS ====================================
____________ ERROR collecting tests/test_security_api_key_cookie.py ____________
/kaggle/tmp/envs/fastapi/lib/python3.13/site-packages/_pytest/python.py:508: in importtestmodule
mod = import_path(
/kaggle/tmp/envs/fastapi/lib/python3.13/site-packages/_pytest/pathlib.py:596: in import_path
importlib.import_module(module_name)
/root/.local/share/uv/python/cpython-3.13.14-linux-x86_64-gnu/lib/python3.13/importlib/__init__.py:88: in import_module
return _bootstrap._gcd_import(name[level:], package, level)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
<frozen importlib._bootstrap>:1395: in _gcd_import
???
<frozen importlib._bootstrap>:1360: in _find_and_load
???
<frozen importlib._bootstrap>:1331: in _find_and_load_unlocked
???
<frozen importlib._bootstrap>:935: in _load_unlocked
???
/kaggle/tmp/envs/fastapi/lib/python3.13/site-packages/_pytest/assertion/rewrite.py:188: in exec_module
exec(co, module.__dict__)
tests/test_security_api_key_cookie.py:1: in <module>
from fastapi import Depends, FastAPI, Security
fastapi/__init__.py:7: in <module>
from .applications import FastAPI as FastAPI
fastapi/applications.py:17: in <module>
from fastapi import routing
fastapi/routing.py:38: in <module>
from fastapi.dependencies.models import Dependant
fastapi/dependencies/models.py:8: in <module>
from fastapi.security.base import SecurityBase
fastapi/security/__init__.py:1: in <module>
from .api_key import APIKeyCookie as APIKeyCookie
E File "/tmp/swe_work/eval3_submission_v2t/fastapi_13786/b/workspace/fastapi/security/api_key.py", line 159
E def __init__(
E IndentationError: unexpected indent
!!!!!!!!!!!!!!!!!!!!!!!!!! stopping after 1 failures !!!!!!!!!!!!!!!!!!!!!!!!!!!
1 error in 0.78s