failed LOOP LOOP UNSUBMITTED agent_error · 44 tool calls · 241 s · fastapi/fastapi
🐛 Fix OpenAPI schema support for computed fields when using `separate_input_output_schemas=False` This demonstrates how the output schema differs when the FastAPI app runs with different values for `separate_input_output_schemas` - namely, the computed fields are omitted. Initially reported here: https://github.com/fastapi/fastapi/discussions/10342
| # | Tool | Arguments | Result |
|---|---|---|---|
| 1 | run_command | {
"command": "grep -rn \"separate_input_output_schemas\" . | head -20"
} | {"status": "ok", "stdout": "./fastapi/_compat/may_v1.py:65: separate_input_output_schemas: bool = True,\n./fastapi/_compat/v1.py:243: separate_input_output_schefull{"status": "ok", "stdout": "./fastapi/_compat/may_v1.py:65: separate_input_output_schemas: bool = True,\n./fastapi/_compat/v1.py:243: separate_input_output_schemas: bool = True,\n./fastapi/_compat/v1.py:259: separate_input_output_schemas: bool = True,\n./fastapi/_compat/main.py:271: separate_input_output_schemas: bool = True,\n./fastapi/_compat/main.py:284: separate_input_output_schemas=separate_input_output_schemas,\n./fastapi/_compat/main.py:295: separate_input_output_schemas=separate_input_output_schemas,\n./fastapi/_compat/main.py:309: separate_input_output_schemas=separate_input_output_schemas,\n./fastapi/_compat/main.py:322: separate_input_output_schemas: bool = True,\n./fastapi/_compat/main.py:331: separate_input_output_schemas=separate_input_output_schemas,\n./fastapi/_compat/main.py:341: separate_input_output_schemas=separate_input_output_schemas,\n./fastapi/_compat/v2.py:181: separate_input_output_schemas: bool = True,\n./fastapi/_compat/v2.py:184: None if separate_input_output_schemas else \"validation\"\n./fastapi/_compat/v2.py:201: separate_input_output_schemas: bool = True,\n./fastapi/_compat/v2.py:208: None if separate_input_output_schemas else \"validation\"\n./fastapi/applications.py:791: separate_input_output_schemas: Annotated[\n./fastapi/applications.py:875: self.separate_input_output_schemas = separate_input_output_schemas\n./fastapi/applications.py:1078: separate_input_output_schemas=self.separate_input_output_schemas,\n./fastapi/openapi/utils.py:102: separate_input_output_schemas: bool = True,\n./fastapi/openapi/utils.py:133: separate_input_output_schemas=separate_input_output_schemas,\n./fastapi/openapi/utils.py:175: separate_input_output_schemas: bool = True,\n", "stderr": "grep: ./.git/index: binary file matches\n", "exit_code": 0} |
| 2-4 ×3 | read_file | {
"filepath": "fastapi/openapi/utils.py",
"start_line": "100",
"end_line": "200"
} | {"status": "error", "error_type": "FileReadError", "error_message": "'>' not supported between instances of 'int' and 'str'"}full{"status": "error", "error_type": "FileReadError", "error_message": "'>' not supported between instances of 'int' and 'str'"} |
| 5 | read_file | {
"filepath": "fastapi/openapi/utils.py"
} | {"status": "ok", "filepath": "fastapi/openapi/utils.py", "content": "import http.client\nimport inspect\nimport warnings\nfrom typing import Any, Dict, List, Opfull{"status": "ok", "filepath": "fastapi/openapi/utils.py", "content": "import http.client\nimport inspect\nimport warnings\nfrom typing import Any, Dict, List, Optional, Sequence, Set, Tuple, Type, Union, cast\n\nfrom fastapi import routing\nfrom fastapi._compat import (\n JsonSchemaValue,\n ModelField,\n Undefined,\n get_compat_model_name_map,\n get_definitions,\n get_schema_from_model_field,\n lenient_issubclass,\n)\nfrom fastapi.datastructures import DefaultPlaceholder\nfrom fastapi.dependencies.models import Dependant\nfrom fastapi.dependencies.utils import (\n _get_flat_fields_from_params,\n get_flat_dependant,\n get_flat_params,\n)\nfrom fastapi.encoders import jsonable_encoder\nfrom fastapi.openapi.constants import METHODS_WITH_BODY, REF_PREFIX\nfrom fastapi.openapi.models import OpenAPI\nfrom fastapi.params import Body, ParamTypes\nfrom fastapi.responses import Response\nfrom fastapi.types import ModelNameMap\nfrom fastapi.utils import (\n deep_dict_update,\n generate_operation_id_for_path,\n is_body_allowed_for_status_code,\n)\nfrom pydantic import BaseModel\nfrom starlette.responses import JSONResponse\nfrom starlette.routing import BaseRoute\nfrom typing_extensions import Literal\n\nfrom .._compat import _is_model_field\n\nvalidation_error_definition = {\n \"title\": \"ValidationError\",\n \"type\": \"object\",\n \"properties\": {\n \"loc\": {\n \"title\": \"Location\",\n \"type\": \"array\",\n \"items\": {\"anyOf\": [{\"type\": \"string\"}, {\"type\": \"integer\"}]},\n },\n \"msg\": {\"title\": \"Message\", \"type\": \"string\"},\n \"type\": {\"title\": \"Error Type\", \"type\": \"string\"},\n },\n \"required\": [\"loc\", \"msg\", \"type\"],\n}\n\nvalidation_error_response_definition = {\n \"title\": \"HTTPValidationError\",\n \"type\": \"object\",\n \"properties\": {\n \"detail\": {\n \"title\": \"Detail\",\n |
| 6 | read_file | {
"filepath": "fastapi/openapi/utils.py",
"start_line": "151"
} | {"status": "error", "error_type": "FileReadError", "error_message": "'>' not supported between instances of 'int' and 'str'"}full{"status": "error", "error_type": "FileReadError", "error_message": "'>' not supported between instances of 'int' and 'str'"} |
| 7-8 ×2 | read_file | {
"filepath": "fastapi/openapi/utils.py",
"start_line": "151",
"end_line": "300"
} | {"status": "error", "error_type": "FileReadError", "error_message": "'>' not supported between instances of 'int' and 'str'"}full{"status": "error", "error_type": "FileReadError", "error_message": "'>' not supported between instances of 'int' and 'str'"} |
| 9 | read_file | {
"filepath": "fastapi/openapi/utils.py"
} | {"status": "ok", "filepath": "fastapi/openapi/utils.py", "content": "import http.client\nimport inspect\nimport warnings\nfrom typing import Any, Dict, List, Opfull{"status": "ok", "filepath": "fastapi/openapi/utils.py", "content": "import http.client\nimport inspect\nimport warnings\nfrom typing import Any, Dict, List, Optional, Sequence, Set, Tuple, Type, Union, cast\n\nfrom fastapi import routing\nfrom fastapi._compat import (\n JsonSchemaValue,\n ModelField,\n Undefined,\n get_compat_model_name_map,\n get_definitions,\n get_schema_from_model_field,\n lenient_issubclass,\n)\nfrom fastapi.datastructures import DefaultPlaceholder\nfrom fastapi.dependencies.models import Dependant\nfrom fastapi.dependencies.utils import (\n _get_flat_fields_from_params,\n get_flat_dependant,\n get_flat_params,\n)\nfrom fastapi.encoders import jsonable_encoder\nfrom fastapi.openapi.constants import METHODS_WITH_BODY, REF_PREFIX\nfrom fastapi.openapi.models import OpenAPI\nfrom fastapi.params import Body, ParamTypes\nfrom fastapi.responses import Response\nfrom fastapi.types import ModelNameMap\nfrom fastapi.utils import (\n deep_dict_update,\n generate_operation_id_for_path,\n is_body_allowed_for_status_code,\n)\nfrom pydantic import BaseModel\nfrom starlette.responses import JSONResponse\nfrom starlette.routing import BaseRoute\nfrom typing_extensions import Literal\n\nfrom .._compat import _is_model_field\n\nvalidation_error_definition = {\n \"title\": \"ValidationError\",\n \"type\": \"object\",\n \"properties\": {\n \"loc\": {\n \"title\": \"Location\",\n \"type\": \"array\",\n \"items\": {\"anyOf\": [{\"type\": \"string\"}, {\"type\": \"integer\"}]},\n },\n \"msg\": {\"title\": \"Message\", \"type\": \"string\"},\n \"type\": {\"title\": \"Error Type\", \"type\": \"string\"},\n },\n \"required\": [\"loc\", \"msg\", \"type\"],\n}\n\nvalidation_error_response_definition = {\n \"title\": \"HTTPValidationError\",\n \"type\": \"object\",\n \"properties\": {\n \"detail\": {\n \"title\": \"Detail\",\n |
| 10 | run_command | {
"command": "grep -rn \"separate_input_output_schemas\" fastapi/_compat/main.py fastapi/_compat/v1.py fastapi/_compat/v2.py"
} | {"status": "ok", "stdout": "fastapi/_compat/main.py:271: separate_input_output_schemas: bool = True,\nfastapi/_compat/main.py:284: separate_input_output_schemasfull{"status": "ok", "stdout": "fastapi/_compat/main.py:271: separate_input_output_schemas: bool = True,\nfastapi/_compat/main.py:284: separate_input_output_schemas=separate_input_output_schemas,\nfastapi/_compat/main.py:295: separate_input_output_schemas=separate_input_output_schemas,\nfastapi/_compat/main.py:309: separate_input_output_schemas=separate_input_output_schemas,\nfastapi/_compat/main.py:322: separate_input_output_schemas: bool = True,\nfastapi/_compat/main.py:331: separate_input_output_schemas=separate_input_output_schemas,\nfastapi/_compat/main.py:341: separate_input_output_schemas=separate_input_output_schemas,\nfastapi/_compat/v1.py:243: separate_input_output_schemas: bool = True,\nfastapi/_compat/v1.py:259: separate_input_output_schemas: bool = True,\nfastapi/_compat/v2.py:181: separate_input_output_schemas: bool = True,\nfastapi/_compat/v2.py:184: None if separate_input_output_schemas else \"validation\"\nfastapi/_compat/v2.py:201: separate_input_output_schemas: bool = True,\nfastapi/_compat/v2.py:208: None if separate_input_output_schemas else \"validation\"\n", "stderr": "", "exit_code": 0} |
| 11 | read_file | {
"filepath": "fastapi/_compat/v2.py"
} | {"status": "ok", "filepath": "fastapi/_compat/v2.py", "content": "import re\nimport warnings\nfrom copy import copy, deepcopy\nfrom dataclasses import dataclassfull{"status": "ok", "filepath": "fastapi/_compat/v2.py", "content": "import re\nimport warnings\nfrom copy import copy, deepcopy\nfrom dataclasses import dataclass\nfrom enum import Enum\nfrom typing import (\n Any,\n Dict,\n List,\n Sequence,\n Set,\n Tuple,\n Type,\n Union,\n cast,\n)\n\nfrom fastapi._compat import may_v1, shared\nfrom fastapi.openapi.constants import REF_TEMPLATE\nfrom fastapi.types import IncEx, ModelNameMap\nfrom pydantic import BaseModel, TypeAdapter, create_model\nfrom pydantic import PydanticSchemaGenerationError as PydanticSchemaGenerationError\nfrom pydantic import PydanticUndefinedAnnotation as PydanticUndefinedAnnotation\nfrom pydantic import ValidationError as ValidationError\nfrom pydantic._internal._schema_generation_shared import ( # type: ignore[attr-defined]\n GetJsonSchemaHandler as GetJsonSchemaHandler,\n)\nfrom pydantic._internal._typing_extra import eval_type_lenient\nfrom pydantic._internal._utils import lenient_issubclass as lenient_issubclass\nfrom pydantic.fields import FieldInfo as FieldInfo\nfrom pydantic.json_schema import GenerateJsonSchema as GenerateJsonSchema\nfrom pydantic.json_schema import JsonSchemaValue as JsonSchemaValue\nfrom pydantic_core import CoreSchema as CoreSchema\nfrom pydantic_core import PydanticUndefined, PydanticUndefinedType\nfrom pydantic_core import Url as Url\nfrom typing_extensions import Annotated, Literal, get_args, get_origin\n\ntry:\n from pydantic_core.core_schema import (\n with_info_plain_validator_function as with_info_plain_validator_function,\n )\nexcept ImportError: # pragma: no cover\n from pydantic_core.core_schema import (\n general_plain_validator_function as with_info_plain_validator_function, # noqa: F401\n )\n\nRequiredParam = PydanticUndefined\nUndefined = PydanticUndefined\nUndefinedType = PydanticUndefinedType\nevaluate_forwardref = eval_type_lenient\nValidator = Any\n\n\nclass BaseConfig:\n pass\n\n\nclass ErrorWr |
| 12 | read_file | {
"filepath": "fastapi/_compat/v2.py",
"start_line": "180"
} | {"status": "error", "error_type": "FileReadError", "error_message": "'>' not supported between instances of 'int' and 'str'"}full{"status": "error", "error_type": "FileReadError", "error_message": "'>' not supported between instances of 'int' and 'str'"} |
| 13 | read_file | {
"end_line": "220",
"filepath": "fastapi/_compat/v2.py",
"start_line": "180"
} | {"status": "error", "error_type": "FileReadError", "error_message": "'>' not supported between instances of 'int' and 'str'"}full{"status": "error", "error_type": "FileReadError", "error_message": "'>' not supported between instances of 'int' and 'str'"} |
| 14 | read_file | {
"filepath": "fastapi/_compat/v2.py"
} | {"status": "ok", "filepath": "fastapi/_compat/v2.py", "content": "import re\nimport warnings\nfrom copy import copy, deepcopy\nfrom dataclasses import dataclassfull{"status": "ok", "filepath": "fastapi/_compat/v2.py", "content": "import re\nimport warnings\nfrom copy import copy, deepcopy\nfrom dataclasses import dataclass\nfrom enum import Enum\nfrom typing import (\n Any,\n Dict,\n List,\n Sequence,\n Set,\n Tuple,\n Type,\n Union,\n cast,\n)\n\nfrom fastapi._compat import may_v1, shared\nfrom fastapi.openapi.constants import REF_TEMPLATE\nfrom fastapi.types import IncEx, ModelNameMap\nfrom pydantic import BaseModel, TypeAdapter, create_model\nfrom pydantic import PydanticSchemaGenerationError as PydanticSchemaGenerationError\nfrom pydantic import PydanticUndefinedAnnotation as PydanticUndefinedAnnotation\nfrom pydantic import ValidationError as ValidationError\nfrom pydantic._internal._schema_generation_shared import ( # type: ignore[attr-defined]\n GetJsonSchemaHandler as GetJsonSchemaHandler,\n)\nfrom pydantic._internal._typing_extra import eval_type_lenient\nfrom pydantic._internal._utils import lenient_issubclass as lenient_issubclass\nfrom pydantic.fields import FieldInfo as FieldInfo\nfrom pydantic.json_schema import GenerateJsonSchema as GenerateJsonSchema\nfrom pydantic.json_schema import JsonSchemaValue as JsonSchemaValue\nfrom pydantic_core import CoreSchema as CoreSchema\nfrom pydantic_core import PydanticUndefined, PydanticUndefinedType\nfrom pydantic_core import Url as Url\nfrom typing_extensions import Annotated, Literal, get_args, get_origin\n\ntry:\n from pydantic_core.core_schema import (\n with_info_plain_validator_function as with_info_plain_validator_function,\n )\nexcept ImportError: # pragma: no cover\n from pydantic_core.core_schema import (\n general_plain_validator_function as with_info_plain_validator_function, # noqa: F401\n )\n\nRequiredParam = PydanticUndefined\nUndefined = PydanticUndefined\nUndefinedType = PydanticUndefinedType\nevaluate_forwardref = eval_type_lenient\nValidator = Any\n\n\nclass BaseConfig:\n pass\n\n\nclass ErrorWr |
| 15 | run_command | {
"command": "grep -n \"separate_input_output_schemas\" fastapi/_compat/v2.py"
} | {"status": "ok", "stdout": "181: separate_input_output_schemas: bool = True,\n184: None if separate_input_output_schemas else \"validation\"\n201: separate_inpufull{"status": "ok", "stdout": "181: separate_input_output_schemas: bool = True,\n184: None if separate_input_output_schemas else \"validation\"\n201: separate_input_output_schemas: bool = True,\n208: None if separate_input_output_schemas else \"validation\"\n", "stderr": "", "exit_code": 0} |
| 16 | read_file | {
"end_line": "215",
"filepath": "fastapi/_compat/v2.py",
"start_line": "170"
} | {"status": "error", "error_type": "FileReadError", "error_message": "'>' not supported between instances of 'int' and 'str'"}full{"status": "error", "error_type": "FileReadError", "error_message": "'>' not supported between instances of 'int' and 'str'"} |
| 17 | read_file | {
"filepath": "fastapi/_compat/v2.py"
} | {"status": "ok", "filepath": "fastapi/_compat/v2.py", "content": "import re\nimport warnings\nfrom copy import copy, deepcopy\nfrom dataclasses import dataclassfull{"status": "ok", "filepath": "fastapi/_compat/v2.py", "content": "import re\nimport warnings\nfrom copy import copy, deepcopy\nfrom dataclasses import dataclass\nfrom enum import Enum\nfrom typing import (\n Any,\n Dict,\n List,\n Sequence,\n Set,\n Tuple,\n Type,\n Union,\n cast,\n)\n\nfrom fastapi._compat import may_v1, shared\nfrom fastapi.openapi.constants import REF_TEMPLATE\nfrom fastapi.types import IncEx, ModelNameMap\nfrom pydantic import BaseModel, TypeAdapter, create_model\nfrom pydantic import PydanticSchemaGenerationError as PydanticSchemaGenerationError\nfrom pydantic import PydanticUndefinedAnnotation as PydanticUndefinedAnnotation\nfrom pydantic import ValidationError as ValidationError\nfrom pydantic._internal._schema_generation_shared import ( # type: ignore[attr-defined]\n GetJsonSchemaHandler as GetJsonSchemaHandler,\n)\nfrom pydantic._internal._typing_extra import eval_type_lenient\nfrom pydantic._internal._utils import lenient_issubclass as lenient_issubclass\nfrom pydantic.fields import FieldInfo as FieldInfo\nfrom pydantic.json_schema import GenerateJsonSchema as GenerateJsonSchema\nfrom pydantic.json_schema import JsonSchemaValue as JsonSchemaValue\nfrom pydantic_core import CoreSchema as CoreSchema\nfrom pydantic_core import PydanticUndefined, PydanticUndefinedType\nfrom pydantic_core import Url as Url\nfrom typing_extensions import Annotated, Literal, get_args, get_origin\n\ntry:\n from pydantic_core.core_schema import (\n with_info_plain_validator_function as with_info_plain_validator_function,\n )\nexcept ImportError: # pragma: no cover\n from pydantic_core.core_schema import (\n general_plain_validator_function as with_info_plain_validator_function, # noqa: F401\n )\n\nRequiredParam = PydanticUndefined\nUndefined = PydanticUndefined\nUndefinedType = PydanticUndefinedType\nevaluate_forwardref = eval_type_lenient\nValidator = Any\n\n\nclass BaseConfig:\n pass\n\n\nclass ErrorWr |
| 18 | run_command | {
"command": "cat fastapi/_compat/v2.py | sed -n '170,220p'"
} | {"status": "ok", "stdout": "def _get_model_config(model: BaseModel) -> Any:\n return model.model_config\n\n\ndef get_schema_from_model_field(\n *,\n field: Modefull{"status": "ok", "stdout": "def _get_model_config(model: BaseModel) -> Any:\n return model.model_config\n\n\ndef get_schema_from_model_field(\n *,\n field: ModelField,\n model_name_map: ModelNameMap,\n field_mapping: Dict[\n Tuple[ModelField, Literal[\"validation\", \"serialization\"]], JsonSchemaValue\n ],\n separate_input_output_schemas: bool = True,\n) -> Dict[str, Any]:\n override_mode: Union[Literal[\"validation\"], None] = (\n None if separate_input_output_schemas else \"validation\"\n )\n # This expects that GenerateJsonSchema was already used to generate the definitions\n json_schema = field_mapping[(field, override_mode or field.mode)]\n if \"$ref\" not in json_schema:\n # TODO remove when deprecating Pydantic v1\n # Ref: https://github.com/pydantic/pydantic/blob/d61792cc42c80b13b23e3ffa74bc37ec7c77f7d1/pydantic/schema.py#L207\n json_schema[\"title\"] = field.field_info.title or field.alias.title().replace(\n \"_\", \" \"\n )\n return json_schema\n\n\ndef get_definitions(\n *,\n fields: Sequence[ModelField],\n model_name_map: ModelNameMap,\n separate_input_output_schemas: bool = True,\n) -> Tuple[\n Dict[Tuple[ModelField, Literal[\"validation\", \"serialization\"]], JsonSchemaValue],\n Dict[str, Dict[str, Any]],\n]:\n schema_generator = GenerateJsonSchema(ref_template=REF_TEMPLATE)\n override_mode: Union[Literal[\"validation\"], None] = (\n None if separate_input_output_schemas else \"validation\"\n )\n validation_fields = [field for field in fields if field.mode == \"validation\"]\n serialization_fields = [field for field in fields if field.mode == \"serialization\"]\n flat_validation_models = get_flat_models_from_fields(\n validation_fields, known_models=set()\n )\n flat_serialization_models = get_flat_models_from_fields(\n serialization_fields, known_models=set()\n )\n flat_validation_model_field |
| 19 | run_command | {
"command": "cat fastapi/_compat/v2.py | sed -n '221,300p'"
} | {"status": "ok", "stdout": " name=model.__name__,\n mode=\"validation\",\n )\n for model in flat_validation_models\n ]\n flat_serialization_model_fields = [\n Mfull{"status": "ok", "stdout": " name=model.__name__,\n mode=\"validation\",\n )\n for model in flat_validation_models\n ]\n flat_serialization_model_fields = [\n ModelField(\n field_info=FieldInfo(annotation=model),\n name=model.__name__,\n mode=\"serialization\",\n )\n for model in flat_serialization_models\n ]\n flat_model_fields = flat_validation_model_fields + flat_serialization_model_fields\n input_types = {f.type_ for f in fields}\n unique_flat_model_fields = {\n f for f in flat_model_fields if f.type_ not in input_types\n }\n\n inputs = [\n (field, override_mode or field.mode, field._type_adapter.core_schema)\n for field in list(fields) + list(unique_flat_model_fields)\n ]\n field_mapping, definitions = schema_generator.generate_definitions(inputs=inputs)\n for item_def in cast(Dict[str, Dict[str, Any]], definitions).values():\n if \"description\" in item_def:\n item_description = cast(str, item_def[\"description\"]).split(\"\\f\")[0]\n item_def[\"description\"] = item_description\n new_mapping, new_definitions = _remap_definitions_and_field_mappings(\n model_name_map=model_name_map,\n definitions=definitions, # type: ignore[arg-type]\n field_mapping=field_mapping,\n )\n return new_mapping, new_definitions\n\n\ndef _replace_refs(\n *,\n schema: Dict[str, Any],\n old_name_to_new_name_map: Dict[str, str],\n) -> Dict[str, Any]:\n new_schema = deepcopy(schema)\n for key, value in new_schema.items():\n if key == \"$ref\":\n value = schema[\"$ref\"]\n if isinstance(value, str):\n ref_name = schema[\"$ref\"].split(\"/\")[-1]\n if ref_name in old_name_to_new_name_map:\n new_name = old_name_to_new_name_map[ref_name]\n new_schema[\"$ref\"] = REF_TEMPLATE.format( |
| 20 | run_command | {
"command": "cat fastapi/_compat/v2.py | sed -n '200,230p'"
} | {"status": "ok", "stdout": " model_name_map: ModelNameMap,\n separate_input_output_schemas: bool = True,\n) -> Tuple[\n Dict[Tuple[ModelField, Literal[\"validatfull{"status": "ok", "stdout": " model_name_map: ModelNameMap,\n separate_input_output_schemas: bool = True,\n) -> Tuple[\n Dict[Tuple[ModelField, Literal[\"validation\", \"serialization\"]], JsonSchemaValue],\n Dict[str, Dict[str, Any]],\n]:\n schema_generator = GenerateJsonSchema(ref_template=REF_TEMPLATE)\n override_mode: Union[Literal[\"validation\"], None] = (\n None if separate_input_output_schemas else \"validation\"\n )\n validation_fields = [field for field in fields if field.mode == \"validation\"]\n serialization_fields = [field for field in fields if field.mode == \"serialization\"]\n flat_validation_models = get_flat_models_from_fields(\n validation_fields, known_models=set()\n )\n flat_serialization_models = get_flat_models_from_fields(\n serialization_fields, known_models=set()\n )\n flat_validation_model_fields = [\n ModelField(\n field_info=FieldInfo(annotation=model),\n name=model.__name__,\n mode=\"validation\",\n )\n for model in flat_validation_models\n ]\n flat_serialization_model_fields = [\n ModelField(\n field_info=FieldInfo(annotation=model),\n name=model.__name__,\n mode=\"serialization\",\n", "stderr": "", "exit_code": 0} |
| 21 | write_file | {
"content": "from fastapi import FastAPI\nfrom pydantic import BaseModel, computed_field\nfrom fastapi.testclient import TestClient\n\napp = FastAPI(separate_input_output_schemas=False)\n\nclass Item(BaseModel):\n name: str\n price: float\n\n @computed_field\n @property\n def total(self) -> float:\n return self.price * 1.2\n\n@app.get(\"/item\", response_model=Item)\nasync def get_item():\n return Item(name=\"Test\", price=10.0)\n\nclient = TestClient(app)\n\ndef test_computed_field_in_openapi():\n response = client.get(\"/openapi.json\")\n openapi_schema = response.json()\n \n # Find the Item schema in components/schemas\n schemas = openapi_schema.get(\"components\", {}).get(\"schemas\", {})\n item_schema = schemas.get(\"Item\")\n \n assert item_schema is not None, \"Item schema not found in OpenAPI\"\n properties = item_schema.get(\"properties\", {})\n assert \"total\" in properties, \"Computed field 'total' missing from Item schema when separate_input_output_schemas=False\"\n\nif __name__ == \"__main__\":\n try:\n test_computed_field_in_openapi()\n print(\"Test passed!\")\n except AssertionError as e:\n print(f\"Test failed: {e}\")\n except Exception as e:\n print(f\"An error occurred: {e}\")\n",
"filepath": "reproduce_issue.py"
} | {"status": "ok", "filepath": "reproduce_issue.py", "size": 1226}full{"status": "ok", "filepath": "reproduce_issue.py", "size": 1226} |
| 22-23 ×2 | run_command | {
"command": "python reproduce_issue.py"
} | {"status": "ok", "stdout": "Test failed: Computed field 'total' missing from Item schema when separate_input_output_schemas=False\n", "stderr": "", "exit_code":full{"status": "ok", "stdout": "Test failed: Computed field 'total' missing from Item schema when separate_input_output_schemas=False\n", "stderr": "", "exit_code": 0} |
| 24 | run_command | {
"command": "sed -i 's/separate_input_output_schemas=False/separate_input_output_schemas=True/' reproduce_issue.py && python reproduce_issue.py"
} | {"status": "ok", "stdout": "Test passed!\n", "stderr": "", "exit_code": 0}full{"status": "ok", "stdout": "Test passed!\n", "stderr": "", "exit_code": 0} |
| 25 | run_command | {
"command": "cat fastapi/_compat/v2.py | sed -n '170,230p'"
} | {"status": "ok", "stdout": "def _get_model_config(model: BaseModel) -> Any:\n return model.model_config\n\n\ndef get_schema_from_model_field(\n *,\n field: Modefull{"status": "ok", "stdout": "def _get_model_config(model: BaseModel) -> Any:\n return model.model_config\n\n\ndef get_schema_from_model_field(\n *,\n field: ModelField,\n model_name_map: ModelNameMap,\n field_mapping: Dict[\n Tuple[ModelField, Literal[\"validation\", \"serialization\"]], JsonSchemaValue\n ],\n separate_input_output_schemas: bool = True,\n) -> Dict[str, Any]:\n override_mode: Union[Literal[\"validation\"], None] = (\n None if separate_input_output_schemas else \"validation\"\n )\n # This expects that GenerateJsonSchema was already used to generate the definitions\n json_schema = field_mapping[(field, override_mode or field.mode)]\n if \"$ref\" not in json_schema:\n # TODO remove when deprecating Pydantic v1\n # Ref: https://github.com/pydantic/pydantic/blob/d61792cc42c80b13b23e3ffa74bc37ec7c77f7d1/pydantic/schema.py#L207\n json_schema[\"title\"] = field.field_info.title or field.alias.title().replace(\n \"_\", \" \"\n )\n return json_schema\n\n\ndef get_definitions(\n *,\n fields: Sequence[ModelField],\n model_name_map: ModelNameMap,\n separate_input_output_schemas: bool = True,\n) -> Tuple[\n Dict[Tuple[ModelField, Literal[\"validation\", \"serialization\"]], JsonSchemaValue],\n Dict[str, Dict[str, Any]],\n]:\n schema_generator = GenerateJsonSchema(ref_template=REF_TEMPLATE)\n override_mode: Union[Literal[\"validation\"], None] = (\n None if separate_input_output_schemas else \"validation\"\n )\n validation_fields = [field for field in fields if field.mode == \"validation\"]\n serialization_fields = [field for field in fields if field.mode == \"serialization\"]\n flat_validation_models = get_flat_models_from_fields(\n validation_fields, known_models=set()\n )\n flat_serialization_models = get_flat_models_from_fields(\n serialization_fields, known_models=set()\n )\n flat_validation_model_field |
| 26 | run_command | {
"command": "cat fastapi/_compat/v2.py | sed -n '231,260p'"
} | {"status": "ok", "stdout": " )\n for model in flat_serialization_models\n ]\n flat_model_fields = flat_validation_model_fields + flat_serialization_model_fieldsfull{"status": "ok", "stdout": " )\n for model in flat_serialization_models\n ]\n flat_model_fields = flat_validation_model_fields + flat_serialization_model_fields\n input_types = {f.type_ for f in fields}\n unique_flat_model_fields = {\n f for f in flat_model_fields if f.type_ not in input_types\n }\n\n inputs = [\n (field, override_mode or field.mode, field._type_adapter.core_schema)\n for field in list(fields) + list(unique_flat_model_fields)\n ]\n field_mapping, definitions = schema_generator.generate_definitions(inputs=inputs)\n for item_def in cast(Dict[str, Dict[str, Any]], definitions).values():\n if \"description\" in item_def:\n item_description = cast(str, item_def[\"description\"]).split(\"\\f\")[0]\n item_def[\"description\"] = item_description\n new_mapping, new_definitions = _remap_definitions_and_field_mappings(\n model_name_map=model_name_map,\n definitions=definitions, # type: ignore[arg-type]\n field_mapping=field_mapping,\n )\n return new_mapping, new_definitions\n\n\ndef _replace_refs(\n *,\n schema: Dict[str, Any],\n old_name_to_new_name_map: Dict[str, str],\n", "stderr": "", "exit_code": 0} |
| 27 | run_command | {
"command": "sed -i 's/separate_input_output_schemas=False/separate_input_output_schemas=True/' reproduce_issue.py && sed -i 's/separate_input_output_schemas=True/separate_input_output_schemas=False/' reproduce_issue.py"
} | {"status": "ok", "stdout": "", "stderr": "", "exit_code": 0}full{"status": "ok", "stdout": "", "stderr": "", "exit_code": 0} |
| 28 | run_command | {
"command": "python reproduce_issue.py"
} | {"status": "ok", "stdout": "Test failed: Computed field 'total' missing from Item schema when separate_input_output_schemas=False\n", "stderr": "", "exit_code":full{"status": "ok", "stdout": "Test failed: Computed field 'total' missing from Item schema when separate_input_output_schemas=False\n", "stderr": "", "exit_code": 0} |
| 29 | run_command | {
"command": "cat fastapi/_compat/v2.py | sed -n '180,190p'"
} | {"status": "ok", "stdout": " ],\n separate_input_output_schemas: bool = True,\n) -> Dict[str, Any]:\n override_mode: Union[Literal[\"validation\"], None] = (\n full{"status": "ok", "stdout": " ],\n separate_input_output_schemas: bool = True,\n) -> Dict[str, Any]:\n override_mode: Union[Literal[\"validation\"], None] = (\n None if separate_input_output_schemas else \"validation\"\n )\n # This expects that GenerateJsonSchema was already used to generate the definitions\n json_schema = field_mapping[(field, override_mode or field.mode)]\n if \"$ref\" not in json_schema:\n # TODO remove when deprecating Pydantic v1\n # Ref: https://github.com/pydantic/pydantic/blob/d61792cc42c80b13b23e3ffa74bc37ec7c77f7d1/pydantic/schema.py#L207\n", "stderr": "", "exit_code": 0} |
| 30 | run_command | {
"command": "cat fastapi/_compat/v2.py | sed -n '200,210p'"
} | {"status": "ok", "stdout": " model_name_map: ModelNameMap,\n separate_input_output_schemas: bool = True,\n) -> Tuple[\n Dict[Tuple[ModelField, Literal[\"validatfull{"status": "ok", "stdout": " model_name_map: ModelNameMap,\n separate_input_output_schemas: bool = True,\n) -> Tuple[\n Dict[Tuple[ModelField, Literal[\"validation\", \"serialization\"]], JsonSchemaValue],\n Dict[str, Dict[str, Any]],\n]:\n schema_generator = GenerateJsonSchema(ref_template=REF_TEMPLATE)\n override_mode: Union[Literal[\"validation\"], None] = (\n None if separate_input_output_schemas else \"validation\"\n )\n validation_fields = [field for field in fields if field.mode == \"validation\"]\n", "stderr": "", "exit_code": 0} |
| 31 | run_command | {
"command": "cat fastapi/_compat/v2.py | sed -n '240,250p'"
} | {"status": "ok", "stdout": " inputs = [\n (field, override_mode or field.mode, field._type_adapter.core_schema)\n for field in list(fields) + list(unique_flat_mfull{"status": "ok", "stdout": " inputs = [\n (field, override_mode or field.mode, field._type_adapter.core_schema)\n for field in list(fields) + list(unique_flat_model_fields)\n ]\n field_mapping, definitions = schema_generator.generate_definitions(inputs=inputs)\n for item_def in cast(Dict[str, Dict[str, Any]], definitions).values():\n if \"description\" in item_def:\n item_description = cast(str, item_def[\"description\"]).split(\"\\f\")[0]\n item_def[\"description\"] = item_description\n new_mapping, new_definitions = _remap_definitions_and_field_mappings(\n model_name_map=model_name_map,\n", "stderr": "", "exit_code": 0} |
| 32 | edit_file | {
"filepath": "fastapi/_compat/v2.py",
"new_string": " override_mode: Union[Literal[\"serialization\"], None] = (\n None if separate_input_output_schemas else \"serialization\"\n )",
"old_string": " override_mode: Union[Literal[\"validation\"], None] = (\n None if separate_input_output_schemas else \"validation\"\n )}"
} | {"status": "error", "error_type": "FileEditError", "error_message": "Failed to replace: old_string not found. Ensure you're not escaping content incorrectly andfull{"status": "error", "error_type": "FileEditError", "error_message": "Failed to replace: old_string not found. Ensure you're not escaping content incorrectly and check whitespace, indentation, and context."} |
| 33 | run_command | {
"command": "cat fastapi/_compat/v2.py | sed -n '180,185p'"
} | {"status": "ok", "stdout": " ],\n separate_input_output_schemas: bool = True,\n) -> Dict[str, Any]:\n override_mode: Union[Literal[\"validation\"], None] = (\n full{"status": "ok", "stdout": " ],\n separate_input_output_schemas: bool = True,\n) -> Dict[str, Any]:\n override_mode: Union[Literal[\"validation\"], None] = (\n None if separate_input_output_schemas else \"validation\"\n )\n", "stderr": "", "exit_code": 0} |
| 34 | run_command | {
"command": "cat fastapi/_compat/v2.py | sed -n '200,205p'"
} | {"status": "ok", "stdout": " model_name_map: ModelNameMap,\n separate_input_output_schemas: bool = True,\n) -> Tuple[\n Dict[Tuple[ModelField, Literal[\"validatfull{"status": "ok", "stdout": " model_name_map: ModelNameMap,\n separate_input_output_schemas: bool = True,\n) -> Tuple[\n Dict[Tuple[ModelField, Literal[\"validation\", \"serialization\"]], JsonSchemaValue],\n Dict[str, Dict[str, Any]],\n]:\n", "stderr": "", "exit_code": 0} |
| 35 | run_command | {
"command": "cat fastapi/_compat/v2.py | sed -n '206,210p'"
} | {"status": "ok", "stdout": " schema_generator = GenerateJsonSchema(ref_template=REF_TEMPLATE)\n override_mode: Union[Literal[\"validation\"], None] = (\n None ifull{"status": "ok", "stdout": " schema_generator = GenerateJsonSchema(ref_template=REF_TEMPLATE)\n override_mode: Union[Literal[\"validation\"], None] = (\n None if separate_input_output_schemas else \"validation\"\n )\n validation_fields = [field for field in fields if field.mode == \"validation\"]\n", "stderr": "", "exit_code": 0} |
| 36 | edit_file | {
"filepath": "fastapi/_compat/v2.py",
"new_string": " override_mode: Union[Literal[\"serialization\"], None] = (\n None if separate_input_output_schemas else \"serialization\"\n )",
"old_string": " override_mode: Union[Literal[\"validation\"], None] = (\n None if separate_input_output_schemas else \"validation\"\n )"
} | {"status": "error", "error_type": "FileEditError", "error_message": "Target string occurs 2 times in fastapi/_compat/v2.py. Please provide more surrounding contfull{"status": "error", "error_type": "FileEditError", "error_message": "Target string occurs 2 times in fastapi/_compat/v2.py. Please provide more surrounding context."} |
| 37 | edit_file | {
"filepath": "fastapi/_compat/v2.py",
"new_string": " override_mode: Union[Literal[\"serialization\"], None] = (\n None if separate_input_output_schemas else \"serialization\"\n )",
"old_string": "def get_schema_from_model_field(\n *,\n field: ModelField,\n model_name_map: ModelNameMap,\n field_mapping: Dict[\n Tuple[ModelField, Literal[\"validation\", \"serialization\"]], JsonSchemaValue\n ],\n separate_input_output_schemas: bool = True,\n) -> Dict[str, Any]:\n override_mode: Union[Literal[\"validation\"], None] = (\n None if separate_input_output_schemas else \"validation\"\n )"
} | {"status": "ok", "filepath": "fastapi/_compat/v2.py", "occurrences": 1, "strategy": "exact", "diff": "--- a/fastapi/_compat/v2.py\n+++ b/fastapi/_compat/v2.py\nfull{"status": "ok", "filepath": "fastapi/_compat/v2.py", "occurrences": 1, "strategy": "exact", "diff": "--- a/fastapi/_compat/v2.py\n+++ b/fastapi/_compat/v2.py\n@@ -171,17 +171,8 @@\n return model.model_config\n \n \n-def get_schema_from_model_field(\n- *,\n- field: ModelField,\n- model_name_map: ModelNameMap,\n- field_mapping: Dict[\n- Tuple[ModelField, Literal[\"validation\", \"serialization\"]], JsonSchemaValue\n- ],\n- separate_input_output_schemas: bool = True,\n-) -> Dict[str, Any]:\n- override_mode: Union[Literal[\"validation\"], None] = (\n- None if separate_input_output_schemas else \"validation\"\n+ override_mode: Union[Literal[\"serialization\"], None] = (\n+ None if separate_input_output_schemas else \"serialization\"\n )\n # This expects that GenerateJsonSchema was already used to generate the definitions\n json_schema = field_mapping[(field, override_mode or field.mode)]\n", "is_truncated": false} |
| 38 | run_command | {
"command": "python reproduce_issue.py"
} | {"status": "ok", "stdout": "An error occurred: module 'fastapi._compat.v2' has no attribute 'get_schema_from_model_field'\n", "stderr": "", "exit_code": 0}full{"status": "ok", "stdout": "An error occurred: module 'fastapi._compat.v2' has no attribute 'get_schema_from_model_field'\n", "stderr": "", "exit_code": 0} |
| 39 | read_file | {
"filepath": "fastapi/_compat/v2.py"
} | {"status": "ok", "filepath": "fastapi/_compat/v2.py", "content": "import re\nimport warnings\nfrom copy import copy, deepcopy\nfrom dataclasses import dataclassfull{"status": "ok", "filepath": "fastapi/_compat/v2.py", "content": "import re\nimport warnings\nfrom copy import copy, deepcopy\nfrom dataclasses import dataclass\nfrom enum import Enum\nfrom typing import (\n Any,\n Dict,\n List,\n Sequence,\n Set,\n Tuple,\n Type,\n Union,\n cast,\n)\n\nfrom fastapi._compat import may_v1, shared\nfrom fastapi.openapi.constants import REF_TEMPLATE\nfrom fastapi.types import IncEx, ModelNameMap\nfrom pydantic import BaseModel, TypeAdapter, create_model\nfrom pydantic import PydanticSchemaGenerationError as PydanticSchemaGenerationError\nfrom pydantic import PydanticUndefinedAnnotation as PydanticUndefinedAnnotation\nfrom pydantic import ValidationError as ValidationError\nfrom pydantic._internal._schema_generation_shared import ( # type: ignore[attr-defined]\n GetJsonSchemaHandler as GetJsonSchemaHandler,\n)\nfrom pydantic._internal._typing_extra import eval_type_lenient\nfrom pydantic._internal._utils import lenient_issubclass as lenient_issubclass\nfrom pydantic.fields import FieldInfo as FieldInfo\nfrom pydantic.json_schema import GenerateJsonSchema as GenerateJsonSchema\nfrom pydantic.json_schema import JsonSchemaValue as JsonSchemaValue\nfrom pydantic_core import CoreSchema as CoreSchema\nfrom pydantic_core import PydanticUndefined, PydanticUndefinedType\nfrom pydantic_core import Url as Url\nfrom typing_extensions import Annotated, Literal, get_args, get_origin\n\ntry:\n from pydantic_core.core_schema import (\n with_info_plain_validator_function as with_info_plain_validator_function,\n )\nexcept ImportError: # pragma: no cover\n from pydantic_core.core_schema import (\n general_plain_validator_function as with_info_plain_validator_function, # noqa: F401\n )\n\nRequiredParam = PydanticUndefined\nUndefined = PydanticUndefined\nUndefinedType = PydanticUndefinedType\nevaluate_forwardref = eval_type_lenient\nValidator = Any\n\n\nclass BaseConfig:\n pass\n\n\nclass ErrorWr |
| 40 | run_command | {
"command": "cat fastapi/_compat/v2.py | sed -n '170,180p'"
} | {"status": "ok", "stdout": "def _get_model_config(model: BaseModel) -> Any:\n return model.model_config\n\n\n override_mode: Union[Literal[\"serialization\"], Nfull{"status": "ok", "stdout": "def _get_model_config(model: BaseModel) -> Any:\n return model.model_config\n\n\n override_mode: Union[Literal[\"serialization\"], None] = (\n None if separate_input_output_schemas else \"serialization\"\n )\n # This expects that GenerateJsonSchema was already used to generate the definitions\n json_schema = field_mapping[(field, override_mode or field.mode)]\n if \"$ref\" not in json_schema:\n # TODO remove when deprecating Pydantic v1\n", "stderr": "", "exit_code": 0} |
| 41 | edit_file | {
"filepath": "fastapi/_compat/v2.py",
"new_string": "def get_schema_from_model_field(\n *,\n field: ModelField,\n model_name_map: ModelNameMap,\n field_mapping: Dict[\n Tuple[ModelField, Literal[\"validation\", \"serialization\"]], JsonSchemaValue\n ],\n separate_input_output_schemas: bool = True,\n) -> Dict[str, Any]:\n override_mode: Union[Literal[\"serialization\"], None] = (\n None if separate_input_output_schemas else \"serialization\"\n )",
"old_string": " override_mode: Union[Literal[\"serialization\"], None] = (\n None if separate_input_output_schemas else \"serialization\"\n )"
} | {"status": "ok", "filepath": "fastapi/_compat/v2.py", "occurrences": 1, "strategy": "exact", "diff": "--- a/fastapi/_compat/v2.py\n+++ b/fastapi/_compat/v2.py\nfull{"status": "ok", "filepath": "fastapi/_compat/v2.py", "occurrences": 1, "strategy": "exact", "diff": "--- a/fastapi/_compat/v2.py\n+++ b/fastapi/_compat/v2.py\n@@ -171,6 +171,15 @@\n return model.model_config\n \n \n+def get_schema_from_model_field(\n+ *,\n+ field: ModelField,\n+ model_name_map: ModelNameMap,\n+ field_mapping: Dict[\n+ Tuple[ModelField, Literal[\"validation\", \"serialization\"]], JsonSchemaValue\n+ ],\n+ separate_input_output_schemas: bool = True,\n+) -> Dict[str, Any]:\n override_mode: Union[Literal[\"serialization\"], None] = (\n None if separate_input_output_schemas else \"serialization\"\n )\n", "is_truncated": false} |
| 42 | run_command | {
"command": "python reproduce_issue.py"
} | {"status": "ok", "stdout": "An error occurred: (ModelField(field_info=FieldInfo(annotation=Item, required=True), name='Response_get_item_item_get', mode='serialfull{"status": "ok", "stdout": "An error occurred: (ModelField(field_info=FieldInfo(annotation=Item, required=True), name='Response_get_item_item_get', mode='serialization'), 'serialization')\n", "stderr": "", "exit_code": 0} |
| 43 | run_command | {
"command": "cat fastapi/_compat/v2.py | sed -n '170,200p'"
} | {"status": "ok", "stdout": "def _get_model_config(model: BaseModel) -> Any:\n return model.model_config\n\n\ndef get_schema_from_model_field(\n *,\n field: Modefull{"status": "ok", "stdout": "def _get_model_config(model: BaseModel) -> Any:\n return model.model_config\n\n\ndef get_schema_from_model_field(\n *,\n field: ModelField,\n model_name_map: ModelNameMap,\n field_mapping: Dict[\n Tuple[ModelField, Literal[\"validation\", \"serialization\"]], JsonSchemaValue\n ],\n separate_input_output_schemas: bool = True,\n) -> Dict[str, Any]:\n override_mode: Union[Literal[\"serialization\"], None] = (\n None if separate_input_output_schemas else \"serialization\"\n )\n # This expects that GenerateJsonSchema was already used to generate the definitions\n json_schema = field_mapping[(field, override_mode or field.mode)]\n if \"$ref\" not in json_schema:\n # TODO remove when deprecating Pydantic v1\n # Ref: https://github.com/pydantic/pydantic/blob/d61792cc42c80b13b23e3ffa74bc37ec7c77f7d1/pydantic/schema.py#L207\n json_schema[\"title\"] = field.field_info.title or field.alias.title().replace(\n \"_\", \" \"\n )\n return json_schema\n\n\ndef get_definitions(\n *,\n fields: Sequence[ModelField],\n model_name_map: ModelNameMap,\n", "stderr": "", "exit_code": 0} |
| 44 | run_command | {
"command": "cat fastapi/_compat/v2.py | sed -n '200,220p'"
} | {"status": "ok", "stdout": " model_name_map: ModelNameMap,\n separate_input_output_schemas: bool = True,\n) -> Tuple[\n Dict[Tuple[ModelField, Literal[\"validatfull{"status": "ok", "stdout": " model_name_map: ModelNameMap,\n separate_input_output_schemas: bool = True,\n) -> Tuple[\n Dict[Tuple[ModelField, Literal[\"validation\", \"serialization\"]], JsonSchemaValue],\n Dict[str, Dict[str, Any]],\n]:\n schema_generator = GenerateJsonSchema(ref_template=REF_TEMPLATE)\n override_mode: Union[Literal[\"validation\"], None] = (\n None if separate_input_output_schemas else \"validation\"\n )\n validation_fields = [field for field in fields if field.mode == \"validation\"]\n serialization_fields = [field for field in fields if field.mode == \"serialization\"]\n flat_validation_models = get_flat_models_from_fields(\n validation_fields, known_models=set()\n )\n flat_serialization_models = get_flat_models_from_fields(\n serialization_fields, known_models=set()\n )\n flat_validation_model_fields = [\n ModelField(\n field_info=FieldInfo(annotation=model),\n", "stderr": "", "exit_code": 0} |
diff --git a/fastapi/_compat/v2.py b/fastapi/_compat/v2.py
index 3d91814c..f40b89e3 100644
--- a/fastapi/_compat/v2.py
+++ b/fastapi/_compat/v2.py
@@ -180,8 +180,8 @@ def get_schema_from_model_field(
],
separate_input_output_schemas: bool = True,
) -> Dict[str, Any]:
- override_mode: Union[Literal["validation"], None] = (
- None if separate_input_output_schemas else "validation"
+ override_mode: Union[Literal["serialization"], None] = (
+ None if separate_input_output_schemas else "serialization"
)
# This expects that GenerateJsonSchema was already used to generate the definitions
json_schema = field_mapping[(field, override_mode or field.mode)]
diff --git a/reproduce_issue.py b/reproduce_issue.py
new file mode 100644
index 00000000..f8caeb05
--- /dev/null
+++ b/reproduce_issue.py
@@ -0,0 +1,41 @@
+from fastapi import FastAPI
+from pydantic import BaseModel, computed_field
+from fastapi.testclient import TestClient
+
+app = FastAPI(separate_input_output_schemas=False)
+
+class Item(BaseModel):
+ name: str
+ price: float
+
+ @computed_field
+ @property
+ def total(self) -> float:
+ return self.price * 1.2
+
+@app.get("/item", response_model=Item)
+async def get_item():
+ return Item(name="Test", price=10.0)
+
+client = TestClient(app)
+
+def test_computed_field_in_openapi():
+ response = client.get("/openapi.json")
+ openapi_schema = response.json()
+
+ # Find the Item schema in components/schemas
+ schemas = openapi_schema.get("components", {}).get("schemas", {})
+ item_schema = schemas.get("Item")
+
+ assert item_schema is not None, "Item schema not found in OpenAPI"
+ properties = item_schema.get("properties", {})
+ assert "total" in properties, "Computed field 'total' missing from Item schema when separate_input_output_schemas=False"
+
+if __name__ == "__main__":
+ try:
+ test_computed_field_in_openapi()
+ print("Test passed!")
+ except AssertionError as e:
+ print(f"Test failed: {e}")
+ except Exception as e:
+ print(f"An error occurred: {e}")
equest)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
/kaggle/tmp/envs/fastapi/lib/python3.13/site-packages/httpx/_client.py:1014: in _send_single_request
response = transport.handle_request(request)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
/kaggle/tmp/envs/overlays/starlette-0.50.0-py3-none-any/starlette/testclient.py:348: in handle_request
raise exc
/kaggle/tmp/envs/overlays/starlette-0.50.0-py3-none-any/starlette/testclient.py:345: in handle_request
portal.call(self.app, scope, receive, send)
/kaggle/tmp/envs/fastapi/lib/python3.13/site-packages/anyio/from_thread.py:340: in call
return cast(T_Retval, self.start_task_soon(func, *args).result())
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
/root/.local/share/uv/python/cpython-3.13.14-linux-x86_64-gnu/lib/python3.13/concurrent/futures/_base.py:460: in result
return self.__get_result()
^^^^^^^^^^^^^^^^^^^
/root/.local/share/uv/python/cpython-3.13.14-linux-x86_64-gnu/lib/python3.13/concurrent/futures/_base.py:402: in __get_result
raise self._exception
/kaggle/tmp/envs/fastapi/lib/python3.13/site-packages/anyio/from_thread.py:265: in _call_func
retval = await retval_or_awaitable
^^^^^^^^^^^^^^^^^^^^^^^^^
fastapi/applications.py:1139: in __call__
await super().__call__(scope, receive, send)
/kaggle/tmp/envs/overlays/starlette-0.50.0-py3-none-any/starlette/applications.py:107: in __call__
await self.middleware_stack(scope, receive, send)
/kaggle/tmp/envs/overlays/starlette-0.50.0-py3-none-any/starlette/middleware/errors.py:186: in __call__
raise exc
/kaggle/tmp/envs/overlays/starlette-0.50.0-py3-none-any/starlette/middleware/errors.py:164: in __call__
await self.app(scope, receive, _send)
/kaggle/tmp/envs/overlays/starlette-0.50.0-py3-none-any/starlette/middleware/exceptions.py:63: in __call__
await wrap_app_handling_exceptions(self.app, conn)(scope, receive, send)
/kaggle/tmp/envs/overlays/starlette-0.50.0-py3-none-any/starlette/_exception_handler.py:53: in wrapped_app
raise exc
/kaggle/tmp/envs/overlays/starlette-0.50.0-py3-none-any/starlette/_exception_handler.py:42: in wrapped_app
await app(scope, receive, sender)
fastapi/middleware/asyncexitstack.py:18: in __call__
await self.app(scope, receive, send)
/kaggle/tmp/envs/overlays/starlette-0.50.0-py3-none-any/starlette/routing.py:716: in __call__
await self.middleware_stack(scope, receive, send)
/kaggle/tmp/envs/overlays/starlette-0.50.0-py3-none-any/starlette/routing.py:736: in app
await route.handle(scope, receive, send)
/kaggle/tmp/envs/overlays/starlette-0.50.0-py3-none-any/starlette/routing.py:290: in handle
await self.app(scope, receive, send)
/kaggle/tmp/envs/overlays/starlette-0.50.0-py3-none-any/starlette/routing.py:78: in app
await wrap_app_handling_exceptions(app, request)(scope, receive, send)
/kaggle/tmp/envs/overlays/starlette-0.50.0-py3-none-any/starlette/_exception_handler.py:53: in wrapped_app
raise exc
/kaggle/tmp/envs/overlays/starlette-0.50.0-py3-none-any/starlette/_exception_handler.py:42: in wrapped_app
await app(scope, receive, sender)
/kaggle/tmp/envs/overlays/starlette-0.50.0-py3-none-any/starlette/routing.py:75: in app
response = await f(request)
^^^^^^^^^^^^^^^^
fastapi/applications.py:1094: in openapi
return JSONResponse(self.openapi())
^^^^^^^^^^^^^^
fastapi/applications.py:1065: in openapi
self.openapi_schema = get_openapi(
fastapi/openapi/utils.py:511: in get_openapi
result = get_openapi_path(
fastapi/openapi/utils.py:352: in get_openapi_path
response_schema = get_schema_from_model_field(
fastapi/_compat/main.py:337: in get_schema_from_model_field
return v2.get_schema_from_model_field(
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
field = ModelField(field_info=FieldInfo(annotation=get_client.<locals>.Rectangle, required=True), name='Response_read_root__get', mode='serialization')
model_name_map = {<class 'tests.test_computed_fields.get_client.<locals>.Rectangle'>: 'Rectangle'}
field_mapping = {(ModelField(field_info=FieldInfo(annotation=get_client.<locals>.Rectangle, required=True), name='Response_read_root__...se_200_read_responses_responses_get', mode='serialization'), 'validation'): {'$ref': '#/components/schemas/Rectangle'}}
separate_input_output_schemas = False
def get_schema_from_model_field(
*,
field: ModelField,
model_name_map: ModelNameMap,
field_mapping: Dict[
Tuple[ModelField, Literal["validation", "serialization"]], JsonSchemaValue
],
separate_input_output_schemas: bool = True,
) -> Dict[str, Any]:
override_mode: Union[Literal["serialization"], None] = (
None if separate_input_output_schemas else "serialization"
)
# This expects that GenerateJsonSchema was already used to generate the definitions
> json_schema = field_mapping[(field, override_mode or field.mode)]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
E KeyError: (ModelField(field_info=FieldInfo(annotation=get_client.<locals>.Rectangle, required=True), name='Response_read_root__get', mode='serialization'), 'serialization')
fastapi/_compat/v2.py:187: KeyError
=============================== warnings summary ===============================
../../../../../../kaggle/tmp/envs/overlays/starlette-0.50.0-py3-none-any/starlette/testclient.py:45
/kaggle/tmp/envs/overlays/starlette-0.50.0-py3-none-any/starlette/testclient.py:45: DeprecationWarning: The anyio.abc.BlockingPortal alias is deprecated, use anyio.from_thread.BlockingPortal instead.
_PortalFactoryType = Callable[[], AbstractContextManager[anyio.abc.BlockingPortal]]
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
!!!!!!!!!!!!!!!!!!!!!!!!!! stopping after 1 failures !!!!!!!!!!!!!!!!!!!!!!!!!!!
1 failed, 5 passed, 1 warning in 0.94s