← eval5_submission_v1s

fastapi_13537

resolved RESOLVED PASS · 19 tool calls · 80 s · fastapi/fastapi

Task input

🐛 Fix support for form values with empty strings interpreted as missing (`None` if that's the default), for compatibility with HTML forms

There was a bug in the validation of form data for optional params with None default value. This is a regression that was introduced by https://github.com/fastapi/fastapi/pull/12134.

## Explaination:
The `_get_multidict_value` uses `None` to represent both the absence a value in the dict, and a default value of `None` for that field. When the values are collected in `_extract_form_body`, they are only added to the values if they are not `None`. Later (#12134), some code was added that attempted to complement the model values with values not explicitely in the model, if values for those fields were not already processed earlier. The issue is that since we didn't add values to the initial value dict if they were none, we attempted to add them again in that second iteration. This generally wasn't an issue, except for the fast that a form field set to the empty string (`""`) is interpreted as the absence of that field. This resulted in `_get_multidict_value` picking the default value, that would happen to be `None`, so it wasn't added to the values dict in the first iteration. In the second iteration, we would find that value in the request params again, but set to `""`, and add that to the initial value dict. Later, validation would choke on that empty string.

The fix is to keep track of already visited field, rather that relying on the content of the values dict to complement the missing field. Such thing was already done in `request_params_to_args` for example.


closes #13533 

Tool calls (20)

#ToolArgumentsResult
1run_command
{
 "command": "grep -rn \"_extract_form_body\" ."
}
{"status": "ok", "stdout": "./fastapi/dependencies/utils.py:869:async def _extract_form_body(\n./fastapi/dependencies/utils.py:933: body_to_process = await _ext
full
{"status": "ok", "stdout": "./fastapi/dependencies/utils.py:869:async def _extract_form_body(\n./fastapi/dependencies/utils.py:933:        body_to_process = await _extract_form_body(fields_to_extract, received_body)\n", "stderr": "", "exit_code": 0}
2-3 ×2read_file
{
 "filepath": "fastapi/dependencies/utils.py",
 "start_line": "869",
 "end_line": "950"
}
{"status": "error", "error_type": "FileReadError", "error_message": "'>' not supported between instances of 'int' and 'str'"}
full
{"status": "error", "error_type": "FileReadError", "error_message": "'>' not supported between instances of 'int' and 'str'"}
4read_file
{
 "filepath": "fastapi/dependencies/utils.py",
 "start_line": "869"
}
{"status": "error", "error_type": "FileReadError", "error_message": "'>' not supported between instances of 'int' and 'str'"}
full
{"status": "error", "error_type": "FileReadError", "error_message": "'>' not supported between instances of 'int' and 'str'"}
5run_command
{
 "command": "grep -n \"def _extract_form_body\" fastapi/dependencies/utils.py"
}
{"status": "ok", "stdout": "869:async def _extract_form_body(\n", "stderr": "", "exit_code": 0}
full
{"status": "ok", "stdout": "869:async def _extract_form_body(\n", "stderr": "", "exit_code": 0}
6read_file
{
 "end_line": "940",
 "filepath": "fastapi/dependencies/utils.py",
 "start_line": "869"
}
{"status": "error", "error_type": "FileReadError", "error_message": "'>' not supported between instances of 'int' and 'str'"}
full
{"status": "error", "error_type": "FileReadError", "error_message": "'>' not supported between instances of 'int' and 'str'"}
7run_command
{
 "command": "head -n 1000 fastapi/dependencies/utils.py | tail -n 200"
}
{"status": "ok", "stdout": " \"Params must be subclasses of Param\"\n )\n loc: Tuple[str, ...] = (field_info.in_.value,)\n v_, errors_ = _validate_value_with_mo
full
{"status": "ok", "stdout": "            \"Params must be subclasses of Param\"\n        )\n        loc: Tuple[str, ...] = (field_info.in_.value,)\n        v_, errors_ = _validate_value_with_model_field(\n            field=first_field, value=params_to_process, values=values, loc=loc\n        )\n        return {first_field.name: v_}, errors_\n\n    for field in fields:\n        value = _get_multidict_value(field, received_params)\n        field_info = field.field_info\n        assert isinstance(field_info, (params.Param, temp_pydantic_v1_params.Param)), (\n            \"Params must be subclasses of Param\"\n        )\n        loc = (field_info.in_.value, field.alias)\n        v_, errors_ = _validate_value_with_model_field(\n            field=field, value=value, values=values, loc=loc\n        )\n        if errors_:\n            errors.extend(errors_)\n        else:\n            values[field.name] = v_\n    return values, errors\n\n\ndef is_union_of_base_models(field_type: Any) -> bool:\n    \"\"\"Check if field type is a Union where all members are BaseModel subclasses.\"\"\"\n    from fastapi.types import UnionType\n\n    origin = get_origin(field_type)\n\n    # Check if it's a Union type (covers both typing.Union and types.UnionType in Python 3.10+)\n    if origin is not Union and origin is not UnionType:\n        return False\n\n    union_args = get_args(field_type)\n\n    for arg in union_args:\n        if not _is_model_class(arg):\n            return False\n\n    return True\n\n\ndef _should_embed_body_fields(fields: List[ModelField]) -> bool:\n    if not fields:\n        return False\n    # More than one dependency could have the same field, it would show up as multiple\n    # fields but it's the same one, so count them by name\n    body_param_names_set = {field.name for field in fields}\n    # A top level field has to be a single field, not multiple\n    if len(body_param_names_set) > 1:\n        return True\n    first_field = fields[0]\n    # If it explicitly 
8read_file
{
 "end_line": "933",
 "filepath": "fastapi/dependencies/utils.py",
 "start_line": "869"
}
{"status": "error", "error_type": "FileReadError", "error_message": "'>' not supported between instances of 'int' and 'str'"}
full
{"status": "error", "error_type": "FileReadError", "error_message": "'>' not supported between instances of 'int' and 'str'"}
9run_command
{
 "command": "cat fastapi/dependencies/utils.py | sed -n '869,933p'"
}
{"status": "ok", "stdout": "async def _extract_form_body(\n body_fields: List[ModelField],\n received_body: FormData,\n) -> Dict[str, Any]:\n values = {}\n\n fo
full
{"status": "ok", "stdout": "async def _extract_form_body(\n    body_fields: List[ModelField],\n    received_body: FormData,\n) -> Dict[str, Any]:\n    values = {}\n\n    for field in body_fields:\n        value = _get_multidict_value(field, received_body)\n        field_info = field.field_info\n        if (\n            isinstance(field_info, (params.File, temp_pydantic_v1_params.File))\n            and is_bytes_field(field)\n            and isinstance(value, UploadFile)\n        ):\n            value = await value.read()\n        elif (\n            is_bytes_sequence_field(field)\n            and isinstance(field_info, (params.File, temp_pydantic_v1_params.File))\n            and value_is_sequence(value)\n        ):\n            # For types\n            assert isinstance(value, sequence_types)  # type: ignore[arg-type]\n            results: List[Union[bytes, str]] = []\n\n            async def process_fn(\n                fn: Callable[[], Coroutine[Any, Any, Any]],\n            ) -> None:\n                result = await fn()\n                results.append(result)  # noqa: B023\n\n            async with anyio.create_task_group() as tg:\n                for sub_value in value:\n                    tg.start_soon(process_fn, sub_value.read)\n            value = serialize_sequence_value(field=field, value=results)\n        if value is not None:\n            values[field.alias] = value\n    for key, value in received_body.items():\n        if key not in values:\n            values[key] = value\n    return values\n\n\nasync def request_body_to_args(\n    body_fields: List[ModelField],\n    received_body: Optional[Union[Dict[str, Any], FormData]],\n    embed_body_fields: bool,\n) -> Tuple[Dict[str, Any], List[Dict[str, Any]]]:\n    values: Dict[str, Any] = {}\n    errors: List[Dict[str, Any]] = []\n    assert body_fields, \"request_body_to_args() should be called with fields\"\n    single_not_embedded_field = len(body_fields) == 1 and not embed_body_fields\n    first_fiel
10run_command
{
 "command": "grep -n \"_get_multidict_value\" fastapi/dependencies/utils.py"
}
{"status": "ok", "stdout": "723:def _get_multidict_value(\n788: value = _get_multidict_value(field, received_params, alias=alias)\n810: value = _get_multidict_v
full
{"status": "ok", "stdout": "723:def _get_multidict_value(\n788:        value = _get_multidict_value(field, received_params, alias=alias)\n810:        value = _get_multidict_value(field, received_params)\n876:        value = _get_multidict_value(field, received_body)\n", "stderr": "", "exit_code": 0}
11run_command
{
 "command": "cat fastapi/dependencies/utils.py | sed -n '723,787p'"
}
{"status": "ok", "stdout": "def _get_multidict_value(\n field: ModelField, values: Mapping[str, Any], alias: Union[str, None] = None\n) -> Any:\n alias = alias
full
{"status": "ok", "stdout": "def _get_multidict_value(\n    field: ModelField, values: Mapping[str, Any], alias: Union[str, None] = None\n) -> Any:\n    alias = alias or field.alias\n    if is_sequence_field(field) and isinstance(values, (ImmutableMultiDict, Headers)):\n        value = values.getlist(alias)\n    else:\n        value = values.get(alias, None)\n    if (\n        value is None\n        or (\n            isinstance(field.field_info, (params.Form, temp_pydantic_v1_params.Form))\n            and isinstance(value, str)  # For type checks\n            and value == \"\"\n        )\n        or (is_sequence_field(field) and len(value) == 0)\n    ):\n        if field.required:\n            return\n        else:\n            return deepcopy(field.default)\n    return value\n\n\ndef request_params_to_args(\n    fields: Sequence[ModelField],\n    received_params: Union[Mapping[str, Any], QueryParams, Headers],\n) -> Tuple[Dict[str, Any], List[Any]]:\n    values: Dict[str, Any] = {}\n    errors: List[Dict[str, Any]] = []\n\n    if not fields:\n        return values, errors\n\n    first_field = fields[0]\n    fields_to_extract = fields\n    single_not_embedded_field = False\n    default_convert_underscores = True\n    if len(fields) == 1 and lenient_issubclass(first_field.type_, BaseModel):\n        fields_to_extract = get_cached_model_fields(first_field.type_)\n        single_not_embedded_field = True\n        # If headers are in a Pydantic model, the way to disable convert_underscores\n        # would be with Header(convert_underscores=False) at the Pydantic model level\n        default_convert_underscores = getattr(\n            first_field.field_info, \"convert_underscores\", True\n        )\n\n    params_to_process: Dict[str, Any] = {}\n\n    processed_keys = set()\n\n    for field in fields_to_extract:\n        alias = None\n        if isinstance(received_params, Headers):\n            # Handle fields extracted from a Pydantic Model for a header, each field\n  
12run_command
{
 "command": "cat fastapi/dependencies/utils.py | sed -n '869,920p'"
}
{"status": "ok", "stdout": "async def _extract_form_body(\n body_fields: List[ModelField],\n received_body: FormData,\n) -> Dict[str, Any]:\n values = {}\n\n fo
full
{"status": "ok", "stdout": "async def _extract_form_body(\n    body_fields: List[ModelField],\n    received_body: FormData,\n) -> Dict[str, Any]:\n    values = {}\n\n    for field in body_fields:\n        value = _get_multidict_value(field, received_body)\n        field_info = field.field_info\n        if (\n            isinstance(field_info, (params.File, temp_pydantic_v1_params.File))\n            and is_bytes_field(field)\n            and isinstance(value, UploadFile)\n        ):\n            value = await value.read()\n        elif (\n            is_bytes_sequence_field(field)\n            and isinstance(field_info, (params.File, temp_pydantic_v1_params.File))\n            and value_is_sequence(value)\n        ):\n            # For types\n            assert isinstance(value, sequence_types)  # type: ignore[arg-type]\n            results: List[Union[bytes, str]] = []\n\n            async def process_fn(\n                fn: Callable[[], Coroutine[Any, Any, Any]],\n            ) -> None:\n                result = await fn()\n                results.append(result)  # noqa: B023\n\n            async with anyio.create_task_group() as tg:\n                for sub_value in value:\n                    tg.start_soon(process_fn, sub_value.read)\n            value = serialize_sequence_value(field=field, value=results)\n        if value is not None:\n            values[field.alias] = value\n    for key, value in received_body.items():\n        if key not in values:\n            values[key] = value\n    return values\n\n\nasync def request_body_to_args(\n    body_fields: List[ModelField],\n    received_body: Optional[Union[Dict[str, Any], FormData]],\n    embed_body_fields: bool,\n) -> Tuple[Dict[str, Any], List[Dict[str, Any]]]:\n    values: Dict[str, Any] = {}\n    errors: List[Dict[str, Any]] = []\n    assert body_fields, \"request_body_to_args() should be called with fields\"\n    single_not_embedded_field = len(body_fields) == 1 and not embed_body_fields\n    first_fiel
13write_file
{
 "content": "\nfrom fastapi import FastAPI, Form\nfrom fastapi.testclient import TestClient\nfrom pydantic import BaseModel\nfrom typing import Optional\n\napp = FastAPI()\n\n@app.post(\"/test\")\nasync def test_endpoint(name: Optional[str] = Form(None)):\n    return {\"name\": name}\n\nclient = TestClient(app)\n\ndef test_empty_string_form_value():\n    # When an empty string is sent in a form, it should be interpreted as missing (None)\n    # if the default is None.\n    response = client.post(\"/test\", data={\"name\": \"\"})\n    assert response.status_code == 200\n    assert response.json() == {\"name\": None}\n\ndef test_missing_form_value():\n    response = client.post(\"/test\", data={})\n    assert response.status_code == 200\n    assert response.json() == {\"name\": None}\n\ndef test_provided_form_value():\n    response = client.post(\"/test\", data={\"name\": \"fastapi\"})\n    assert response.status_code == 200\n    assert response.json() == {\"name\": \"fastapi\"}\n\nif __name__ == \"__main__\":\n    test_empty_string_form_value()\n    test_missing_form_value()\n    test_provided_form_value()\n    print(\"All tests passed!\")\n",
 "filepath": "reproduce_issue.py"
}
{"status": "ok", "filepath": "reproduce_issue.py", "size": 1079}
full
{"status": "ok", "filepath": "reproduce_issue.py", "size": 1079}
14run_command
{
 "command": "python reproduce_issue.py"
}
{"status": "error", "error_type": "CommandError", "error_message": "Traceback (most recent call last):\n File \"/workspace/reproduce_issue.py\", line 33, in <mo
full
{"status": "error", "error_type": "CommandError", "error_message": "Traceback (most recent call last):\n  File \"/workspace/reproduce_issue.py\", line 33, in <module>\n    test_empty_string_form_value()\n    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^\n  File \"/workspace/reproduce_issue.py\", line 20, in test_empty_string_form_value\n    assert response.json() == {\"name\": None}\n           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\nAssertionError\n", "details": {"stdout": "", "stderr": "Traceback (most recent call last):\n  File \"/workspace/reproduce_issue.py\", line 33, in <module>\n    test_empty_string_form_value()\n    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^\n  File \"/workspace/reproduce_issue.py\", line 20, in test_empty_string_form_value\n    assert response.json() == {\"name\": None}\n           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\nAssertionError\n", "exit_code": 1}}
15run_command
{
 "command": "python -c \"from fastapi import FastAPI, Form; from fastapi.testclient import TestClient; app = FastAPI(); @app.post('/test')\\nasync def test_endpoint(name: str = Form(None)): return {'name': name}\\nclient = TestClient(app); print(client.post('/test', data={'name': ''}).json()\""
}
{"status": "error", "error_type": "CommandError", "error_message": " File \"<string>\", line 1\n from fastapi import FastAPI, Form; from fastapi.testclient impo
full
{"status": "error", "error_type": "CommandError", "error_message": "  File \"<string>\", line 1\n    from fastapi import FastAPI, Form; from fastapi.testclient import TestClient; app = FastAPI(); @app.post('/test')\\nasync def test_endpoint(name: str = Form(None)): return {'name': name}\\nclient = TestClient(app); print(client.post('/test', data={'name': ''}).json()\n                                                                                                   ^\nSyntaxError: invalid syntax\n", "details": {"stdout": "", "stderr": "  File \"<string>\", line 1\n    from fastapi import FastAPI, Form; from fastapi.testclient import TestClient; app = FastAPI(); @app.post('/test')\\nasync def test_endpoint(name: str = Form(None)): return {'name': name}\\nclient = TestClient(app); print(client.post('/test', data={'name': ''}).json()\n                                                                                                   ^\nSyntaxError: invalid syntax\n", "exit_code": 1}}
16run_command
{
 "command": "python reproduce_issue.py | python -m pytest reproduce_issue.py"
}
{"status": "error", "error_type": "CommandError", "error_message": "Traceback (most recent call last):\n File \"/workspace/reproduce_issue.py\", line 33, in <mo
full
{"status": "error", "error_type": "CommandError", "error_message": "Traceback (most recent call last):\n  File \"/workspace/reproduce_issue.py\", line 33, in <module>\n    test_empty_string_form_value()\n    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^\n  File \"/workspace/reproduce_issue.py\", line 20, in test_empty_string_form_value\n    assert response.json() == {\"name\": None}\n           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\nAssertionError\n", "details": {"stdout": "============================= test session starts ==============================\nplatform linux -- Python 3.13.14, pytest-9.1.1, pluggy-1.6.0\ncodspeed: 5.0.3 (disabled, mode: walltime, callgraph: enabled, timer_resolution: 1.0ns)\nrootdir: /workspace\nconfigfile: pytest.ini (WARNING: ignoring pytest config in pyproject.toml!)\nplugins: anyio-4.15.1, sugar-1.1.1, inline-snapshot-0.35.4, timeout-2.4.0, xdist-3.8.0, codspeed-5.0.3, cov-7.1.0\ncollected 4 items\n\nreproduce_issue.py FF..                                                  [100%]\n\n=================================== FAILURES ===================================\n________________________________ test_endpoint _________________________________\nasync def functions are not natively supported.\nYou need to install a suitable plugin for your async framework, for example:\n  - anyio\n  - pytest-asyncio\n  - pytest-tornasync\n  - pytest-trio\n  - pytest-twisted\n_________________________ test_empty_string_form_value _________________________\n\n    def test_empty_string_form_value():\n        # When an empty string is sent in a form, it should be interpreted as missing (None)\n        # if the default is None.\n        response = client.post(\"/test\", data={\"name\": \"\"})\n        assert response.status_code == 200\n>       assert response.json() == {\"name\": None}\nE       AssertionError: assert {'name': ''} == {'name': None}\nE         \nE         Differing items:\nE         {'name': ''} != {'name': None}\nE         Use -v to get more diff\n\nreproduce_i
17run_command
{
 "command": "cat fastapi/dependencies/utils.py | sed -n '869,920p'"
}
{"status": "ok", "stdout": "async def _extract_form_body(\n body_fields: List[ModelField],\n received_body: FormData,\n) -> Dict[str, Any]:\n values = {}\n\n fo
full
{"status": "ok", "stdout": "async def _extract_form_body(\n    body_fields: List[ModelField],\n    received_body: FormData,\n) -> Dict[str, Any]:\n    values = {}\n\n    for field in body_fields:\n        value = _get_multidict_value(field, received_body)\n        field_info = field.field_info\n        if (\n            isinstance(field_info, (params.File, temp_pydantic_v1_params.File))\n            and is_bytes_field(field)\n            and isinstance(value, UploadFile)\n        ):\n            value = await value.read()\n        elif (\n            is_bytes_sequence_field(field)\n            and isinstance(field_info, (params.File, temp_pydantic_v1_params.File))\n            and value_is_sequence(value)\n        ):\n            # For types\n            assert isinstance(value, sequence_types)  # type: ignore[arg-type]\n            results: List[Union[bytes, str]] = []\n\n            async def process_fn(\n                fn: Callable[[], Coroutine[Any, Any, Any]],\n            ) -> None:\n                result = await fn()\n                results.append(result)  # noqa: B023\n\n            async with anyio.create_task_group() as tg:\n                for sub_value in value:\n                    tg.start_soon(process_fn, sub_value.read)\n            value = serialize_sequence_value(field=field, value=results)\n        if value is not None:\n            values[field.alias] = value\n    for key, value in received_body.items():\n        if key not in values:\n            values[key] = value\n    return values\n\n\nasync def request_body_to_args(\n    body_fields: List[ModelField],\n    received_body: Optional[Union[Dict[str, Any], FormData]],\n    embed_body_fields: bool,\n) -> Tuple[Dict[str, Any], List[Dict[str, Any]]]:\n    values: Dict[str, Any] = {}\n    errors: List[Dict[str, Any]] = []\n    assert body_fields, \"request_body_to_args() should be called with fields\"\n    single_not_embedded_field = len(body_fields) == 1 and not embed_body_fields\n    first_fiel
18edit_file
{
 "filepath": "fastapi/dependencies/utils.py",
 "new_string": "async def _extract_form_body(\n    body_fields: List[ModelField],\n    received_body: FormData,\n) -> Dict[str, Any]:\n    values = {}\n    processed_keys = set()\n\n    for field in body_fields:\n        value = _get_multidict_value(field, received_body)\n        field_info = field.field_info\n        if (\n            isinstance(field_info, (params.File, temp_pydantic_v1_params.File))\n            and is_bytes_field(field)\n            and isinstance(value, UploadFile)\n        ):\n            value = await value.read()\n        elif (\n            is_bytes_sequence_field(field)\n            and isinstance(field_info, (params.File, temp_pydantic_v1_params.File))\n            and value_is_sequence(value)\n        ):\n            # For types\n            assert isinstance(value, sequence_types)  # type: ignore[arg-type]\n            results: List[Union[bytes, str]] = []\n\n            async def process_fn(\n                fn: Callable[[], Coroutine[Any, Any, Any]],\n            ) -> None:\n                result = await fn()\n                results.append(result)  # noqa: B023\n\n            async with anyio.create_task_group() as tg:\n                for sub_value in value:\n                    tg.start_soon(process_fn, sub_value.read)\n            value = serialize_sequence_value(field=field, value=results)\n        if value is not None:\n            values[field.alias] = value\n        processed_keys.add(field.alias)\n    for key, value in received_body.items():\n        if key not in processed_keys:\n            values[key] = value\n    return values\n",
 "old_string": "async def _extract_form_body(\n    body_fields: List[ModelField],\n    received_body: FormData,\n) -> Dict[str, Any]:\n    values = {}\n\n    for field in body_fields:\n        value = _get_multidict_value(field, received_body)\n        field_info = field.field_info\n        if (\n            isinstance(field_info, (params.File, temp_pydantic_v1_params.File))\n            and is_bytes_field(field)\n            and isinstance(value, UploadFile)\n        ):\n            value = await value.read()\n        elif (\n            is_bytes_sequence_field(field)\n            and isinstance(field_info, (params.File, temp_pydantic_v1_params.File))\n            and value_is_sequence(value)\n        ):\n            # For types\n            assert isinstance(value, sequence_types)  # type: ignore[arg-type]\n            results: List[Union[bytes, str]] = []\n\n            async def process_fn(\n                fn: Callable[[], Coroutine[Any, Any, Any]],\n            ) -> None:\n                result = await fn()\n                results.append(result)  # noqa: B023\n\n            async with anyio.create_task_group() as tg:\n                for sub_value in value:\n                    tg.start_soon(process_fn, sub_value.read)\n            value = serialize_sequence_value(field=field, value=results)\n        if value is not None:\n            values[field.alias] = value\n    for key, value in received_body.items():\n        if key not in values:\n            values[key] = value\n    return values\n"
}
{"status": "ok", "filepath": "fastapi/dependencies/utils.py", "occurrences": 1, "strategy": "exact", "diff": "--- a/fastapi/dependencies/utils.py\n+++ b/fastapi
full
{"status": "ok", "filepath": "fastapi/dependencies/utils.py", "occurrences": 1, "strategy": "exact", "diff": "--- a/fastapi/dependencies/utils.py\n+++ b/fastapi/dependencies/utils.py\n@@ -871,6 +871,7 @@\n     received_body: FormData,\n ) -> Dict[str, Any]:\n     values = {}\n+    processed_keys = set()\n \n     for field in body_fields:\n         value = _get_multidict_value(field, received_body)\n@@ -902,8 +903,9 @@\n             value = serialize_sequence_value(field=field, value=results)\n         if value is not None:\n             values[field.alias] = value\n+        processed_keys.add(field.alias)\n     for key, value in received_body.items():\n-        if key not in values:\n+        if key not in processed_keys:\n             values[key] = value\n     return values\n \n", "is_truncated": false}
19run_command
{
 "command": "python reproduce_issue.py"
}
{"status": "ok", "stdout": "All tests passed!\n", "stderr": "", "exit_code": 0}
full
{"status": "ok", "stdout": "All tests passed!\n", "stderr": "", "exit_code": 0}
20submit_patch
{}
{"status": "ok", "patch_size": 2096, "files_changed": 2}
full
{"status": "ok", "patch_size": 2096, "files_changed": 2}

Patch

diff --git a/fastapi/dependencies/utils.py b/fastapi/dependencies/utils.py
index d43fa8a5..9f554e7d 100644
--- a/fastapi/dependencies/utils.py
+++ b/fastapi/dependencies/utils.py
@@ -871,6 +871,7 @@ async def _extract_form_body(
     received_body: FormData,
 ) -> Dict[str, Any]:
     values = {}
+    processed_keys = set()
 
     for field in body_fields:
         value = _get_multidict_value(field, received_body)
@@ -902,8 +903,9 @@ async def _extract_form_body(
             value = serialize_sequence_value(field=field, value=results)
         if value is not None:
             values[field.alias] = value
+        processed_keys.add(field.alias)
     for key, value in received_body.items():
-        if key not in values:
+        if key not in processed_keys:
             values[key] = value
     return values
 
diff --git a/reproduce_issue.py b/reproduce_issue.py
new file mode 100644
index 00000000..2ad56e34
--- /dev/null
+++ b/reproduce_issue.py
@@ -0,0 +1,36 @@
+
+from fastapi import FastAPI, Form
+from fastapi.testclient import TestClient
+from pydantic import BaseModel
+from typing import Optional
+
+app = FastAPI()
+
+@app.post("/test")
+async def test_endpoint(name: Optional[str] = Form(None)):
+    return {"name": name}
+
+client = TestClient(app)
+
+def test_empty_string_form_value():
+    # When an empty string is sent in a form, it should be interpreted as missing (None)
+    # if the default is None.
+    response = client.post("/test", data={"name": ""})
+    assert response.status_code == 200
+    assert response.json() == {"name": None}
+
+def test_missing_form_value():
+    response = client.post("/test", data={})
+    assert response.status_code == 200
+    assert response.json() == {"name": None}
+
+def test_provided_form_value():
+    response = client.post("/test", data={"name": "fastapi"})
+    assert response.status_code == 200
+    assert response.json() == {"name": "fastapi"}
+
+if __name__ == "__main__":
+    test_empty_string_form_value()
+    test_missing_form_value()
+    test_provided_form_value()
+    print("All tests passed!")

Test output

show
..                                                                       [100%]
=============================== warnings summary ===============================
../../../../../../kaggle/tmp/envs/overlays/starlette-0.50.0-py3-none-any/starlette/testclient.py:45
  /kaggle/tmp/envs/overlays/starlette-0.50.0-py3-none-any/starlette/testclient.py:45: DeprecationWarning: The anyio.abc.BlockingPortal alias is deprecated, use anyio.from_thread.BlockingPortal instead.
    _PortalFactoryType = Callable[[], AbstractContextManager[anyio.abc.BlockingPortal]]

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
2 passed, 1 warning in 0.71s