← eval7_submission_v1n

fastapi_15588

failed WRONG_FIX wrong_fix · 13 tool calls · 61 s · fastapi/fastapi

Task input

♻️ Validate Server Sent Event fields to avoid applications from sending broken data

## Pull Request

<!--
Please start with a GitHub Discussion.

Once a team member asks you to open a PR, create it and link the discussion here.

Obvious typo fixes can be made in a PR without starting a discussion.
-->

Discussion: <!-- Link to the GitHub Discussion -->

## Description

♻️ Validate Server Sent Event fields to avoid applications from sending broken data

This was reported multiple times as a "vulnerability" by users probably using automated AI tools, with the argument that if input was taken from the request and passed directly to an event unfiltered, it could break the client.

If an app sets an `id` or `event` with multi-line content, I would consider that app broken, and probably the app itself vulnerable to something, not FastAPI. With this change, if any app sets invalid multi-line values (sourced from unfiltered input or in any other way), FastAPI will make it a server error (which it is, as the app is sending invalid data).

I don't think the code before this PR has a bug, less a vulnerability. This change is mainly a quality of life improvement to prevent badly written apps from shooting themselves in the foot by passing unsanitized data directly to a SSE.

<!-- Write the description of your PR here -->

## AI Disclaimer

<!-- If using AI, write here the prompt and model used -->

Codex with GPT-5.5

<details>
<summary>AI transcript</summary>

<!-- Paste here the entire AI transcript -->

</details>

## Checklist

- [ ] This PR is an obvious typo fix, or it links to a GitHub Discussion for the proposed code change.
- [x] I added tests for the change.
- [x] The new or updated tests fail on the main branch and pass on this PR.
- [x] Coverage stays at 100%.
- [x] The documentation explains the change if needed.

Tool calls (14)

#ToolArgumentsResult
1run_command
{
 "command": "grep -rn \"EventSourceResponse\" . | head -20"
}
{"status": "ok", "stdout": "./fastapi/.agents/skills/fastapi/references/streaming.md:16:To stream Server-Sent Events, use `response_class=EventSourceResponse` a
full
{"status": "ok", "stdout": "./fastapi/.agents/skills/fastapi/references/streaming.md:16:To stream Server-Sent Events, use `response_class=EventSourceResponse` and `yield` items from the endpoint.\n./fastapi/.agents/skills/fastapi/references/streaming.md:24:from fastapi.sse import EventSourceResponse\n./fastapi/.agents/skills/fastapi/references/streaming.md:35:@app.get(\"/items/stream\", response_class=EventSourceResponse)\n./fastapi/.agents/skills/fastapi/references/streaming.md:47:from fastapi.sse import EventSourceResponse, ServerSentEvent\n./fastapi/.agents/skills/fastapi/references/streaming.md:52:@app.get(\"/events\", response_class=EventSourceResponse)\n./fastapi/.agents/skills/fastapi/SKILL.md:333:See [the streaming reference](references/streaming.md) for JSON Lines, Server-Sent Events (`EventSourceResponse`, `ServerSentEvent`), and byte streaming (`StreamingResponse`) patterns.\n./fastapi/routing.py:64:    EventSourceResponse,\n./fastapi/routing.py:376:    is_sse_stream = lenient_issubclass(actual_response_class, EventSourceResponse)\n./fastapi/routing.py:856:                    # EventSourceResponse (SSE).\n./fastapi/routing.py:862:                        or lenient_issubclass(response_class, EventSourceResponse)\n./fastapi/routing.py:971:            response_class, EventSourceResponse\n./fastapi/responses.py:5:from fastapi.sse import EventSourceResponse as EventSourceResponse  # noqa\n./fastapi/sse.py:20:class EventSourceResponse(StreamingResponse):\n./fastapi/sse.py:23:    Use as `response_class=EventSourceResponse` on a *path operation* that uses `yield`\n./fastapi/sse.py:46:    `response_class=EventSourceResponse`, each `ServerSentEvent` is encoded\n./tests/test_sse.py:8:from fastapi.responses import EventSourceResponse\n./tests/test_sse.py:29:@app.get(\"/items/stream\", response_class=EventSourceResponse)\n./tests/test_sse.py:35:@app.get(\"/items/stream-sync\", response_class=EventSourceResponse)\n./tests/test_sse.py:40:@app.get(\"/items/stream-no-anno
2run_command
{
 "command": "cat fastapi/sse.py"
}
{"status": "ok", "stdout": "from typing import Annotated, Any\n\nfrom annotated_doc import Doc\nfrom pydantic import AfterValidator, BaseModel, Field, model_val
full
{"status": "ok", "stdout": "from typing import Annotated, Any\n\nfrom annotated_doc import Doc\nfrom pydantic import AfterValidator, BaseModel, Field, model_validator\nfrom starlette.responses import StreamingResponse\n\n# Canonical SSE event schema matching the OpenAPI 3.2 spec\n# (Section 4.14.4 \"Special Considerations for Server-Sent Events\")\n_SSE_EVENT_SCHEMA: dict[str, Any] = {\n    \"type\": \"object\",\n    \"properties\": {\n        \"data\": {\"type\": \"string\"},\n        \"event\": {\"type\": \"string\"},\n        \"id\": {\"type\": \"string\"},\n        \"retry\": {\"type\": \"integer\", \"minimum\": 0},\n    },\n}\n\n\nclass EventSourceResponse(StreamingResponse):\n    \"\"\"Streaming response with `text/event-stream` media type.\n\n    Use as `response_class=EventSourceResponse` on a *path operation* that uses `yield`\n    to enable Server Sent Events (SSE) responses.\n\n    Works with **any HTTP method** (`GET`, `POST`, etc.), which makes it compatible\n    with protocols like MCP that stream SSE over `POST`.\n\n    The actual encoding logic lives in the FastAPI routing layer. This class\n    serves mainly as a marker and sets the correct `Content-Type`.\n    \"\"\"\n\n    media_type = \"text/event-stream\"\n\n\ndef _check_id_no_null(v: str | None) -> str | None:\n    if v is not None and \"\\0\" in v:\n        raise ValueError(\"SSE 'id' must not contain null characters\")\n    return v\n\n\nclass ServerSentEvent(BaseModel):\n    \"\"\"Represents a single Server-Sent Event.\n\n    When `yield`ed from a *path operation function* that uses\n    `response_class=EventSourceResponse`, each `ServerSentEvent` is encoded\n    into the [SSE wire format](https://html.spec.whatwg.org/multipage/server-sent-events.html#parsing-an-event-stream)\n    (`text/event-stream`).\n\n    If you yield a plain object (dict, Pydantic model, etc.) instead, it is\n    automatically JSON-encoded and sent as the `data:` field.\n\n    All `data` values **including plain string
3run_command
{
 "command": "tail -n +100 fastapi/sse.py"
}
{"status": "ok", "stdout": " AfterValidator(_check_id_no_null),\n Doc(\n \"\"\"\n Optional event ID.\n\n The browser sends this value back as the `Last-Event-ID
full
{"status": "ok", "stdout": "        AfterValidator(_check_id_no_null),\n        Doc(\n            \"\"\"\n            Optional event ID.\n\n            The browser sends this value back as the `Last-Event-ID` header on\n            automatic reconnection. **Must not contain null (`\\\\0`) characters.**\n            \"\"\"\n        ),\n    ] = None\n    retry: Annotated[\n        int | None,\n        Field(ge=0),\n        Doc(\n            \"\"\"\n            Optional reconnection time in **milliseconds**.\n\n            Tells the browser how long to wait before reconnecting after the\n            connection is lost. Must be a non-negative integer.\n            \"\"\"\n        ),\n    ] = None\n    comment: Annotated[\n        str | None,\n        Doc(\n            \"\"\"\n            Optional comment line(s).\n\n            Comment lines start with `:` in the SSE wire format and are ignored by\n            `EventSource` clients. Useful for keep-alive pings to prevent\n            proxy/load-balancer timeouts.\n            \"\"\"\n        ),\n    ] = None\n\n    @model_validator(mode=\"after\")\n    def _check_data_exclusive(self) -> \"ServerSentEvent\":\n        if self.data is not None and self.raw_data is not None:\n            raise ValueError(\n                \"Cannot set both 'data' and 'raw_data' on the same \"\n                \"ServerSentEvent. Use 'data' for JSON-serialized payloads \"\n                \"or 'raw_data' for pre-formatted strings.\"\n            )\n        return self\n\n\ndef format_sse_event(\n    *,\n    data_str: Annotated[\n        str | None,\n        Doc(\n            \"\"\"\n            Pre-serialized data string to use as the `data:` field.\n            \"\"\"\n        ),\n    ] = None,\n    event: Annotated[\n        str | None,\n        Doc(\n            \"\"\"\n            Optional event type name (`event:` field).\n            \"\"\"\n        ),\n    ] = None,\n    id: Annotated[\n        str | None,\n        Doc(\n            \"
4run_command
{
 "command": "cat tests/test_sse.py"
}
{"status": "ok", "stdout": "import asyncio\nimport time\nfrom collections.abc import AsyncIterable, Iterable\n\nimport fastapi.routing\nimport pytest\nfrom fast
full
{"status": "ok", "stdout": "import asyncio\nimport time\nfrom collections.abc import AsyncIterable, Iterable\n\nimport fastapi.routing\nimport pytest\nfrom fastapi import APIRouter, FastAPI\nfrom fastapi.responses import EventSourceResponse\nfrom fastapi.sse import ServerSentEvent\nfrom fastapi.testclient import TestClient\nfrom pydantic import BaseModel\n\n\nclass Item(BaseModel):\n    name: str\n    description: str | None = None\n\n\nitems = [\n    Item(name=\"Plumbus\", description=\"A multi-purpose household device.\"),\n    Item(name=\"Portal Gun\", description=\"A portal opening device.\"),\n    Item(name=\"Meeseeks Box\", description=\"A box that summons a Meeseeks.\"),\n]\n\n\napp = FastAPI()\n\n\n@app.get(\"/items/stream\", response_class=EventSourceResponse)\nasync def sse_items() -> AsyncIterable[Item]:\n    for item in items:\n        yield item\n\n\n@app.get(\"/items/stream-sync\", response_class=EventSourceResponse)\ndef sse_items_sync() -> Iterable[Item]:\n    yield from items\n\n\n@app.get(\"/items/stream-no-annotation\", response_class=EventSourceResponse)\nasync def sse_items_no_annotation():\n    for item in items:\n        yield item\n\n\n@app.get(\"/items/stream-sync-no-annotation\", response_class=EventSourceResponse)\ndef sse_items_sync_no_annotation():\n    yield from items\n\n\n@app.get(\"/items/stream-dict\", response_class=EventSourceResponse)\nasync def sse_items_dict():\n    for item in items:\n        yield {\"name\": item.name, \"description\": item.description}\n\n\n@app.get(\"/items/stream-sse-event\", response_class=EventSourceResponse)\nasync def sse_items_event():\n    yield ServerSentEvent(data=\"hello\", event=\"greeting\", id=\"1\")\n    yield ServerSentEvent(data={\"key\": \"value\"}, event=\"json-data\", id=\"2\")\n    yield ServerSentEvent(comment=\"just a comment\")\n    yield ServerSentEvent(data=\"retry-test\", retry=5000)\n\n\n@app.get(\"/items/stream-mixed\", response_class=EventSourceResponse)\nasync def sse_items_mix
5run_command
{
 "command": "tail -n +150 tests/test_sse.py"
}
{"status": "ok", "stdout": "\ndef test_sync_generator_no_annotation(client: TestClient):\n response = client.get(\"/items/stream-sync-no-annotation\")\n assert
full
{"status": "ok", "stdout": "\ndef test_sync_generator_no_annotation(client: TestClient):\n    response = client.get(\"/items/stream-sync-no-annotation\")\n    assert response.status_code == 200\n    assert response.headers[\"content-type\"] == \"text/event-stream; charset=utf-8\"\n\n    data_lines = [\n        line for line in response.text.strip().split(\"\\n\") if line.startswith(\"data: \")\n    ]\n    assert len(data_lines) == 3\n\n\ndef test_dict_items(client: TestClient):\n    response = client.get(\"/items/stream-dict\")\n    assert response.status_code == 200\n    data_lines = [\n        line for line in response.text.strip().split(\"\\n\") if line.startswith(\"data: \")\n    ]\n    assert len(data_lines) == 3\n    assert '\"name\"' in data_lines[0]\n\n\ndef test_post_method_sse(client: TestClient):\n    \"\"\"SSE should work with POST (needed for MCP compatibility).\"\"\"\n    response = client.post(\"/items/stream-post\")\n    assert response.status_code == 200\n    assert response.headers[\"content-type\"] == \"text/event-stream; charset=utf-8\"\n    data_lines = [\n        line for line in response.text.strip().split(\"\\n\") if line.startswith(\"data: \")\n    ]\n    assert len(data_lines) == 3\n\n\ndef test_sse_events_with_fields(client: TestClient):\n    response = client.get(\"/items/stream-sse-event\")\n    assert response.status_code == 200\n    text = response.text\n\n    assert \"event: greeting\\n\" in text\n    assert 'data: \"hello\"\\n' in text\n    assert \"id: 1\\n\" in text\n\n    assert \"event: json-data\\n\" in text\n    assert \"id: 2\\n\" in text\n    assert 'data: {\"key\": \"value\"}\\n' in text\n\n    assert \": just a comment\\n\" in text\n\n    assert \"retry: 5000\\n\" in text\n    assert 'data: \"retry-test\"\\n' in text\n\n\ndef test_mixed_plain_and_sse_events(client: TestClient):\n    response = client.get(\"/items/stream-mixed\")\n    assert response.status_code == 200\n    text = response.text\n\n    assert \"event: special
6run_command
{
 "command": "python3 -m pytest tests/test_sse.py"
}
{"status": "ok", "stdout": "============================= test session starts ==============================\nplatform linux -- Python 3.13.14, pytest-9.1.1, pl
full
{"status": "ok", "stdout": "============================= test session starts ==============================\nplatform linux -- Python 3.13.14, pytest-9.1.1, pluggy-1.6.0\ncodspeed: 5.0.3 (disabled, mode: walltime, callgraph: enabled, timer_resolution: 1.0ns)\nrootdir: /workspace\nconfigfile: pytest.ini (WARNING: ignoring pytest config in pyproject.toml!)\nplugins: anyio-4.15.1, sugar-1.1.1, inline-snapshot-0.35.4, timeout-2.4.0, xdist-3.8.0, codspeed-5.0.3, cov-7.1.0\ncollected 18 items\n\ntests/test_sse.py ..................                                     [100%]\n\n=============================== warnings summary ===============================\n../../../../../../kaggle/tmp/envs/overlays/starlette-1.6.0-py3-none-any/starlette/testclient.py:53\n  /kaggle/tmp/envs/overlays/starlette-1.6.0-py3-none-any/starlette/testclient.py:53: DeprecationWarning: The anyio.abc.BlockingPortal alias is deprecated, use anyio.from_thread.BlockingPortal instead.\n    _PortalFactoryType = Callable[[], AbstractContextManager[anyio.abc.BlockingPortal]]\n\n-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html\n======================== 18 passed, 1 warning in 1.25s =========================\n", "stderr": "", "exit_code": 0}
7run_command
{
 "command": "cat -n fastapi/sse.py"
}
{"status": "ok", "stdout": " 1\tfrom typing import Annotated, Any\n 2\t\n 3\tfrom annotated_doc import Doc\n 4\tfrom pydantic import AfterValidator, BaseModel,
full
{"status": "ok", "stdout": "     1\tfrom typing import Annotated, Any\n     2\t\n     3\tfrom annotated_doc import Doc\n     4\tfrom pydantic import AfterValidator, BaseModel, Field, model_validator\n     5\tfrom starlette.responses import StreamingResponse\n     6\t\n     7\t# Canonical SSE event schema matching the OpenAPI 3.2 spec\n     8\t# (Section 4.14.4 \"Special Considerations for Server-Sent Events\")\n     9\t_SSE_EVENT_SCHEMA: dict[str, Any] = {\n    10\t    \"type\": \"object\",\n    11\t    \"properties\": {\n    12\t        \"data\": {\"type\": \"string\"},\n    13\t        \"event\": {\"type\": \"string\"},\n    14\t        \"id\": {\"type\": \"string\"},\n    15\t        \"retry\": {\"type\": \"integer\", \"minimum\": 0},\n    16\t    },\n    17\t}\n    18\t\n    19\t\n    20\tclass EventSourceResponse(StreamingResponse):\n    21\t    \"\"\"Streaming response with `text/event-stream` media type.\n    22\t\n    23\t    Use as `response_class=EventSourceResponse` on a *path operation* that uses `yield`\n    24\t    to enable Server Sent Events (SSE) responses.\n    25\t\n    26\t    Works with **any HTTP method** (`GET`, `POST`, etc.), which makes it compatible\n    27\t    with protocols like MCP that stream SSE over `POST`.\n    28\t\n    29\t    The actual encoding logic lives in the FastAPI routing layer. This class\n    30\t    serves mainly as a marker and sets the correct `Content-Type`.\n    31\t    \"\"\"\n    32\t\n    33\t    media_type = \"text/event-stream\"\n    34\t\n    35\t\n    36\tdef _check_id_no_null(v: str | None) -> str | None:\n    37\t    if v is not None and \"\\0\" in v:\n    38\t        raise ValueError(\"SSE 'id' must not contain null characters\")\n    39\t    return v\n    40\t\n    41\t\n    42\tclass ServerSentEvent(BaseModel):\n    43\t    \"\"\"Represents a single Server-Sent Event.\n    44\t\n    45\t    When `yield`ed from a *path operation function* that uses\n    46\t    `response_class=EventSourceResponse`, each 
8run_command
{
 "command": "tail -n +130 fastapi/sse.py"
}
{"status": "ok", "stdout": " proxy/load-balancer timeouts.\n \"\"\"\n ),\n ] = None\n\n @model_validator(mode=\"after\")\n def _check_data_exclusive(self) -> \"
full
{"status": "ok", "stdout": "            proxy/load-balancer timeouts.\n            \"\"\"\n        ),\n    ] = None\n\n    @model_validator(mode=\"after\")\n    def _check_data_exclusive(self) -> \"ServerSentEvent\":\n        if self.data is not None and self.raw_data is not None:\n            raise ValueError(\n                \"Cannot set both 'data' and 'raw_data' on the same \"\n                \"ServerSentEvent. Use 'data' for JSON-serialized payloads \"\n                \"or 'raw_data' for pre-formatted strings.\"\n            )\n        return self\n\n\ndef format_sse_event(\n    *,\n    data_str: Annotated[\n        str | None,\n        Doc(\n            \"\"\"\n            Pre-serialized data string to use as the `data:` field.\n            \"\"\"\n        ),\n    ] = None,\n    event: Annotated[\n        str | None,\n        Doc(\n            \"\"\"\n            Optional event type name (`event:` field).\n            \"\"\"\n        ),\n    ] = None,\n    id: Annotated[\n        str | None,\n        Doc(\n            \"\"\"\n            Optional event ID (`id:` field).\n            \"\"\"\n        ),\n    ] = None,\n    retry: Annotated[\n        int | None,\n        Doc(\n            \"\"\"\n            Optional reconnection time in milliseconds (`retry:` field).\n            \"\"\"\n        ),\n    ] = None,\n    comment: Annotated[\n        str | None,\n        Doc(\n            \"\"\"\n            Optional comment line(s) (`:` prefix).\n            \"\"\"\n        ),\n    ] = None,\n) -> bytes:\n    \"\"\"Build SSE wire-format bytes from **pre-serialized** data.\n\n    The result always ends with `\\n\\n` (the event terminator).\n    \"\"\"\n    lines: list[str] = []\n\n    if comment is not None:\n        for line in comment.splitlines():\n            lines.append(f\": {line}\")\n\n    if event is not None:\n        lines.append(f\"event: {event}\")\n\n    if data_str is not None:\n        for line in data_str.splitlines():\n            lines.append(f
9edit_file
{
 "filepath": "fastapi/sse.py",
 "new_string": "def _check_sse_field_no_newline(v: str | None) -> str | None:\n    if v is not None and \"\\n\" in v:\n        raise ValueError(\"SSE field must not contain newline characters\")\n    return v\n\n\ndef _check_id_no_null(v: str | None) -> str | None:\n    if v is not None and \"\\0\" in v:\n        raise ValueError(\"SSE 'id' must not contain null characters\")\n    if v is not None and \"\\n\" in v:\n        raise ValueError(\"SSE 'id' must not contain newline characters\")\n    return v",
 "old_string": "def _check_id_no_null(v: str | None) -> str | None:\n    if v is not None and \"\\0\" in v:\n        raise ValueError(\"SSE 'id' must not contain null characters\")\n    return v"
}
{"status": "ok", "filepath": "fastapi/sse.py", "occurrences": 1, "strategy": "exact", "diff": "--- a/fastapi/sse.py\n+++ b/fastapi/sse.py\n@@ -33,9 +33,17 @@\n
full
{"status": "ok", "filepath": "fastapi/sse.py", "occurrences": 1, "strategy": "exact", "diff": "--- a/fastapi/sse.py\n+++ b/fastapi/sse.py\n@@ -33,9 +33,17 @@\n     media_type = \"text/event-stream\"\n \n \n+def _check_sse_field_no_newline(v: str | None) -> str | None:\n+    if v is not None and \"\\n\" in v:\n+        raise ValueError(\"SSE field must not contain newline characters\")\n+    return v\n+\n+\n def _check_id_no_null(v: str | None) -> str | None:\n     if v is not None and \"\\0\" in v:\n         raise ValueError(\"SSE 'id' must not contain null characters\")\n+    if v is not None and \"\\n\" in v:\n+        raise ValueError(\"SSE 'id' must not contain newline characters\")\n     return v\n \n \n", "is_truncated": false}
10edit_file
{
 "filepath": "fastapi/sse.py",
 "new_string": "    event: Annotated[\n        str | None,\n        AfterValidator(_check_sse_field_no_newline),\n        Doc(\n            \"\"\"\n            Optional event type name.",
 "old_string": "    event: Annotated[\n        str | None,\n        Doc(\n            \"\"\"\n            Optional event type name."
}
{"status": "ok", "filepath": "fastapi/sse.py", "occurrences": 1, "strategy": "exact", "diff": "--- a/fastapi/sse.py\n+++ b/fastapi/sse.py\n@@ -94,6 +94,7 @@\n ]
full
{"status": "ok", "filepath": "fastapi/sse.py", "occurrences": 1, "strategy": "exact", "diff": "--- a/fastapi/sse.py\n+++ b/fastapi/sse.py\n@@ -94,6 +94,7 @@\n     ] = None\n     event: Annotated[\n         str | None,\n+        AfterValidator(_check_sse_field_no_newline),\n         Doc(\n             \"\"\"\n             Optional event type name.\n", "is_truncated": false}
11run_command
{
 "command": "python3 -m pytest tests/test_sse.py"
}
{"status": "ok", "stdout": "============================= test session starts ==============================\nplatform linux -- Python 3.13.14, pytest-9.1.1, pl
full
{"status": "ok", "stdout": "============================= test session starts ==============================\nplatform linux -- Python 3.13.14, pytest-9.1.1, pluggy-1.6.0\ncodspeed: 5.0.3 (disabled, mode: walltime, callgraph: enabled, timer_resolution: 1.0ns)\nrootdir: /workspace\nconfigfile: pytest.ini (WARNING: ignoring pytest config in pyproject.toml!)\nplugins: anyio-4.15.1, sugar-1.1.1, inline-snapshot-0.35.4, timeout-2.4.0, xdist-3.8.0, codspeed-5.0.3, cov-7.1.0\ncollected 18 items\n\ntests/test_sse.py ..................                                     [100%]\n\n=============================== warnings summary ===============================\n../../../../../../kaggle/tmp/envs/overlays/starlette-1.6.0-py3-none-any/starlette/testclient.py:53\n  /kaggle/tmp/envs/overlays/starlette-1.6.0-py3-none-any/starlette/testclient.py:53: DeprecationWarning: The anyio.abc.BlockingPortal alias is deprecated, use anyio.from_thread.BlockingPortal instead.\n    _PortalFactoryType = Callable[[], AbstractContextManager[anyio.abc.BlockingPortal]]\n\n-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html\n======================== 18 passed, 1 warning in 1.34s =========================\n", "stderr": "", "exit_code": 0}
12write_file
{
 "content": "import pytest\nfrom fastapi.sse import ServerSentEvent\n\ndef test_sse_event_newline_in_event_rejected():\n    with pytest.raises(ValueError, match=\"SSE field must not contain newline characters\"):\n        ServerSentEvent(event=\"greeting\\nnextline\")\n\ndef test_sse_event_newline_in_id_rejected():\n    with pytest.raises(ValueError, match=\"SSE 'id' must not contain newline characters\"):\n        ServerSentEvent(id=\"1\\n2\")\n\ndef test_sse_event_newline_in_data_allowed():\n    # data can contain newlines because it's split into multiple 'data:' lines in format_sse_event\n    # and if it's JSON encoded, newlines are escaped.\n    # ServerSentEvent.data is Any, so it doesn't have a validator for newlines.\n    # Let's verify it doesn't raise ValueError.\n    ServerSentEvent(data=\"line1\\nline2\")\n    ServerSentEvent(raw_data=\"line1\\nline2\")\n",
 "filepath": "tests/test_sse_validation.py"
}
{"status": "ok", "filepath": "tests/test_sse_validation.py", "size": 831}
full
{"status": "ok", "filepath": "tests/test_sse_validation.py", "size": 831}
13run_command
{
 "command": "python3 -m pytest tests/test_sse_validation.py"
}
{"status": "ok", "stdout": "============================= test session starts ==============================\nplatform linux -- Python 3.13.14, pytest-9.1.1, pl
full
{"status": "ok", "stdout": "============================= test session starts ==============================\nplatform linux -- Python 3.13.14, pytest-9.1.1, pluggy-1.6.0\ncodspeed: 5.0.3 (disabled, mode: walltime, callgraph: enabled, timer_resolution: 1.0ns)\nrootdir: /workspace\nconfigfile: pytest.ini (WARNING: ignoring pytest config in pyproject.toml!)\nplugins: anyio-4.15.1, sugar-1.1.1, inline-snapshot-0.35.4, timeout-2.4.0, xdist-3.8.0, codspeed-5.0.3, cov-7.1.0\ncollected 3 items\n\ntests/test_sse_validation.py ...                                         [100%]\n\n============================== 3 passed in 0.41s ===============================\n", "stderr": "", "exit_code": 0}
14submit_patch
{}
{"status": "ok", "patch_size": 1981, "files_changed": 2}
full
{"status": "ok", "patch_size": 1981, "files_changed": 2}

Patch

diff --git a/fastapi/sse.py b/fastapi/sse.py
index 901d82496..5f19035ed 100644
--- a/fastapi/sse.py
+++ b/fastapi/sse.py
@@ -33,9 +33,17 @@ class EventSourceResponse(StreamingResponse):
     media_type = "text/event-stream"
 
 
+def _check_sse_field_no_newline(v: str | None) -> str | None:
+    if v is not None and "\n" in v:
+        raise ValueError("SSE field must not contain newline characters")
+    return v
+
+
 def _check_id_no_null(v: str | None) -> str | None:
     if v is not None and "\0" in v:
         raise ValueError("SSE 'id' must not contain null characters")
+    if v is not None and "\n" in v:
+        raise ValueError("SSE 'id' must not contain newline characters")
     return v
 
 
@@ -86,6 +94,7 @@ class ServerSentEvent(BaseModel):
     ] = None
     event: Annotated[
         str | None,
+        AfterValidator(_check_sse_field_no_newline),
         Doc(
             """
             Optional event type name.
diff --git a/tests/test_sse_validation.py b/tests/test_sse_validation.py
new file mode 100644
index 000000000..0ae63dc28
--- /dev/null
+++ b/tests/test_sse_validation.py
@@ -0,0 +1,18 @@
+import pytest
+from fastapi.sse import ServerSentEvent
+
+def test_sse_event_newline_in_event_rejected():
+    with pytest.raises(ValueError, match="SSE field must not contain newline characters"):
+        ServerSentEvent(event="greeting\nnextline")
+
+def test_sse_event_newline_in_id_rejected():
+    with pytest.raises(ValueError, match="SSE 'id' must not contain newline characters"):
+        ServerSentEvent(id="1\n2")
+
+def test_sse_event_newline_in_data_allowed():
+    # data can contain newlines because it's split into multiple 'data:' lines in format_sse_event
+    # and if it's JSON encoded, newlines are escaped.
+    # ServerSentEvent.data is Any, so it doesn't have a validator for newlines.
+    # Let's verify it doesn't raise ValueError.
+    ServerSentEvent(data="line1\nline2")
+    ServerSentEvent(raw_data="line1\nline2")

Test output

show
..........F
=================================== FAILURES ===================================
_ test_server_sent_event_single_line_fields_reject_newlines[first\nsecond-event] _

field_name = 'event', value = 'first\nsecond'

    @pytest.mark.parametrize("field_name", ["event", "id"])
    @pytest.mark.parametrize("value", ["first\nsecond", "first\rsecond", "first\r\nsecond"])
    def test_server_sent_event_single_line_fields_reject_newlines(
        field_name: str, value: str
    ):
>       with pytest.raises(ValueError, match=f"SSE '{field_name}' must be a single line"):
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
E       AssertionError: Regex pattern did not match.
E         Expected regex: "SSE 'event' must be a single line"
E         Actual message: "1 validation error for ServerSentEvent\nevent\n  Value error, SSE field must not contain newline characters [type=value_error, input_value='first\\nsecond', input_type=str]\n    For further information visit https://errors.pydantic.dev/2.13/v/value_error"

tests/test_sse.py:229: AssertionError
=============================== warnings summary ===============================
../../../../../../kaggle/tmp/envs/overlays/starlette-1.6.0-py3-none-any/starlette/testclient.py:53
  /kaggle/tmp/envs/overlays/starlette-1.6.0-py3-none-any/starlette/testclient.py:53: DeprecationWarning: The anyio.abc.BlockingPortal alias is deprecated, use anyio.from_thread.BlockingPortal instead.
    _PortalFactoryType = Callable[[], AbstractContextManager[anyio.abc.BlockingPortal]]

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
!!!!!!!!!!!!!!!!!!!!!!!!!! stopping after 1 failures !!!!!!!!!!!!!!!!!!!!!!!!!!!
1 failed, 10 passed, 1 warning in 0.79s